From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BE50A0353; Thu, 24 Feb 2022 08:29:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 710884116A; Thu, 24 Feb 2022 08:29:22 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id CF0EE4114D for ; Thu, 24 Feb 2022 08:29:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645687761; x=1677223761; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=OM1eE7tdoNr9+q0FSMzQS0U8RoJ8/tHn1xXYuqvzV2I=; b=Z4W26piKAuVRCZzKeWDan2WD3upc5qkvZu5NIsmTbfqu8le3goMWpLjR +pum6IqJOGwsGz/vbwo0ts4/sgSbpHvaHGMD2RjFHsWrBMsxNuCCFSdx3 Nil1+MRXZEdNL7rVk2XymXnGgi3pWaDfPL5a5KjZsBb8rGTcPt8IynIAe k2MJIGPAw+zOei+hD5iCEWZHF36gYRvI+jH2SLgTZAM2ChpwoECGS/fcz 8zvMjRjdAoR9HBzUZbNqY8ud+fyvzPLGGhd4xz4g2H48Eq8y4ZF00YkJD 8j5ZlEyefRbbgEe9CrVuHTIj8sygmwVBD97ckcQ5TBL8XNoAenh+Rl10x w==; X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="252364561" X-IronPort-AV: E=Sophos;i="5.88,393,1635231600"; d="scan'208";a="252364561" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 23:29:20 -0800 X-IronPort-AV: E=Sophos;i="5.88,393,1635231600"; d="scan'208";a="491506784" Received: from unknown (HELO localhost.localdomain) ([10.239.251.226]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2022 23:29:19 -0800 From: Yu Jiang To: lijuan.tu@intel.com, dts@dpdk.org Cc: Yu Jiang Subject: [dts][PATCH V1 1/2] tests/flow_classify*: wait for interface up Date: Thu, 24 Feb 2022 15:28:50 +0000 Message-Id: <20220224152851.1511890-2-yux.jiang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220224152851.1511890-1-yux.jiang@intel.com> References: <20220224152851.1511890-1-yux.jiang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org optimize script: flow_classify/flow_classify_softnic, 1, use new method: is_interface_up to to ensure iface's link status before send_packets 2, wait_link_status_up for all ports after start testpmd Signed-off-by: Yu Jiang --- tests/TestSuite_flow_classify.py | 1 + tests/TestSuite_flow_classify_softnic.py | 9 ++++++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/TestSuite_flow_classify.py b/tests/TestSuite_flow_classify.py index 200d39e0..5b28b884 100644 --- a/tests/TestSuite_flow_classify.py +++ b/tests/TestSuite_flow_classify.py @@ -253,6 +253,7 @@ class TestFlowClassify(TestCase): tx_iface = config.get('tx_intf') cmd = "ifconfig {0} up".format(tx_iface) self.tester.send_expect(cmd, '# ', 30) + self.verify(self.tester.is_interface_up(intf=tx_iface), "Wrong link status, should be up") pkts = config.get('stream') # stream config stream_configs = config.get('stream configs') diff --git a/tests/TestSuite_flow_classify_softnic.py b/tests/TestSuite_flow_classify_softnic.py index 7b6642d0..c5004f16 100644 --- a/tests/TestSuite_flow_classify_softnic.py +++ b/tests/TestSuite_flow_classify_softnic.py @@ -179,12 +179,15 @@ class TestFlowClassifySoftnic(TestCase): Sent pkts that read from the pcap_file. Return the sniff pkts. """ - self.pmdout.wait_link_status_up(self.dut_ports[0]) + self.pmdout.wait_link_status_up('all') tx_port = self.tester.get_local_port(self.dut_ports[from_port%self.port_num]) rx_port = self.tester.get_local_port(self.dut_ports[to_port%self.port_num]) tx_interface = self.tester.get_interface(tx_port) rx_interface = self.tester.get_interface(rx_port) + # check tester's link status before send packet + for iface in [tx_interface, rx_interface]: + self.verify(self.tester.is_interface_up(intf=iface), "Wrong link status, should be up") self.tcpdump_start_sniff(rx_interface, filters) @@ -284,9 +287,9 @@ class TestFlowClassifySoftnic(TestCase): """ Sends continuous packets. """ - self.pmdout.wait_link_status_up(self.dut_ports[0]) + self.pmdout.wait_link_status_up('all') + self.verify(self.tester.is_interface_up(intf=itf), "Wrong link status, should be up") self.tester.scapy_foreground() - time.sleep(2) if src_dst == "src": if ptype == "ipv4": var = src_addr.split(".") -- 2.25.1