test suite reviews and discussions
 help / color / mirror / Atom feed
From: Wei Ling <weix.ling@intel.com>
To: dts@dpdk.org
Cc: Wei Ling <weix.ling@intel.com>
Subject: [dts][PATCH V1 2/2] tests/vswitch_sample_cbdma: modify testsuite by DPDK change
Date: Thu, 10 Mar 2022 15:53:27 +0800	[thread overview]
Message-ID: <20220310075327.493863-1-weix.ling@intel.com> (raw)

By DPDK commit 917229c24e, no need to modify DPDK code to test.
1.Delete modify DPDK code steps.
2.Add --total-num-mbufs 600000 params when start dpdk-vhost.
3.Modify verify the test result expect value.

Signed-off-by: Wei Ling <weix.ling@intel.com>
---
 tests/TestSuite_vswitch_sample_cbdma.py | 24 +++++++++---------------
 1 file changed, 9 insertions(+), 15 deletions(-)

diff --git a/tests/TestSuite_vswitch_sample_cbdma.py b/tests/TestSuite_vswitch_sample_cbdma.py
index bd41135b..a332214f 100644
--- a/tests/TestSuite_vswitch_sample_cbdma.py
+++ b/tests/TestSuite_vswitch_sample_cbdma.py
@@ -54,7 +54,7 @@ class TestVswitchSampleCBDMA(TestCase):
         """
         Run at the start of each test suite.
         """
-        self.set_max_queues(512)
+        #self.set_max_queues(512)
         self.build_vhost_app()
         self.tester_tx_port_num = 1
         self.dut_ports = self.dut.get_ports()
@@ -141,15 +141,15 @@ class TestVswitchSampleCBDMA(TestCase):
             allow_option += ' -a {}'.format(item)
         if with_cbdma:
             if client_mode:
-                params = (" -c {} -n {} {} -- -p 0x1 --mergeable 1 --vm2vm 1 --dma-type ioat --stats 1 "
-                          + socket_file_param + "--dmas [{}] --client").format(self.vhost_core_mask, self.mem_channels,
+                params = (" -c {} -n {} {} -- -p 0x1 --mergeable 1 --vm2vm 1 --stats 1 "
+                          + socket_file_param + "--dmas [{}] --client --total-num-mbufs 600000").format(self.vhost_core_mask, self.mem_channels,
                                                                                allow_option, self.dmas_info)
             else:
-                params = (" -c {} -n {} {} -- -p 0x1 --mergeable 1 --vm2vm 1 --dma-type ioat --stats 1 "
-                          + socket_file_param + "--dmas [{}]").format(self.vhost_core_mask, self.mem_channels,
+                params = (" -c {} -n {} {} -- -p 0x1 --mergeable 1 --vm2vm 1 --stats 1 "
+                          + socket_file_param + "--dmas [{}] --total-num-mbufs 600000").format(self.vhost_core_mask, self.mem_channels,
                                                                       allow_option, self.dmas_info)
         else:
-            params = (" -c {} -n {} {} -- -p 0x1 --mergeable 1 --vm2vm 1 --stats 1 " + socket_file_param).format(
+            params = (" -c {} -n {} {} -- -p 0x1 --mergeable 1 --vm2vm 1 --stats 1 " + socket_file_param + "--total-num-mbufs 600000").format(
                 self.vhost_core_mask, self.mem_channels, allow_option)
         self.command_line = self.app_path + params
         self.vhost_user.send_command(self.command_line)
@@ -589,15 +589,9 @@ class TestVswitchSampleCBDMA(TestCase):
             self.result_table_add(table_row)
         self.result_table_print()
         for key in before_relunch_result.keys():
-            if key == 64:
-                self.verify(before_relunch_result[key] > 1, "The perf test result is lower than 1 Mpps")
-            else:
-                self.verify(before_relunch_result[key] > 0.1, "The perf test result is lower than 0.1 Mpps")
+            self.verify(before_relunch_result[key] > 0.1, "The perf test result is lower than 0.1 Mpps")
         for key in after_relunch_result.keys():
-            if key == 64:
-                self.verify(after_relunch_result[key] > 1, "The perf test result is lower than 1 Mpps")
-            else:
-                self.verify(after_relunch_result[key] > 0.1, "The perf test result is lower than 0.1 Mpps")
+            self.verify(after_relunch_result[key] > 0.1, "The perf test result is lower than 0.1 Mpps")
 
     def vm2vm_check_with_two_vhost_device(self):
         rx_throughput = {}
@@ -828,5 +822,5 @@ class TestVswitchSampleCBDMA(TestCase):
         """
         Run after each test suite.
         """
-        self.set_max_queues(128)
+        #self.set_max_queues(128)
         self.close_all_session()
-- 
2.25.1


             reply	other threads:[~2022-03-10  7:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10  7:53 Wei Ling [this message]
2022-03-11  1:30 ` Tu, Lijuan
  -- strict thread matches above, loose matches on Subject: below --
2022-03-11  1:44 Wei Ling
2022-03-11 11:43 ` Tu, Lijuan
2022-03-10  7:41 Wei Ling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220310075327.493863-1-weix.ling@intel.com \
    --to=weix.ling@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).