test suite reviews and discussions
 help / color / mirror / Atom feed
* [PATCH v1 1/2] stats_reporter: properly use iterable in for cycle
@ 2022-04-27  7:41 Juraj Linkeš
  2022-04-27  7:41 ` [PATCH v1 2/2] python: fix shebangs Juraj Linkeš
  2022-04-28  3:15 ` [PATCH v1 1/2] stats_reporter: properly use iterable in for cycle Dong, JunX
  0 siblings, 2 replies; 4+ messages in thread
From: Juraj Linkeš @ 2022-04-27  7:41 UTC (permalink / raw)
  To: junx.dong, lijuan.tu, ohilyard; +Cc: dts, Juraj Linkeš

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
 framework/stats_reporter.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/stats_reporter.py b/framework/stats_reporter.py
index 80ac942c..1c1ab3fd 100644
--- a/framework/stats_reporter.py
+++ b/framework/stats_reporter.py
@@ -70,7 +70,7 @@ class StatsReporter(object):
                 "dpdk_version = {}\n".format(self.result.current_dpdk_version(duts[0]))
             )
         else:
-            for dut in duts():
+            for dut in duts:
                 dpdk_version = self.result.current_dpdk_version(dut)
                 self.stats_file.write(
                     "{}.dpdk_version = {}\n".format(dut, dpdk_version)
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v1 2/2] python: fix shebangs
  2022-04-27  7:41 [PATCH v1 1/2] stats_reporter: properly use iterable in for cycle Juraj Linkeš
@ 2022-04-27  7:41 ` Juraj Linkeš
  2022-04-28  3:15 ` [PATCH v1 1/2] stats_reporter: properly use iterable in for cycle Dong, JunX
  1 sibling, 0 replies; 4+ messages in thread
From: Juraj Linkeš @ 2022-04-27  7:41 UTC (permalink / raw)
  To: junx.dong, lijuan.tu, ohilyard; +Cc: dts, Juraj Linkeš

Remove shebangs in __init__.py files as they're not supposed to be
executed.
Modify the other shebangs so that virtualenvs can be used.

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
 dep/__init__.py              | 1 -
 framework/__init__.py        | 1 -
 main.py                      | 2 +-
 nics/__init__.py             | 1 -
 tests/__init__.py            | 1 -
 tools/__init__.py            | 1 -
 vm_images/create_vm_image.py | 2 +-
 7 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/dep/__init__.py b/dep/__init__.py
index ae0043b7..412dbab4 100644
--- a/dep/__init__.py
+++ b/dep/__init__.py
@@ -1,4 +1,3 @@
-#!/usr/bin/python3
 # BSD LICENSE
 #
 # Copyright (c) 2021 PANTHEON.tech s.r.o.
diff --git a/framework/__init__.py b/framework/__init__.py
index ae0043b7..412dbab4 100644
--- a/framework/__init__.py
+++ b/framework/__init__.py
@@ -1,4 +1,3 @@
-#!/usr/bin/python3
 # BSD LICENSE
 #
 # Copyright (c) 2021 PANTHEON.tech s.r.o.
diff --git a/main.py b/main.py
index f4f5e03a..b625cecf 100755
--- a/main.py
+++ b/main.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python3
+#!/usr/bin/env python3
 # BSD LICENSE
 #
 # Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
diff --git a/nics/__init__.py b/nics/__init__.py
index ae0043b7..412dbab4 100644
--- a/nics/__init__.py
+++ b/nics/__init__.py
@@ -1,4 +1,3 @@
-#!/usr/bin/python3
 # BSD LICENSE
 #
 # Copyright (c) 2021 PANTHEON.tech s.r.o.
diff --git a/tests/__init__.py b/tests/__init__.py
index ae0043b7..412dbab4 100644
--- a/tests/__init__.py
+++ b/tests/__init__.py
@@ -1,4 +1,3 @@
-#!/usr/bin/python3
 # BSD LICENSE
 #
 # Copyright (c) 2021 PANTHEON.tech s.r.o.
diff --git a/tools/__init__.py b/tools/__init__.py
index ae0043b7..412dbab4 100644
--- a/tools/__init__.py
+++ b/tools/__init__.py
@@ -1,4 +1,3 @@
-#!/usr/bin/python3
 # BSD LICENSE
 #
 # Copyright (c) 2021 PANTHEON.tech s.r.o.
diff --git a/vm_images/create_vm_image.py b/vm_images/create_vm_image.py
index 221477bb..4be9630d 100755
--- a/vm_images/create_vm_image.py
+++ b/vm_images/create_vm_image.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python3
+#!/usr/bin/env python3
 
 import argparse
 import enum
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH v1 1/2] stats_reporter: properly use iterable in for cycle
  2022-04-27  7:41 [PATCH v1 1/2] stats_reporter: properly use iterable in for cycle Juraj Linkeš
  2022-04-27  7:41 ` [PATCH v1 2/2] python: fix shebangs Juraj Linkeš
@ 2022-04-28  3:15 ` Dong, JunX
  1 sibling, 0 replies; 4+ messages in thread
From: Dong, JunX @ 2022-04-28  3:15 UTC (permalink / raw)
  To: Juraj Linkeš, dts; +Cc: Tu, Lijuan, ohilyard

Acked-by: Jun Dong <junx.dong@intel.com>

> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: Wednesday, April 27, 2022 3:42 PM
> To: Dong, JunX <junx.dong@intel.com>; Tu, Lijuan <lijuan.tu@intel.com>;
> ohilyard@iol.unh.edu
> Cc: dts@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> Subject: [PATCH v1 1/2] stats_reporter: properly use iterable in for cycle
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
>  framework/stats_reporter.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/framework/stats_reporter.py b/framework/stats_reporter.py
> index 80ac942c..1c1ab3fd 100644
> --- a/framework/stats_reporter.py
> +++ b/framework/stats_reporter.py
> @@ -70,7 +70,7 @@ class StatsReporter(object):
>                  "dpdk_version =
> {}\n".format(self.result.current_dpdk_version(duts[0]))
>              )
>          else:
> -            for dut in duts():
> +            for dut in duts:
>                  dpdk_version = self.result.current_dpdk_version(dut)
>                  self.stats_file.write(
>                      "{}.dpdk_version = {}\n".format(dut, dpdk_version)
> --
> 2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v1 1/2] stats_reporter: properly use iterable in for cycle
@ 2022-05-05  6:47 lijuan.tu
  0 siblings, 0 replies; 4+ messages in thread
From: lijuan.tu @ 2022-05-05  6:47 UTC (permalink / raw)
  To: junx.dong, lijuan.tu, ohilyard

Juraj =?utf-8?q?Linkeš?= <juraj.linkes@pantheon.tech>
Reply-To: Juraj =?utf-8?q?Linkeš?= <juraj.linkes@pantheon.tech>
Cc: dts@dpdk.org, Juraj =?utf-8?q?Linkeš?= <juraj.linkes@pantheon.tech>
In-Reply-To: <20220427074152.4144881-1-juraj.linkes@pantheon.tech>

On Wed, 27 Apr 2022 07:41:51 +0000, =?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech> wrote:
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Series applied, thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-05-06  9:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-27  7:41 [PATCH v1 1/2] stats_reporter: properly use iterable in for cycle Juraj Linkeš
2022-04-27  7:41 ` [PATCH v1 2/2] python: fix shebangs Juraj Linkeš
2022-04-28  3:15 ` [PATCH v1 1/2] stats_reporter: properly use iterable in for cycle Dong, JunX
2022-05-05  6:47 lijuan.tu

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git