test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jun Dong <junx.dong@intel.com>
To: dts@dpdk.org
Cc: lijuan.tu@intel.com, qingx.sun@intel.com, junx.dong@intel.com
Subject: [V1] framework/crb: fix bug of generating core list on freebsd platform
Date: Fri, 29 Apr 2022 17:09:58 +0800
Message-ID: <20220429090958.8126-1-junx.dong@intel.com> (raw)

On freebsd platform that supporting Hyper threading, if crb.cfg configured 
support pass core 0, the cores list(Hyper threading) need not only skip thread 0,
but also other threads that on core 0.

Signed-off-by: Jun Dong <junx.dong@intel.com>
---
 framework/crb.py | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/framework/crb.py b/framework/crb.py
index a15d15e9..0dc82005 100644
--- a/framework/crb.py
+++ b/framework/crb.py
@@ -739,10 +739,11 @@ class Crb(object):
             for core in core_elements:
                 threads = [int(x) for x in core.text.split(",")]
                 for thread in threads:
-                    if thread != 0:
-                        self.cores.append(
-                            {"socket": socket_id, "core": core_id, "thread": thread}
-                        )
+                    if self.crb["bypass core0"] and socket_id == 0 and core_id == 0:
+                        continue
+                    self.cores.append(
+                        {"socket": socket_id, "core": core_id, "thread": thread}
+                    )
                 core_id += 1
             socket_id += 1
         self.number_of_cores = len(self.cores)
-- 
2.33.1.windows.1


             reply	other threads:[~2022-04-29  9:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-29  9:09 Jun Dong [this message]
2022-05-05  1:34 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220429090958.8126-1-junx.dong@intel.com \
    --to=junx.dong@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=qingx.sun@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git