test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jiale Song <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Jiale Song <songx.jiale@intel.com>
Subject: [dts] [PATCH V1] tests/eeprom_dump: fix script
Date: Sat,  7 May 2022 23:31:06 +0800
Message-ID: <20220507153106.19508-1-songx.jiale@intel.com> (raw)

fix 2 issues:
    1. with '#' in the echo, it will interfere with the test results
    2. after the case test, the port should be tied back to the dpdk driver

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_eeprom_dump.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_eeprom_dump.py b/tests/TestSuite_eeprom_dump.py
index c1a5b4ea..b220316b 100644
--- a/tests/TestSuite_eeprom_dump.py
+++ b/tests/TestSuite_eeprom_dump.py
@@ -144,7 +144,7 @@ class TestEEPROMDump(TestCase):
                 "#",
             )
             portinfo["ethout"] = self.dut.send_expect(
-                f"cat ethtool_{testname}_hex_{port}.txt", "#"
+                f"cat ethtool_{testname}_hex_{port}.txt", "# ", trim_whitespace=False
             )
 
             self.dump_to_file(
@@ -171,6 +171,7 @@ class TestEEPROMDump(TestCase):
         Run after each test case.
         """
         self.dut.kill_all()
+        self.dut.bind_interfaces_linux(self.drivername)
 
     def tear_down_all(self):
         """
-- 
2.17.1


             reply	other threads:[~2022-05-07  7:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-07 15:31 Jiale Song [this message]
2022-05-07 11:09 ` Huang, ZhiminX
2022-05-09  7:45 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220507153106.19508-1-songx.jiale@intel.com \
    --to=songx.jiale@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git