test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1 0/2] Modify blocklist test plan and script
@ 2022-06-08  4:55 Yaqi Tang
  2022-06-08  4:55 ` [dts][PATCH V1 1/2] test_plans/blocklist: Modify testpmd port and adjust format Yaqi Tang
  2022-06-08  4:55 ` [dts][PATCH V1 2/2] tests/blocklist: modify test case name Yaqi Tang
  0 siblings, 2 replies; 4+ messages in thread
From: Yaqi Tang @ 2022-06-08  4:55 UTC (permalink / raw)
  To: dts; +Cc: xueqin.lin, Yaqi Tang

Testpmd port in test plan is wrong and script case name is nonstandard,
so modify blocklist test plan and script.

Yaqi Tang (2):
  test_plans/blocklist
  tests/blocklist

 test_plans/blocklist_test_plan.rst | 171 +++++++++++++++--------------
 tests/TestSuite_blocklist.py       |   6 +-
 2 files changed, 89 insertions(+), 88 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts][PATCH V1 1/2] test_plans/blocklist: Modify testpmd port and adjust format
  2022-06-08  4:55 [dts][PATCH V1 0/2] Modify blocklist test plan and script Yaqi Tang
@ 2022-06-08  4:55 ` Yaqi Tang
  2022-06-08  4:55 ` [dts][PATCH V1 2/2] tests/blocklist: modify test case name Yaqi Tang
  1 sibling, 0 replies; 4+ messages in thread
From: Yaqi Tang @ 2022-06-08  4:55 UTC (permalink / raw)
  To: dts; +Cc: xueqin.lin, Yaqi Tang

Testpmd port in test plan is wrong, so modify test case 3 testpmd port.
And adjust the format of test plan according to test plan template.

Signed-off-by: Yaqi Tang <yaqi.tang@intel.com>
---
 test_plans/blocklist_test_plan.rst | 171 +++++++++++++++--------------
 1 file changed, 86 insertions(+), 85 deletions(-)

diff --git a/test_plans/blocklist_test_plan.rst b/test_plans/blocklist_test_plan.rst
index f20fc207..26d1f202 100644
--- a/test_plans/blocklist_test_plan.rst
+++ b/test_plans/blocklist_test_plan.rst
@@ -18,88 +18,89 @@ to the device under test::
    modprobe vfio-pci
    usertools/dpdk-devbind.py --bind=vfio-pci device_bus_id
 
-Test Case: Testpmd with no blocklisted device
-=============================================
-
-Run testpmd in interactive mode and ensure that at least 2 ports
-are bound and available::
-
-  build/app/dpdk-testpmd -c 3 -- -i
-  ....
-  EAL: unbind kernel driver /sys/bus/pci/devices/0000:01:00.0/driver/unbind
-  EAL: Core 1 is ready (tid=357fc700)
-  EAL: bind PCI device 0000:01:00.0 to uio driver
-  EAL: Device bound
-  EAL: map PCI resource for device 0000:01:00.0
-  EAL: PCI memory mapped at 0x7fe6b68c7000
-  EAL: unbind kernel driver /sys/bus/pci/devices/0000:01:00.1/driver/unbind
-  EAL: bind PCI device 0000:01:00.1 to uio driver
-  EAL: Device bound
-  EAL: map PCI resource for device 0000:01:00.1
-  EAL: PCI memory mapped at 0x7fe6b6847000
-  EAL: unbind kernel driver /sys/bus/pci/devices/0000:02:00.0/driver/unbind
-  EAL: bind PCI device 0000:02:00.0 to uio driver
-  EAL: Device bound
-  EAL: map PCI resource for device 0000:02:00.0
-  EAL: PCI memory mapped at 0x7fe6b6580000
-  EAL: unbind kernel driver /sys/bus/pci/devices/0000:02:00.1/driver/unbind
-  EAL: bind PCI device 0000:02:00.1 to uio driver
-  EAL: Device bound
-  EAL: map PCI resource for device 0000:02:00.1
-  EAL: PCI memory mapped at 0x7fe6b6500000
-  Interactive-mode selected
-  Initializing port 0... done:  Link Up - speed 10000 Mbps - full-duplex
-  Initializing port 1... done:  Link Up - speed 10000 Mbps - full-duplex
-  Initializing port 2... done:  Link Up - speed 10000 Mbps - full-duplex
-  Initializing port 3... done:  Link Up - speed 10000 Mbps - full-duplex
-
-
-Test Case: Testpmd with one port blocklisted
-============================================
-
-Select first available port to be blocklisted and specify it with -b option. For the example above::
-
-  build/app/dpdk-testpmd -c 3 -b 0000:01:00.0 -- -i
-
-Check that corresponding device is skipped for binding, and
-only 3 ports are available now:::
-
-  EAL: unbind kernel driver /sys/bus/pci/devices/0000:01:00.1/driver/unbind
-  EAL: bind PCI device 0000:01:00.1 to uio driver
-  EAL: Device bound
-  EAL: map PCI resource for device 0000:01:00.1
-  EAL: PCI memory mapped at 0x7f0037912000
-  EAL: unbind kernel driver /sys/bus/pci/devices/0000:02:00.0/driver/unbind
-  EAL: bind PCI device 0000:02:00.0 to uio driver
-  EAL: Device bound
-  EAL: map PCI resource for device 0000:02:00.0
-  EAL: PCI memory mapped at 0x7f0037892000
-  EAL: unbind kernel driver /sys/bus/pci/devices/0000:02:00.1/driver/unbind
-  EAL: bind PCI device 0000:02:00.1 to uio driver
-  EAL: Device bound
-  EAL: map PCI resource for device 0000:02:00.1
-  EAL: PCI memory mapped at 0x7f0037812000
-  Interactive-mode selected
-  Initializing port 0... done:  Link Up - speed 10000 Mbps - full-duplex
-  Initializing port 1... done:  Link Up - speed 10000 Mbps - full-duplex
-  Initializing port 2... done:  Link Up - speed 10000 Mbps - full-duplex
-
-
-Test Case: Testpmd with all but one port blocklisted
-====================================================
-
-Blocklist all devices except the last one.
-For the example above:::
-
-  build/app/dpdk-testpmd -c 3 -b 0000:01:00.0  -b 0000:01:00.0 -b 0000:02:00.0 -- -i
-
-Check that 3 corresponding device is skipped for binding, and
-only 1 ports is available now:::
-
-  EAL: unbind kernel driver /sys/bus/pci/devices/0000:02:00.1/driver/unbind
-  EAL: bind PCI device 0000:02:00.1 to uio driver
-  EAL: Device bound
-  EAL: map PCI resource for device 0000:02:00.1
-  EAL: PCI memory mapped at 0x7f22e9aeb000
-  Interactive-mode selected
-  Initializing port 0... done:  Link Up - speed 10000 Mbps - full-duplex
+Test Case
+=========
+
+Test Case 1: Testpmd with no blocklisted device
+-----------------------------------------------
+
+1. Run testpmd in interactive mode and ensure that at least 2 ports
+   are bound and available::
+
+    build/app/dpdk-testpmd -c 3 -- -i
+    ....
+    EAL: unbind kernel driver /sys/bus/pci/devices/0000:01:00.0/driver/unbind
+    EAL: Core 1 is ready (tid=357fc700)
+    EAL: bind PCI device 0000:01:00.0 to uio driver
+    EAL: Device bound
+    EAL: map PCI resource for device 0000:01:00.0
+    EAL: PCI memory mapped at 0x7fe6b68c7000
+    EAL: unbind kernel driver /sys/bus/pci/devices/0000:01:00.1/driver/unbind
+    EAL: bind PCI device 0000:01:00.1 to uio driver
+    EAL: Device bound
+    EAL: map PCI resource for device 0000:01:00.1
+    EAL: PCI memory mapped at 0x7fe6b6847000
+    EAL: unbind kernel driver /sys/bus/pci/devices/0000:02:00.0/driver/unbind
+    EAL: bind PCI device 0000:02:00.0 to uio driver
+    EAL: Device bound
+    EAL: map PCI resource for device 0000:02:00.0
+    EAL: PCI memory mapped at 0x7fe6b6580000
+    EAL: unbind kernel driver /sys/bus/pci/devices/0000:02:00.1/driver/unbind
+    EAL: bind PCI device 0000:02:00.1 to uio driver
+    EAL: Device bound
+    EAL: map PCI resource for device 0000:02:00.1
+    EAL: PCI memory mapped at 0x7fe6b6500000
+    Interactive-mode selected
+    Initializing port 0... done:  Link Up - speed 10000 Mbps - full-duplex
+    Initializing port 1... done:  Link Up - speed 10000 Mbps - full-duplex
+    Initializing port 2... done:  Link Up - speed 10000 Mbps - full-duplex
+    Initializing port 3... done:  Link Up - speed 10000 Mbps - full-duplex
+
+Test Case 2: Testpmd with one port blocklisted
+----------------------------------------------
+
+1. Select first available port to be blocklisted and specify it with -b option. For the example above::
+
+    build/app/dpdk-testpmd -c 3 -b 0000:01:00.0 -- -i
+
+2. Check that corresponding device is skipped for binding, and
+   only 3 ports are available now:::
+
+    EAL: unbind kernel driver /sys/bus/pci/devices/0000:01:00.1/driver/unbind
+    EAL: bind PCI device 0000:01:00.1 to uio driver
+    EAL: Device bound
+    EAL: map PCI resource for device 0000:01:00.1
+    EAL: PCI memory mapped at 0x7f0037912000
+    EAL: unbind kernel driver /sys/bus/pci/devices/0000:02:00.0/driver/unbind
+    EAL: bind PCI device 0000:02:00.0 to uio driver
+    EAL: Device bound
+    EAL: map PCI resource for device 0000:02:00.0
+    EAL: PCI memory mapped at 0x7f0037892000
+    EAL: unbind kernel driver /sys/bus/pci/devices/0000:02:00.1/driver/unbind
+    EAL: bind PCI device 0000:02:00.1 to uio driver
+    EAL: Device bound
+    EAL: map PCI resource for device 0000:02:00.1
+    EAL: PCI memory mapped at 0x7f0037812000
+    Interactive-mode selected
+    Initializing port 0... done:  Link Up - speed 10000 Mbps - full-duplex
+    Initializing port 1... done:  Link Up - speed 10000 Mbps - full-duplex
+    Initializing port 2... done:  Link Up - speed 10000 Mbps - full-duplex
+
+Test Case 3: Testpmd with all but one port blocklisted
+------------------------------------------------------
+
+1. Blocklist all devices except the last one.
+   For the example above:::
+
+    build/app/dpdk-testpmd -c 3 -b 0000:01:00.0  -b 0000:01:00.1 -b 0000:02:00.0 -- -i
+
+2. Check that 3 corresponding device is skipped for binding, and
+   only 1 ports is available now:::
+
+    EAL: unbind kernel driver /sys/bus/pci/devices/0000:02:00.1/driver/unbind
+    EAL: bind PCI device 0000:02:00.1 to uio driver
+    EAL: Device bound
+    EAL: map PCI resource for device 0000:02:00.1
+    EAL: PCI memory mapped at 0x7f22e9aeb000
+    Interactive-mode selected
+    Initializing port 0... done:  Link Up - speed 10000 Mbps - full-duplex
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts][PATCH V1 2/2] tests/blocklist: modify test case name
  2022-06-08  4:55 [dts][PATCH V1 0/2] Modify blocklist test plan and script Yaqi Tang
  2022-06-08  4:55 ` [dts][PATCH V1 1/2] test_plans/blocklist: Modify testpmd port and adjust format Yaqi Tang
@ 2022-06-08  4:55 ` Yaqi Tang
  2022-06-15  9:01   ` lijuan.tu
  1 sibling, 1 reply; 4+ messages in thread
From: Yaqi Tang @ 2022-06-08  4:55 UTC (permalink / raw)
  To: dts; +Cc: xueqin.lin, Yaqi Tang

script case name is nonstandard, so modify test case name.

Signed-off-by: Yaqi Tang <yaqi.tang@intel.com>
---
 tests/TestSuite_blocklist.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_blocklist.py b/tests/TestSuite_blocklist.py
index 635502ff..9aafc6fe 100644
--- a/tests/TestSuite_blocklist.py
+++ b/tests/TestSuite_blocklist.py
@@ -63,7 +63,7 @@ class TestBlockList(TestCase):
                     "Not blocklisted port is being blocklisted",
                 )
 
-    def test_bl_noblocklisted(self):
+    def test_bl_no_blocklisted(self):
         """
         Run testpmd with no blocklisted device.
         """
@@ -73,7 +73,7 @@ class TestBlockList(TestCase):
 
         self.check_blocklisted_ports(out, self.ports)
 
-    def test_bl_oneportblocklisted(self):
+    def test_bl_one_port_blocklisted(self):
         """
         Run testpmd with one port blocklisted.
         """
@@ -83,7 +83,7 @@ class TestBlockList(TestCase):
         )
         self.check_blocklisted_ports(out, self.ports[1:])
 
-    def test_bl_allbutoneportblocklisted(self):
+    def test_bl_all_but_one_port_blocklisted(self):
         """
         Run testpmd with all but one port blocklisted.
         """
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts][PATCH V1 2/2] tests/blocklist: modify test case name
  2022-06-08  4:55 ` [dts][PATCH V1 2/2] tests/blocklist: modify test case name Yaqi Tang
@ 2022-06-15  9:01   ` lijuan.tu
  0 siblings, 0 replies; 4+ messages in thread
From: lijuan.tu @ 2022-06-15  9:01 UTC (permalink / raw)
  To: dts, Yaqi Tang; +Cc: xueqin.lin, Yaqi Tang

On Wed,  8 Jun 2022 04:55:08 +0000, Yaqi Tang <yaqi.tang@intel.com> wrote:
> script case name is nonstandard, so modify test case name.
> 
> Signed-off-by: Yaqi Tang <yaqi.tang@intel.com>


Series applied, thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-06-15  9:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-08  4:55 [dts][PATCH V1 0/2] Modify blocklist test plan and script Yaqi Tang
2022-06-08  4:55 ` [dts][PATCH V1 1/2] test_plans/blocklist: Modify testpmd port and adjust format Yaqi Tang
2022-06-08  4:55 ` [dts][PATCH V1 2/2] tests/blocklist: modify test case name Yaqi Tang
2022-06-15  9:01   ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).