test suite reviews and discussions
 help / color / mirror / Atom feed
From: Wei Ling <weix.ling@intel.com>
To: dts@dpdk.org
Cc: Wei Ling <weix.ling@intel.com>
Subject: [dts][PATCH V1 2/6] tests/dpdk_gro_lib: delete modify dpdk code by dpdk change
Date: Fri, 24 Jun 2022 01:31:30 -0400	[thread overview]
Message-ID: <20220624053130.2832024-1-weix.ling@intel.com> (raw)

According to the dpdk commit 1945c64674(app/testpmd: perform SW IP
checksum for GRO/GSO packets) and commit 8ba1723783(net/vhost:
perform SW checksum in Tx path), no need to modify DPDK code to test.

Signed-off-by: Wei Ling <weix.ling@intel.com>
---
 tests/TestSuite_dpdk_gro_lib.py | 59 ---------------------------------
 1 file changed, 59 deletions(-)

diff --git a/tests/TestSuite_dpdk_gro_lib.py b/tests/TestSuite_dpdk_gro_lib.py
index f00dc054..87da392b 100644
--- a/tests/TestSuite_dpdk_gro_lib.py
+++ b/tests/TestSuite_dpdk_gro_lib.py
@@ -75,7 +75,6 @@ class TestDPDKGROLib(TestCase):
             self.socket_mem = "1024"
         else:
             self.socket_mem = "1024,1024"
-        self.prepare_dpdk()
         self.base_dir = self.dut.base_dir.replace("~", "/root")
         self.ports_socket = self.dut.get_numa_id(self.dut_ports[0])
 
@@ -183,63 +182,6 @@ class TestDPDKGROLib(TestCase):
             )
             self.dut.send_expect("ip netns exec ns1 ip link set up dev vxlan1", "#")
 
-    def prepare_dpdk(self):
-        #
-        # Changhe the testpmd checksum fwd code for mac change
-        self.dut.send_expect(
-            "cp ./app/test-pmd/csumonly.c ./app/test-pmd/csumonly_backup.c", "#"
-        )
-        self.dut.send_expect(
-            "cp ./drivers/net/vhost/rte_eth_vhost.c ./drivers/net/vhost/rte_eth_vhost-backup.c",
-            "#",
-        )
-        self.dut.send_expect(
-            "sed -i '/ether_addr_copy(&peer_eth/i\#if 0' ./app/test-pmd/csumonly.c", "#"
-        )
-        self.dut.send_expect(
-            "sed -i '/parse_ethernet(eth_hdr, &info/i\#endif' ./app/test-pmd/csumonly.c",
-            "#",
-        )
-        # change offload of vhost
-        tx_offload = (
-            "DEV_TX_OFFLOAD_VLAN_INSERT | "
-            + "DEV_TX_OFFLOAD_UDP_CKSUM | "
-            + "DEV_TX_OFFLOAD_TCP_CKSUM | "
-            + "DEV_TX_OFFLOAD_IPV4_CKSUM | "
-            + "DEV_TX_OFFLOAD_TCP_TSO;"
-        )
-        rx_offload = (
-            "DEV_RX_OFFLOAD_VLAN_STRIP | "
-            + "DEV_RX_OFFLOAD_TCP_CKSUM | "
-            + "DEV_RX_OFFLOAD_UDP_CKSUM | "
-            + "DEV_RX_OFFLOAD_IPV4_CKSUM | "
-            + "DEV_RX_OFFLOAD_TCP_LRO;"
-        )
-        self.dut.send_expect(
-            "sed -i 's/DEV_TX_OFFLOAD_VLAN_INSERT;/%s/' drivers/net/vhost/rte_eth_vhost.c"
-            % tx_offload,
-            "#",
-        )
-        self.dut.send_expect(
-            "sed -i 's/DEV_RX_OFFLOAD_VLAN_STRIP;/%s/' drivers/net/vhost/rte_eth_vhost.c"
-            % rx_offload,
-            "#",
-        )
-        self.dut.build_install_dpdk(self.dut.target)
-
-    def unprepare_dpdk(self):
-        # Recovery the DPDK code to original
-        self.dut.send_expect(
-            "cp ./app/test-pmd/csumonly_backup.c ./app/test-pmd/csumonly.c ", "#"
-        )
-        self.dut.send_expect(
-            "cp ./drivers/net/vhost/rte_eth_vhost-backup.c ./drivers/net/vhost/rte_eth_vhost.c ",
-            "#",
-        )
-        self.dut.send_expect("rm -rf ./app/test-pmd/csumonly_backup.c", "#")
-        self.dut.send_expect("rm -rf ./drivers/net/vhost/rte_eth_vhost-backup.c", "#")
-        self.dut.build_install_dpdk(self.dut.target)
-
     def set_vm_cpu_number(self, vm_config):
         # config the vcpu numbers = 1
         # config the cpupin only have one core
@@ -485,7 +427,6 @@ class TestDPDKGROLib(TestCase):
         for i in self.dut_ports:
             port = self.dut.ports_info[i]["port"]
             port.bind_driver(self.def_driver)
-        self.unprepare_dpdk()
         self.dut.send_expect("ip netns del ns1", "# ", 30)
         self.dut.send_expect("./usertools/dpdk-devbind.py -u %s" % (self.pci), "# ", 30)
         self.dut.send_expect(
-- 
2.25.1


                 reply	other threads:[~2022-06-24  5:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220624053130.2832024-1-weix.ling@intel.com \
    --to=weix.ling@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).