* [dts][PATCH V1] tests/rss_key_update: modify testplan sync with script
@ 2022-08-11 10:15 Lingli Chen
2022-08-24 8:43 ` Li, WeiyuanX
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Lingli Chen @ 2022-08-11 10:15 UTC (permalink / raw)
To: dts; +Cc: yuan.peng, Lingli Chen
1. modify testplan according to dts commit: 2865e5b5ec53(replace legacy filter with rte flow).
2. modify case test_set_hash_key_toeplitz sync with testplan
Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
| 13 ++++++++++---
| 10 +++++++++-
2 files changed, 19 insertions(+), 4 deletions(-)
--git a/test_plans/rss_key_update_test_plan.rst b/test_plans/rss_key_update_test_plan.rst
index 8c574a0f..78cae6c2 100644
--- a/test_plans/rss_key_update_test_plan.rst
+++ b/test_plans/rss_key_update_test_plan.rst
@@ -23,7 +23,7 @@ Test Case: test_set_hash_key_toeplitz
#. Launch the ``testpmd`` application with the following arguments::
- ./<build_target>/app/dpdk-testpmd -c ffffff -n 4 -- -i --portmask=0x6 --rxq=16 --txq=16
+ ./<build_target>/app/dpdk-testpmd -c ffffff -n 4 -- -i --rxq=16 --txq=16
#. PMD fwd only receive the packets::
@@ -39,7 +39,14 @@ Test Case: test_set_hash_key_toeplitz
#. Set hash function, symmetric, port and packet type::
- testpmd> set_hash_global_config 0 toeplitz ipv4-udp enable
+ testpmd> flow create 0 ingress pattern eth / ipv4 / udp / end actions rss types ipv4-udp end queues end func toeplitz / end
+ testpmd> flow create 0 ingress pattern eth / ipv4 / tcp / end actions rss types ipv4-tcp end queues end func toeplitz / end
+ types in pattern must match rss types.
+
+#. Configure RSS hash::
+
+ testpmd> port config all rss <udp|tcp>
+ verify "error" not in out
#. Send packet and print the hash value and queue id of every packet. \
Then use the hash value % the table size to find expected queue id. \
@@ -68,7 +75,7 @@ Test Case: test_set_hash_key_toeplitz_symmetric
Same steps as the "test_set_hash_key_toeplitz" test case.
When set hash function you will need to add::
- testpmd> set_sym_hash_ena_per_port 0 enable
+ testpmd> flow create 0 ingress pattern eth / ipv4 / tcp / end actions rss types ipv4-tcp end queues end func symmetric_toeplitz queues end / end
Then send in packet as normal.
--git a/tests/TestSuite_rss_key_update.py b/tests/TestSuite_rss_key_update.py
index 0ce422ec..77f11839 100644
--- a/tests/TestSuite_rss_key_update.py
+++ b/tests/TestSuite_rss_key_update.py
@@ -228,7 +228,7 @@ class TestRssKeyUpdate(TestCase):
self.dut.kill_all()
- self.pmdout.start_testpmd("Default", f"--rxq={queue} --txq={queue}")
+ self.pmdout.start_testpmd("all", f"--rxq={queue} --txq={queue}")
def test_set_hash_key_toeplitz(self):
@@ -255,6 +255,10 @@ class TestRssKeyUpdate(TestCase):
)
self.dut.send_expect("flow flush 0", "testpmd> ")
cmd = f"flow create 0 ingress pattern eth / ipv4 / end actions rss types {iptype} end queues end func toeplitz / end"
+ if "sctp" in iptype or "udp" in iptype or "tcp" in iptype:
+ cmd = cmd.replace("/ ipv4 /", f"/ ipv4 / {rsstype} /")
+ if "ipv6" in iptype:
+ cmd = cmd.replace("ipv4", "ipv6")
self.dut.send_expect(cmd, "testpmd> ")
out = self.dut.send_expect(f"port config all rss {rsstype}", "testpmd> ")
self.verify(
@@ -267,6 +271,10 @@ class TestRssKeyUpdate(TestCase):
)
self.dut.send_expect("flow flush 0", "testpmd> ")
cmd = f"flow create 0 ingress pattern eth / ipv4 / end actions rss types {iptype} end queues end func toeplitz / end"
+ if "sctp" in iptype or "udp" in iptype or "tcp" in iptype:
+ cmd = cmd.replace("/ ipv4 /", f"/ ipv4 / {rsstype} /")
+ if "ipv6" in iptype:
+ cmd = cmd.replace("ipv4", "ipv6")
self.dut.send_expect(cmd, "testpmd> ")
new_output = self.send_packet(self.itf, iptype, False)
self.verify(
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [dts][PATCH V1] tests/rss_key_update: modify testplan sync with script
2022-08-11 10:15 [dts][PATCH V1] tests/rss_key_update: modify testplan sync with script Lingli Chen
@ 2022-08-24 8:43 ` Li, WeiyuanX
2022-08-25 3:01 ` Peng, Yuan
2022-08-25 3:55 ` lijuan.tu
2 siblings, 0 replies; 5+ messages in thread
From: Li, WeiyuanX @ 2022-08-24 8:43 UTC (permalink / raw)
To: Chen, LingliX, dts; +Cc: Peng, Yuan, Chen, LingliX
> -----Original Message-----
> From: Lingli Chen <linglix.chen@intel.com>
> Sent: Thursday, August 11, 2022 6:16 PM
> To: dts@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>; Chen, LingliX
> <linglix.chen@intel.com>
> Subject: [dts][PATCH V1] tests/rss_key_update: modify testplan sync with
> script
>
> 1. modify testplan according to dts commit: 2865e5b5ec53(replace legacy
> filter with rte flow).
> 2. modify case test_set_hash_key_toeplitz sync with testplan
>
> Signed-off-by: Lingli Chen <linglix.chen@intel.com>
> ---
Tested-by: Weiyuan Li <weiyuanx.li@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [dts][PATCH V1] tests/rss_key_update: modify testplan sync with script
2022-08-11 10:15 [dts][PATCH V1] tests/rss_key_update: modify testplan sync with script Lingli Chen
2022-08-24 8:43 ` Li, WeiyuanX
@ 2022-08-25 3:01 ` Peng, Yuan
2022-08-25 3:55 ` lijuan.tu
2 siblings, 0 replies; 5+ messages in thread
From: Peng, Yuan @ 2022-08-25 3:01 UTC (permalink / raw)
To: Chen, LingliX, dts
Acked-by Peng, Yuan <yuan.peng@intel.com>
-----Original Message-----
From: Chen, LingliX <linglix.chen@intel.com>
Sent: Thursday, August 11, 2022 6:16 PM
To: dts@dpdk.org
Cc: Peng, Yuan <yuan.peng@intel.com>; Chen, LingliX <linglix.chen@intel.com>
Subject: [dts][PATCH V1] tests/rss_key_update: modify testplan sync with script
1. modify testplan according to dts commit: 2865e5b5ec53(replace legacy filter with rte flow).
2. modify case test_set_hash_key_toeplitz sync with testplan
Signed-off-by: Lingli Chen <linglix.chen@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dts][PATCH V1] tests/rss_key_update: modify testplan sync with script
2022-08-11 10:15 [dts][PATCH V1] tests/rss_key_update: modify testplan sync with script Lingli Chen
2022-08-24 8:43 ` Li, WeiyuanX
2022-08-25 3:01 ` Peng, Yuan
@ 2022-08-25 3:55 ` lijuan.tu
2 siblings, 0 replies; 5+ messages in thread
From: lijuan.tu @ 2022-08-25 3:55 UTC (permalink / raw)
To: dts, Lingli Chen; +Cc: yuan.peng, Lingli Chen
On Thu, 11 Aug 2022 06:15:58 -0400, Lingli Chen <linglix.chen@intel.com> wrote:
> 1. modify testplan according to dts commit: 2865e5b5ec53(replace legacy filter with rte flow).
> 2. modify case test_set_hash_key_toeplitz sync with testplan
>
> Signed-off-by: Lingli Chen <linglix.chen@intel.com>
Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dts][PATCH V1] tests/rss_key_update: modify testplan sync with script
@ 2022-08-11 8:38 Hongbo Li
0 siblings, 0 replies; 5+ messages in thread
From: Hongbo Li @ 2022-08-11 8:38 UTC (permalink / raw)
To: dts; +Cc: yuan.peng, Lingli Chen
From: Lingli Chen <linglix.chen@intel.com>
1. modify testplan according to dts commit: 2865e5b5ec53(replace legacy filter with rte flow).
2. modify case test_set_hash_key_toeplitz sync with testplan
Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
| 13 ++++++++++---
| 10 +++++++++-
2 files changed, 19 insertions(+), 4 deletions(-)
--git a/test_plans/rss_key_update_test_plan.rst b/test_plans/rss_key_update_test_plan.rst
index 8c574a0f..78cae6c2 100644
--- a/test_plans/rss_key_update_test_plan.rst
+++ b/test_plans/rss_key_update_test_plan.rst
@@ -23,7 +23,7 @@ Test Case: test_set_hash_key_toeplitz
#. Launch the ``testpmd`` application with the following arguments::
- ./<build_target>/app/dpdk-testpmd -c ffffff -n 4 -- -i --portmask=0x6 --rxq=16 --txq=16
+ ./<build_target>/app/dpdk-testpmd -c ffffff -n 4 -- -i --rxq=16 --txq=16
#. PMD fwd only receive the packets::
@@ -39,7 +39,14 @@ Test Case: test_set_hash_key_toeplitz
#. Set hash function, symmetric, port and packet type::
- testpmd> set_hash_global_config 0 toeplitz ipv4-udp enable
+ testpmd> flow create 0 ingress pattern eth / ipv4 / udp / end actions rss types ipv4-udp end queues end func toeplitz / end
+ testpmd> flow create 0 ingress pattern eth / ipv4 / tcp / end actions rss types ipv4-tcp end queues end func toeplitz / end
+ types in pattern must match rss types.
+
+#. Configure RSS hash::
+
+ testpmd> port config all rss <udp|tcp>
+ verify "error" not in out
#. Send packet and print the hash value and queue id of every packet. \
Then use the hash value % the table size to find expected queue id. \
@@ -68,7 +75,7 @@ Test Case: test_set_hash_key_toeplitz_symmetric
Same steps as the "test_set_hash_key_toeplitz" test case.
When set hash function you will need to add::
- testpmd> set_sym_hash_ena_per_port 0 enable
+ testpmd> flow create 0 ingress pattern eth / ipv4 / tcp / end actions rss types ipv4-tcp end queues end func symmetric_toeplitz queues end / end
Then send in packet as normal.
--git a/tests/TestSuite_rss_key_update.py b/tests/TestSuite_rss_key_update.py
index 0ce422ec..77f11839 100644
--- a/tests/TestSuite_rss_key_update.py
+++ b/tests/TestSuite_rss_key_update.py
@@ -228,7 +228,7 @@ class TestRssKeyUpdate(TestCase):
self.dut.kill_all()
- self.pmdout.start_testpmd("Default", f"--rxq={queue} --txq={queue}")
+ self.pmdout.start_testpmd("all", f"--rxq={queue} --txq={queue}")
def test_set_hash_key_toeplitz(self):
@@ -255,6 +255,10 @@ class TestRssKeyUpdate(TestCase):
)
self.dut.send_expect("flow flush 0", "testpmd> ")
cmd = f"flow create 0 ingress pattern eth / ipv4 / end actions rss types {iptype} end queues end func toeplitz / end"
+ if "sctp" in iptype or "udp" in iptype or "tcp" in iptype:
+ cmd = cmd.replace("/ ipv4 /", f"/ ipv4 / {rsstype} /")
+ if "ipv6" in iptype:
+ cmd = cmd.replace("ipv4", "ipv6")
self.dut.send_expect(cmd, "testpmd> ")
out = self.dut.send_expect(f"port config all rss {rsstype}", "testpmd> ")
self.verify(
@@ -267,6 +271,10 @@ class TestRssKeyUpdate(TestCase):
)
self.dut.send_expect("flow flush 0", "testpmd> ")
cmd = f"flow create 0 ingress pattern eth / ipv4 / end actions rss types {iptype} end queues end func toeplitz / end"
+ if "sctp" in iptype or "udp" in iptype or "tcp" in iptype:
+ cmd = cmd.replace("/ ipv4 /", f"/ ipv4 / {rsstype} /")
+ if "ipv6" in iptype:
+ cmd = cmd.replace("ipv4", "ipv6")
self.dut.send_expect(cmd, "testpmd> ")
new_output = self.send_packet(self.itf, iptype, False)
self.verify(
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-25 3:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-11 10:15 [dts][PATCH V1] tests/rss_key_update: modify testplan sync with script Lingli Chen
2022-08-24 8:43 ` Li, WeiyuanX
2022-08-25 3:01 ` Peng, Yuan
2022-08-25 3:55 ` lijuan.tu
-- strict thread matches above, loose matches on Subject: below --
2022-08-11 8:38 Hongbo Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).