[dts][PATCH V1 1/2] tests/kernelpf_iavf: remove duplicate case vf_tso

[dts][PATCH V1 1/2] tests/kernelpf_iavf: remove duplicate case vf_tso

[Weiyuan Li]

Duplicated to vf_offload tso, remove vf_tso from kernelpf_iavf.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 43 --------------------------------
 1 file changed, 43 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index d7d17ac4..4cc603e0 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -635,49 +635,6 @@ class TestKernelpfIavf(TestCase):
         self.verify(bad_ipcsum == 1, "Bad-ipcsum check error")
         self.verify(bad_l4csum == 2, "Bad-ipcsum check error")
 
-    def test_vf_tso(self):
-        self.tester.send_expect(
-            "ethtool -K %s rx off tx off tso off gso off gro off lro off"
-            % self.tester_intf,
-            "#",
-        )
-        self.tester.send_expect(
-            "ifconfig %s mtu %d" % (self.tester_intf, ETHER_JUMBO_FRAME_MTU), "#"
-        )
-        self.vm_testpmd.start_testpmd(
-            "all", "--port-topology=chained --max-pkt-len=%d" % ETHER_JUMBO_FRAME_MTU
-        )
-        self.vm_testpmd.execute_cmd("set fwd csum")
-        self.vm_testpmd.execute_cmd("set verbose 1")
-        self.enable_hw_checksum()
-        self.vm_testpmd.execute_cmd("tso set 1460 0")
-        self.vm_testpmd.execute_cmd("port start all")
-        self.vm_testpmd.execute_cmd("start")
-        self.tester.scapy_foreground()
-        time.sleep(5)
-        self.start_tcpdump(self.tester_intf)
-        pkt = (
-            'sendp([Ether(dst="%s")/IP(chksum=0x1234)/TCP(flags=0x10,chksum=0x1234)/'
-            'Raw(RandString(5214))], iface="%s")' % (self.vf_mac, self.tester_intf)
-        )
-        self.tester.scapy_append(pkt)
-        self.tester.scapy_execute()
-        time.sleep(5)
-        out = self.get_tcpdump_package()
-        self.verify_packet_segmentation(out)
-        self.vm_testpmd.execute_cmd("stop")
-        self.vm_testpmd.execute_cmd("port stop all")
-        self.vm_testpmd.execute_cmd("tso set 0 0")
-        self.vm_testpmd.execute_cmd("port start all")
-        self.vm_testpmd.execute_cmd("start")
-
-        self.start_tcpdump(self.tester_intf)
-        self.tester.scapy_append(pkt)
-        self.tester.scapy_execute()
-        time.sleep(5)
-        out = self.get_tcpdump_package()
-        self.verify_packet_segmentation(out, seg=False)
-
     def start_tcpdump(self, rxItf):
         self.tester.send_expect("rm -rf getPackageByTcpdump.cap", "#")
         self.tester.send_expect(
-- 
2.27.0

[dts][PATCH V1 2/2] test_plans/kernelpf_iavf: remove duplicate case vf_tso

[Weiyuan Li]

Duplicated to vf_offload tso, remove vf_tso from kernelpf_iavf.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
 test_plans/kernelpf_iavf_test_plan.rst | 76 --------------------------
 1 file changed, 76 deletions(-)

diff --git a/test_plans/kernelpf_iavf_test_plan.rst b/test_plans/kernelpf_iavf_test_plan.rst
index 8c7d1ad5..7613fa68 100644
--- a/test_plans/kernelpf_iavf_test_plan.rst
+++ b/test_plans/kernelpf_iavf_test_plan.rst
@@ -320,82 +320,6 @@ Send ipv4 packets, check RSS hash value is different::
 
     p=Ether(dst="56:0A:EC:50:A4:28")/IP(src="1.2.3.4")/Raw(load='X'*30)
 
-Test case: VF TSO
-=================
-Turn off all hardware offloads on tester machine::
-
-   ethtool -K eth1 rx off tx off tso off gso off gro off lro off
-
-Change mtu for large packet::
-
-   ifconfig 'tester interface' mtu 9000
-
-Launch the ``testpmd`` with the following arguments, add "--max-pkt-len"
-for large packet::
-
-   ./<build_target>/app/dpdk-testpmd -c f -n 4 -- -i --port-topology=chained --max-pkt-len=9000
-
-Set csum forward::
-
-    testpmd> set fwd csum
-    testpmd> set verbose 1
-
-Enable HW checksum::
-
-    testpmd> port stop all
-    testpmd> csum set ip hw 0
-    testpmd> csum set udp hw 0
-    testpmd> csum set tcp hw 0
-    testpmd> csum set sctp hw 0
-
-Set TSO turned on, set TSO size as 1460::
-
-    testpmd> tso set 1460 0
-    testpmd> port start all
-    testpmd> start
-
-Send few IP/TCP packets from tester machine to DUT. Check IP/TCP checksum
-correctness in captured packet and verify correctness of HW TSO offload
-for large packets. One large TCP packet (5214 bytes + headers) segmented
-to four fragments (1460 bytes+header, 1460 bytes+header, 1460 bytes+header
-and 834 bytes + headers), checksums are also ok::
-
-   p=Ether()/IP(chksum=0x1234)/TCP(flags=0x10,chksum=0x1234)/Raw(RandString(5214))
-
-Transmitted packet::
-
-   21:48:24.214136 00:00:00:00:00:00 > 3c:fd:fe:9d:69:68, ethertype IPv6
-   (0x86dd), length 5288: (hlim 64, next-header TCP (6) payload length: 5234)
-    ::1.ftp-data > ::1.http: Flags [.], cksum 0xac95 (correct), seq 0:5214,
-   ack 1, win 8192, length 5214: HTTP
-
-Captured packet::
-
-   21:48:24.214207 3c:fd:fe:9d:69:68 > 02:00:00:00:00:00, ethertype IPv6
-   (0x86dd), length 1534: (hlim 64, next-header TCP (6) payload length: 1480)
-   ::1.ftp-data > ::1.http: Flags [.], cksum 0xa641 (correct), seq 0:1460,
-   ack 1, win 8192, length 1460: HTTP
-   21:48:24.214212 3c:fd:fe:9d:69:68 > 02:00:00:00:00:00, ethertype IPv6
-   (0x86dd), length 1534: (hlim 64, next-header TCP (6) payload length: 1480)
-   ::1.ftp-data > ::1.http: Flags [.], cksum 0xae89 (correct), seq 1460:2920,
-   ack 1, win 8192, length 1460: HTTP
-   21:48:24.214213 3c:fd:fe:9d:69:68 > 02:00:00:00:00:00, ethertype IPv6
-   (0x86dd), length 1534: (hlim 64, next-header TCP (6) payload length: 1480)
-   ::1.ftp-data > ::1.http: Flags [.], cksum 0xfdb6 (correct), seq 2920:4380,
-   ack 1, win 8192, length 1460: HTTP
-   21:48:24.214215 3c:fd:fe:9d:69:68 > 02:00:00:00:00:00, ethertype IPv6
-   (0x86dd), length 908: (hlim 64, next-header TCP (6) payload length: 854)
-   ::1.ftp-data > ::1.http: Flags [.], cksum 0xe629 (correct), seq 4380:5214,
-   ack 1, win 8192, length 834: HTTP
-
-Set TSO turned off::
-
-    testpmd> tso set 0 0
-
-Send few IP/TCP packets from tester machine to DUT. Check IP/TCP checksum
-correctness in captured packet and verify correctness of HW TSO offload
-for large packets, but don't do packet segmentation.
-
 Test case: VF port stop/start
 =============================
 
-- 
2.27.0

[dts][PATCH V1 2/2] test_plans/kernelpf_iavf: remove duplicate case vf_tso

[lijuan.tu]

On Fri, 12 Aug 2022 11:11:55 +0800, Weiyuan Li <weiyuanx.li@intel.com> wrote:
> Duplicated to vf_offload tso, remove vf_tso from kernelpf_iavf.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Series applied, thanks