From: Ke Xu <ke1.xu@intel.com>
To: dts@dpdk.org
Cc: qi.fu@intel.com, ke1.xu@intel.com
Subject: [dts][PATCH V1 0/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error and improve the performance
Date: Tue, 23 Aug 2022 05:59:37 +0000 [thread overview]
Message-ID: <20220823055939.4186198-1-ke1.xu@intel.com> (raw)
Function get_chksum_value_and_verify in test suite TSO case test_tso_tunneling
cannot verify checksum error. Duplicated call to packet.read_pcapfile will
change the packet sequence stored in packet.pktgen.pkts, leading to a wrongly
organized packet sequence writen to file, and fails the following checksum
verifying.
The wrongly used methods also lead to a low effeciency. Duplicated call to
packet.read_pcapfile will lengthen the packet sequence stored in
packet.pktgen.pkts. Duplicated call to packet.save_pcapfile is also time
consuming.
There is also a misuse of show method that *.show() will print a packet info,
but will not return a string. The *.show will return a method object, and the
following str(out) will turn the method object into a string, so here when use
out = x.show, checksum looking up in str(out) it is equivalent to that in
repr(x).
In the first commit, the checksum verifying problem is fixed.
In the second commit, this function is improved that the case running time is
decresed by 2 minutes.
Ke Xu (2):
tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify
error
tests/tso: modify get_chksum_value_and_verify to improve the
performance
tests/TestSuite_tso.py | 26 +++++++++++++++-----------
1 file changed, 15 insertions(+), 11 deletions(-)
--
2.25.1
next reply other threads:[~2022-08-23 6:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 5:59 Ke Xu [this message]
2022-08-23 5:59 ` [dts][PATCH V1 1/2] tests/tso: modify get_chksum_value_and_verify to fix a checksum-verify error Ke Xu
2022-08-23 5:59 ` [dts][PATCH V1 2/2] tests/tso: modify get_chksum_value_and_verify to improve the performance Ke Xu
2022-09-02 1:57 ` lijuan.tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220823055939.4186198-1-ke1.xu@intel.com \
--to=ke1.xu@intel.com \
--cc=dts@dpdk.org \
--cc=qi.fu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).