test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1 1/2] tests/dual_vlan: optimize script and add check tpid
@ 2022-09-05  9:42 Weiyuan Li
  2022-09-05  9:42 ` [dts][PATCH V1 2/2] test_plans/dual_vlan: optimize dual_vlan test plan Weiyuan Li
  0 siblings, 1 reply; 2+ messages in thread
From: Weiyuan Li @ 2022-09-05  9:42 UTC (permalink / raw)
  To: dts, qi.fu; +Cc: Weiyuan Li

Optimize script and add check tpid.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
 tests/TestSuite_dual_vlan.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
index 99f47a82..994a1d51 100644
--- a/tests/TestSuite_dual_vlan.py
+++ b/tests/TestSuite_dual_vlan.py
@@ -524,6 +524,7 @@ class TestDualVlan(TestCase):
         self.vlan_send_packet(outvlan, invlan)
 
         out = self.get_tcpdump_package()
+        self.verify("0x8100" in out, "tpid is error: " + out)
         self.verify("vlan %s" % outvlan in out, "vlan tpid disable error: " + out)
         self.verify("vlan %s" % invlan in out, "vlan tpid disable error: " + out)
 
@@ -531,6 +532,7 @@ class TestDualVlan(TestCase):
         self.vlan_send_packet(outvlan, invlan)
 
         out = self.get_tcpdump_package()
+        self.verify("0x8100" in out, "tpid is error: " + out)
         self.verify(
             out is not None and "vlan" not in out, "vlane tpid enable error: " + out
         )
-- 
2.27.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dts][PATCH V1 2/2] test_plans/dual_vlan: optimize dual_vlan test plan
  2022-09-05  9:42 [dts][PATCH V1 1/2] tests/dual_vlan: optimize script and add check tpid Weiyuan Li
@ 2022-09-05  9:42 ` Weiyuan Li
  0 siblings, 0 replies; 2+ messages in thread
From: Weiyuan Li @ 2022-09-05  9:42 UTC (permalink / raw)
  To: dts, qi.fu; +Cc: Weiyuan Li

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=a, Size: 2024 bytes --]

Add diable/enable "extend off" "strip off" in test plan.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
 test_plans/dual_vlan_test_plan.rst | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/test_plans/dual_vlan_test_plan.rst b/test_plans/dual_vlan_test_plan.rst
index 762147f0..ebd68d0a 100644
--- a/test_plans/dual_vlan_test_plan.rst
+++ b/test_plans/dual_vlan_test_plan.rst
@@ -44,6 +44,10 @@ Enable vlan filtering on port 0::
 
     testpmd> vlan set filter on 0
 
+Disable extend on port 0::
+    
+    testpmd> vlan set extend off 0
+
 Check whether the mode is set successful::
 
     testpmd> show port info 0
@@ -103,6 +107,11 @@ Configure the traffic generator to send VLAN packets with the Tag Identifier
 Test Case: Add/Remove VLAN Tag Identifier pass VLAN filtering
 =============================================================
 
+Disable VLAN packet extend and strip port ``0``::
+
+    testpmd> vlan set extend off 0
+    testpmd> vlan set strip off 0
+
 Enable VLAN filtering on port ``0``::
 
     testpmd> vlan set filter on 0
@@ -240,12 +249,12 @@ and send 1 packet on port ``A``. Verify that the packet can been received on por
 ``B`` without VLAN Tag Identifier.
 
 
-Test Case: Configure receive port outer VLAN TPID
+Test Case: Configure receive port inner VLAN TPID
 =================================================
 
-Enable vlan header QinQ on port ``0`` firstly to support set TPID::
+Enable VLAN packet extend on port ``0``::
 
-    testpmd> vlan set qinq on 0
+    testpmd> vlan set extend on 0
 
 Check whether the mode is set successfully::
 
@@ -260,9 +269,7 @@ Check whether the mode is set successfully::
     Allmulticast mode: disabled
     Maximum number of MAC addresses: 127
     VLAN offload:
-      strip off
-      filter off
-      qinq(extend) on
+      strip off, filter off, extend on, qinq strip off
 
 Set Tag Protocol ID ``0x1234`` on port ``0``.
 Nic only support inner model, except Intel® Ethernet 700 Series::
-- 
2.27.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-05  9:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-05  9:42 [dts][PATCH V1 1/2] tests/dual_vlan: optimize script and add check tpid Weiyuan Li
2022-09-05  9:42 ` [dts][PATCH V1 2/2] test_plans/dual_vlan: optimize dual_vlan test plan Weiyuan Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).