test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V3 1/2] tests/dynamic_queue: modify script according to dpdk code change
@ 2022-10-11  8:25 Lingli Chen
  2022-10-11  8:25 ` [dts][PATCH V3 2/2] tests/queue_start_stop: " Lingli Chen
  0 siblings, 1 reply; 3+ messages in thread
From: Lingli Chen @ 2022-10-11  8:25 UTC (permalink / raw)
  To: dts; +Cc: zhiminx.huang, Lingli Chen

According to dpdk commit 3c4426db54fc(app/testpmd: do not poll stopped queues).
modify dynamic_queue: Tx stopped queue not display

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
 test_plans/dynamic_queue_test_plan.rst |  4 ++--
 tests/TestSuite_dynamic_queue.py       | 15 ++++++++-------
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/test_plans/dynamic_queue_test_plan.rst b/test_plans/dynamic_queue_test_plan.rst
index 96cfcb8a..d22068a0 100644
--- a/test_plans/dynamic_queue_test_plan.rst
+++ b/test_plans/dynamic_queue_test_plan.rst
@@ -94,7 +94,7 @@ Stop one Tx queue on port 0::
 
 Set txonly forward, start testpmd
 
-Start testpmd, then stop, check this stopped queue only transmits 255 packets
+Start testpmd, then stop, check this stopped queue not display
   
 Setup this stopped queue on the port::
 
@@ -162,7 +162,7 @@ Stop one Tx queue on port 0::
 
 Set txonly forward, start testpmd
 
-Start testpmd, then stop, check this stopped queue only transmits 255 packets
+Start testpmd, then stop, check this stopped queue not display
 
 Reconfigure ring size as 512 for the stopped queues on port 0::
 
diff --git a/tests/TestSuite_dynamic_queue.py b/tests/TestSuite_dynamic_queue.py
index ebbe869c..5a826bd1 100644
--- a/tests/TestSuite_dynamic_queue.py
+++ b/tests/TestSuite_dynamic_queue.py
@@ -163,13 +163,14 @@ class TestDynamicQueue(TestCase):
             out = self.dut_testpmd.execute_cmd("stop")
             tx_num = qringsize - 1
 
-            if self.nic in ["cavium_a063", "cavium_a064"]:
-                self.verify("TX-packets: 0" in out, "Fail to stop txq at runtime")
-            else:
-                # Check Tx stopped queue only transmits qringsize-1 packets
-                self.verify(
-                    "TX-packets: %d" % tx_num in out, "Fail to stop txq at runtime"
-                )
+            # check rxq start successful
+            self.verify("TX-packets:" in out, "txq start failed")
+            # check Tx stopped queue not display
+            self.verify(
+                "TX Port= 0/Queue={:>2}".format(queue) not in out,
+                "Fail to stop txq at runtime",
+            )
+
             if chgflag == 1:
                 chg_qringsize = qringsize % 1024 + 256
                 if qringsize == 512:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread
* [dts][PATCH V3 1/2] tests/dynamic_queue: modify script according to dpdk code change
@ 2022-10-11  9:31 Lingli Chen
  0 siblings, 0 replies; 3+ messages in thread
From: Lingli Chen @ 2022-10-11  9:31 UTC (permalink / raw)
  To: dts; +Cc: zhiminx.huang, Lingli Chen

According to dpdk commit 3c4426db54fc(app/testpmd: do not poll stopped queues).
modify dynamic_queue: Tx stopped queue not display

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
 test_plans/dynamic_queue_test_plan.rst |  4 ++--
 tests/TestSuite_dynamic_queue.py       | 15 ++++++++-------
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/test_plans/dynamic_queue_test_plan.rst b/test_plans/dynamic_queue_test_plan.rst
index 96cfcb8a..d22068a0 100644
--- a/test_plans/dynamic_queue_test_plan.rst
+++ b/test_plans/dynamic_queue_test_plan.rst
@@ -94,7 +94,7 @@ Stop one Tx queue on port 0::
 
 Set txonly forward, start testpmd
 
-Start testpmd, then stop, check this stopped queue only transmits 255 packets
+Start testpmd, then stop, check this stopped queue not display
   
 Setup this stopped queue on the port::
 
@@ -162,7 +162,7 @@ Stop one Tx queue on port 0::
 
 Set txonly forward, start testpmd
 
-Start testpmd, then stop, check this stopped queue only transmits 255 packets
+Start testpmd, then stop, check this stopped queue not display
 
 Reconfigure ring size as 512 for the stopped queues on port 0::
 
diff --git a/tests/TestSuite_dynamic_queue.py b/tests/TestSuite_dynamic_queue.py
index ebbe869c..5a826bd1 100644
--- a/tests/TestSuite_dynamic_queue.py
+++ b/tests/TestSuite_dynamic_queue.py
@@ -163,13 +163,14 @@ class TestDynamicQueue(TestCase):
             out = self.dut_testpmd.execute_cmd("stop")
             tx_num = qringsize - 1
 
-            if self.nic in ["cavium_a063", "cavium_a064"]:
-                self.verify("TX-packets: 0" in out, "Fail to stop txq at runtime")
-            else:
-                # Check Tx stopped queue only transmits qringsize-1 packets
-                self.verify(
-                    "TX-packets: %d" % tx_num in out, "Fail to stop txq at runtime"
-                )
+            # check rxq start successful
+            self.verify("TX-packets:" in out, "txq start failed")
+            # check Tx stopped queue not display
+            self.verify(
+                "TX Port= 0/Queue={:>2}".format(queue) not in out,
+                "Fail to stop txq at runtime",
+            )
+
             if chgflag == 1:
                 chg_qringsize = qringsize % 1024 + 256
                 if qringsize == 512:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-11 10:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-11  8:25 [dts][PATCH V3 1/2] tests/dynamic_queue: modify script according to dpdk code change Lingli Chen
2022-10-11  8:25 ` [dts][PATCH V3 2/2] tests/queue_start_stop: " Lingli Chen
2022-10-11  9:31 [dts][PATCH V3 1/2] tests/dynamic_queue: " Lingli Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).