From: Lingli Chen <linglix.chen@intel.com>
To: dts@dpdk.org
Cc: zhiminx.huang@intel.com, Lingli Chen <linglix.chen@intel.com>
Subject: [dts][PATCH V1] tests/pmdrss_hash: remove port stop all command
Date: Wed, 9 Nov 2022 01:09:23 -0500 [thread overview]
Message-ID: <20221109060923.21957-1-linglix.chen@intel.com> (raw)
1. Executing the `port stop all` command destroys all flow rules associated with the port. Therefore, remove this command.
2. modify toeplitz_symmetric case sync with testplan: the hash value and queue should be the same for symmetric packets.
Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
| 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
--git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py
index da9d143a..afa30bf3 100644
--- a/tests/TestSuite_pmdrss_hash.py
+++ b/tests/TestSuite_pmdrss_hash.py
@@ -456,7 +456,7 @@ class TestPmdrssHash(TestCase):
status = "true"
result.insert(i, 0)
if i % 2 == 1:
- if pre_RSS_hash != tmp_reta_line["RSS hash"]:
+ if pre_RSS_hash == tmp_reta_line["RSS hash"]:
status = "true"
result.insert(len(reta_lines) + (i - 1) // 2, 0)
else:
@@ -549,7 +549,6 @@ class TestPmdrssHash(TestCase):
self.dut.send_expect("set promisc all off", "testpmd> ")
self.dut.send_expect("set nbcore %d" % (queue + 1), "testpmd> ")
- self.dut.send_expect("port stop all", "testpmd> ")
self.dut.send_expect("flow flush 0", "testpmd> ")
rule_cmd = f"flow create 0 ingress pattern eth / ipv4 / end actions rss types {iptype} end queues end {rule_action}"
if "sctp" in iptype or "udp" in iptype or "tcp" in iptype:
@@ -558,7 +557,6 @@ class TestPmdrssHash(TestCase):
rule_cmd = rule_cmd.replace("ipv4", "ipv6")
outx = self.dut.send_expect(rule_cmd, "testpmd> ")
self.verify("created" in outx, "Create flow failed")
- self.dut.send_expect("port start all", "testpmd> ")
out = self.dut.send_expect("port config all rss %s" % rsstype, "testpmd> ")
self.verify(
"error" not in out, "Configuration of RSS hash failed: Invalid argument"
@@ -600,7 +598,6 @@ class TestPmdrssHash(TestCase):
self.dut.send_expect("set promisc all off", "testpmd> ")
self.dut.send_expect("set nbcore %d" % (queue + 1), "testpmd> ")
- self.dut.send_expect("port stop all", "testpmd> ")
self.dut.send_expect("flow flush 0", "testpmd> ")
rule_cmd = f"flow create 0 ingress pattern eth / ipv4 / end actions rss types {iptype} end queues end {rule_action}"
if "sctp" in iptype or "udp" in iptype or "tcp" in iptype:
@@ -609,7 +606,6 @@ class TestPmdrssHash(TestCase):
rule_cmd = rule_cmd.replace("ipv4", "ipv6")
outx = self.dut.send_expect(rule_cmd, "testpmd> ")
self.verify("created" in outx, "Create flow failed")
- self.dut.send_expect("port start all", "testpmd> ")
out = self.dut.send_expect("port config all rss %s" % rsstype, "testpmd> ")
self.verify(
"error" not in out, "Configuration of RSS hash failed: Invalid argument"
@@ -657,7 +653,6 @@ class TestPmdrssHash(TestCase):
self.dut.send_expect("set promisc all off", "testpmd> ")
self.dut.send_expect("set nbcore %d" % (queue + 1), "testpmd> ")
- self.dut.send_expect("port stop all", "testpmd> ")
# some nic not support change hash algorithm
self.dut.send_expect("flow flush 0", "testpmd> ")
rule_cmd = f"flow create 0 ingress pattern eth / ipv4 / end actions rss types {iptype} end queues end {rule_action}"
@@ -667,7 +662,6 @@ class TestPmdrssHash(TestCase):
rule_cmd = rule_cmd.replace("ipv4", "ipv6")
outx = self.dut.send_expect(rule_cmd, "testpmd> ")
self.verify("created" in outx, "Create flow failed")
- self.dut.send_expect("port start all", "testpmd> ")
out = self.dut.send_expect("port config all rss %s" % rsstype, "testpmd> ")
self.verify(
"error" not in out, "Configuration of RSS hash failed: Invalid argument"
--
2.17.1
next reply other threads:[~2022-11-09 7:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 6:09 Lingli Chen [this message]
2022-11-18 8:04 ` lijuan.tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109060923.21957-1-linglix.chen@intel.com \
--to=linglix.chen@intel.com \
--cc=dts@dpdk.org \
--cc=zhiminx.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).