[dts] [PATCH V1 1/3] tests/ice_iavf_fdir: optimize scripts

[dts] [PATCH V1 1/3] tests/ice_iavf_fdir: optimize scripts

[Hongbo Li]

when the dpdk testpmd exits abnormally, the port will not be initialized, and sometimes
the test of other cases will be affected. therefore, after the test, should use quit to
close the dpdk testpmd normally to avoid the impact between cases.

Signed-off-by: Hongbo Li <hongbox.li@intel.com>
---
 tests/TestSuite_ice_iavf_fdir.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_ice_iavf_fdir.py b/tests/TestSuite_ice_iavf_fdir.py
index d6ca832a..b7954784 100644
--- a/tests/TestSuite_ice_iavf_fdir.py
+++ b/tests/TestSuite_ice_iavf_fdir.py
@@ -11932,12 +11932,12 @@ class TestICEIAVFFdir(TestCase):
             "test_mac_ipv6_multicast_protocol",
         ]:
             self.pmd_output.execute_cmd("mcast_addr remove 0 11:22:33:44:55:66")
-        self.destroy_env()
-        self.dut.kill_all()
         if getattr(self, "session_secondary", None):
             self.dut.close_session(self.session_secondary)
         if getattr(self, "session_third", None):
             self.dut.close_session(self.session_third)
+        self.destroy_env()
+        self.dut.kill_all()
 
         if self.running_case in [
             "test_pfcp_vlan_strip_off_sw_checksum",
-- 
2.25.1

[dts] [PATCH V1 2/3] tests/ice_fdir: optimize scripts

[Hongbo Li]

when the dpdk testpmd exits abnormally, the port will not be initialized, and sometimes
the test of other cases will be affected. therefore, after the test, should use quit to
close the dpdk testpmd normally to avoid the impact between cases.

Signed-off-by: Hongbo Li <hongbox.li@intel.com>
---
 tests/TestSuite_ice_fdir.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_ice_fdir.py b/tests/TestSuite_ice_fdir.py
index fac65fda..b0fd8207 100644
--- a/tests/TestSuite_ice_fdir.py
+++ b/tests/TestSuite_ice_fdir.py
@@ -4517,4 +4517,5 @@ class TestICEFdir(TestCase):
             self.launch_testpmd_with_mark()
 
     def tear_down_all(self):
+        self.pmd_output.quit()
         self.dut.kill_all()
-- 
2.25.1

[dts] [PATCH V1 3/3] tests/ice_limit_value_test: optimize scripts

[Hongbo Li]

1.when the dpdk testpmd exits abnormally, the port will not be initialized, and sometimes
the test of other cases will be affected. therefore, after the test, should use quit to
close the dpdk testpmd normally to avoid the impact between cases.
2.the object named "self.session_third" is undefined, delete useless code.

Signed-off-by: Hongbo Li <hongbox.li@intel.com>
---
 tests/TestSuite_ice_limit_value_test.py | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_ice_limit_value_test.py b/tests/TestSuite_ice_limit_value_test.py
index b75cea84..b5bc6dc2 100644
--- a/tests/TestSuite_ice_limit_value_test.py
+++ b/tests/TestSuite_ice_limit_value_test.py
@@ -1256,13 +1256,10 @@ class TestICELimitValue(TestCase):
 
     def tear_down(self):
         # destroy all flow rule on port 0
-        self.dut.kill_all()
-        self.destroy_env()
         if getattr(self, "session_secondary", None):
             self.dut.close_session(self.session_secondary)
-        if getattr(self, "session_third", None):
-            self.dut.close_session(self.session_third)
+        self.destroy_env()
+        self.dut.kill_all()
 
     def tear_down_all(self):
         self.dut.kill_all()
-        self.destroy_env()
-- 
2.25.1

RE: [dts] [PATCH V1 3/3] tests/ice_limit_value_test: optimize scripts

[Jiale, SongX]

> -----Original Message-----
> From: Hongbo Li <hongbox.li@intel.com>
> Sent: Tuesday, November 15, 2022 3:42 PM
> To: dts@dpdk.org
> Cc: Li, HongboX <hongbox.li@intel.com>
> Subject: [dts] [PATCH V1 3/3] tests/ice_limit_value_test: optimize scripts
> 
> 1.when the dpdk testpmd exits abnormally, the port will not be initialized,
> and sometimes the test of other cases will be affected. therefore, after the
> test, should use quit to close the dpdk testpmd normally to avoid the impact
> between cases.
> 2.the object named "self.session_third" is undefined, delete useless code.
> 
> Signed-off-by: Hongbo Li <hongbox.li@intel.com>
> ---
Tested-by: Song Jiale <songx.jiale@intel.com>