test suite reviews and discussions
 help / color / mirror / Atom feed
From: Weiyuan Li <weiyuanx.li@intel.com>
To: dts@dpdk.org
Cc: Weiyuan Li <weiyuanx.li@intel.com>, Yu Jiang <yux.jiang@intel.com>
Subject: [dts][PATCH V5 1/2] tests/meson_tests: modify meson_tests suite to support test config parameter
Date: Thu, 22 Dec 2022 17:46:36 +0800	[thread overview]
Message-ID: <20221222094637.23135-1-weiyuanx.li@intel.com> (raw)

Modify meson_tests suite to support test config (TIMEOUT_MULTIPLIER, TEST_ARGS etc.) in conf/meson_tests.cfg.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
Tested-by: Yu Jiang <yux.jiang@intel.com>

v2:
-modify profile parameter descriptions and configuration items.
v3:
-modify configuration file comments.
-the modification script uses the framework API to read the
configuration file.
-modify the log to the temporary directory.
v4:
-test script meson_param method optimization.
v5:
-Optimize the copy method and use the framework API.

 tests/TestSuite_meson_tests.py | 62 ++++++++++++++--------------------
 1 file changed, 26 insertions(+), 36 deletions(-)

diff --git a/tests/TestSuite_meson_tests.py b/tests/TestSuite_meson_tests.py
index ee95fffa..42fd37af 100644
--- a/tests/TestSuite_meson_tests.py
+++ b/tests/TestSuite_meson_tests.py
@@ -66,7 +66,6 @@ class TestMesonTests(TestCase):
         skip = []
         timeout = []
         failed = []
-
         self.verify(
             bool(self.meson_auto_test),
             f"Test failed the meson no test results were obtained.",
@@ -99,24 +98,19 @@ class TestMesonTests(TestCase):
                 sub_timeout = "[" + ",".join(timeout) + "] sub case time out. "
             self.verify(False, f"Test failed. {sub_fail}{sub_timeout}")
 
-    def check_scp_file_valid_between_dut(self):
-        out = self.tester.send_command(
-            f"scp root@{self.dut_ip}:/root/{self.dut_pathlog} {self.base_output}",
-            timeout=15,
+    def meson_param(self, case_name):
+        return (
+            self.get_suite_cfg().get(case_name, "")
+            + " "
+            + self.get_suite_cfg().get("param", "")
         )
-        if "Are you sure you want to continue connecting" in out:
-            out = self.tester.send_command("yes", timeout=20)
-        for item in range(30):
-            if "password" in out:
-                self.tester.send_command(self.dut.get_password(), timeout=20)
-                break
 
-        out = self.tester.send_command(
-            f"ls -l {self.base_output}/{self.dut_pathlog}", "# "
-        )
-        self.verify(
-            "No such file or directory" not in out, "No test result log was obtained!"
-        )
+    def copy_file_from_dut(self):
+        if os.path.exists(os.path.join(self.base_output, self.dut_pathlog)):
+            os.remove(os.path.join(self.base_output, self.dut_pathlog))
+
+        src_pathlog = f"~/tmp/{self.dut_pathlog}"
+        self.dut.session.copy_file_from(src_pathlog, self.base_output)
 
     def insmod_kni(self):
         out = self.dut.send_expect("lsmod | grep rte_kni", "# ")
@@ -141,68 +135,64 @@ class TestMesonTests(TestCase):
         self.check_sub_case()
 
     def test_fasts(self):
+        param = self.meson_param("fast-tests")
         # init file name
         self.dut_pathlog = "fast-test.log"
         self.delete_exists_files()
         self.insmod_kni()
         # config test case list in conf/meson_tests.cfg
-        caselist = self.get_suite_cfg()["fast-tests"]
-        cmds = f'meson test -C x86_64-native-linuxapp-gcc/ --suite DPDK:fast-tests {caselist} -t {self.ratio} --test-args="-c 0xff" |tee /root/{self.dut_pathlog}'
+        cmds = f"meson test -C x86_64-native-linuxapp-gcc/ --suite DPDK:fast-tests {param} |tee ~/tmp/{self.dut_pathlog}"
         out = self.dut.send_expect(cmds, "# ", self.execute_wait_time)
         self.logger.info(out)
-        self.check_scp_file_valid_between_dut()
+        self.copy_file_from_dut()
         self.check_meson_test_result()
 
     def test_driver(self):
+        param = self.meson_param("driver-tests")
         # init file name
         self.dut_pathlog = "driver-test.log"
         self.delete_exists_files()
-        # config test case list in conf/meson_tests.cfg
-        caselist = self.get_suite_cfg()["driver-tests"]
-        cmds = f'meson test -C x86_64-native-linuxapp-gcc/ --suite DPDK:driver-tests {caselist} -t {self.ratio} --test-args="-c 0xff" |tee /root/{self.dut_pathlog}'
+        cmds = f"meson test -C x86_64-native-linuxapp-gcc/ --suite DPDK:driver-tests {param} |tee ~/tmp/{self.dut_pathlog}"
         out = self.dut.send_expect(cmds, "# ", self.execute_wait_time)
         self.logger.info(out)
-        self.check_scp_file_valid_between_dut()
+        self.copy_file_from_dut()
         self.check_meson_test_result()
 
     def test_debug(self):
+        param = self.meson_param("debug-tests")
         self.dut_pathlog = "test-debug.log"
         # delete exists files
         self.delete_exists_files()
-        # config test case list in conf/meson_tests.cfg
-        caselist = self.get_suite_cfg()["debug-tests"]
-        cmds = f'meson test -C x86_64-native-linuxapp-gcc/ --suite DPDK:debug-tests {caselist} -t {self.ratio} --test-args="-c 0xff" |tee /root/{self.dut_pathlog}'
+        cmds = f"meson test -C x86_64-native-linuxapp-gcc/ --suite DPDK:debug-tests {param} |tee ~/tmp/{self.dut_pathlog}"
         out = self.dut.send_expect(cmds, "# ", self.execute_wait_time)
         self.logger.info(out)
-        self.check_scp_file_valid_between_dut()
+        self.copy_file_from_dut()
         self.check_meson_test_result()
 
     def test_extra(self):
+        param = self.meson_param("extra-tests")
         self.dut_pathlog = "extra-test.log"
         # delete exists files
         self.delete_exists_files()
-        # config test case list in conf/meson_tests.cfg
-        caselist = self.get_suite_cfg()["extra-tests"]
-        cmds = f'meson test -C x86_64-native-linuxapp-gcc/ --suite DPDK:extra-tests {caselist} -t {self.ratio} --test-args="-c 0xff" |tee /root/{self.dut_pathlog}'
+        cmds = f"meson test -C x86_64-native-linuxapp-gcc/ --suite DPDK:extra-tests {param} |tee ~/tmp/{self.dut_pathlog}"
         out = self.dut.send_expect(cmds, "# ", self.execute_wait_time)
         self.logger.info(out)
-        self.check_scp_file_valid_between_dut()
+        self.copy_file_from_dut()
         self.check_meson_test_result()
         self.logger.warning(
             "Extra-tests are know issues which are recorded in DPDK commit and meson.build (detail see test plan)"
         )
 
     def test_perf(self):
+        param = self.meson_param("perf-tests")
         # init file name
         self.dut_pathlog = "perf-test.log"
         # delete exists files
         self.delete_exists_files()
-        # config test case list in conf/meson_tests.cfg
-        caselist = self.get_suite_cfg()["perf-tests"]
-        cmds = f'meson test -C x86_64-native-linuxapp-gcc/ --suite DPDK:perf-tests {caselist} -t {self.ratio} --test-args="-c 0xff" |tee /root/{self.dut_pathlog}'
+        cmds = f"meson test -C x86_64-native-linuxapp-gcc/ --suite DPDK:perf-tests {param} |tee ~/tmp/{self.dut_pathlog}"
         out = self.dut.send_expect(cmds, "# ", self.execute_wait_time)
         self.logger.info(out)
-        self.check_scp_file_valid_between_dut()
+        self.copy_file_from_dut()
         self.check_meson_test_result()
 
     def tear_down(self):
-- 
2.27.0


             reply	other threads:[~2022-12-22  9:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22  9:46 Weiyuan Li [this message]
2022-12-22  9:46 ` [dts][PATCH V5 2/2] conf/meson_tests: " Weiyuan Li
2022-12-26  5:18   ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221222094637.23135-1-weiyuanx.li@intel.com \
    --to=weiyuanx.li@intel.com \
    --cc=dts@dpdk.org \
    --cc=yux.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).