test suite reviews and discussions
 help / color / mirror / Atom feed
From: Weiyuan Li <weiyuanx.li@intel.com>
To: dts@dpdk.org
Cc: Weiyuan Li <weiyuanx.li@intel.com>
Subject: [dts][PATCH V2] test_plans/dual_vlan: optimize the test steps in the test plan
Date: Thu, 29 Dec 2022 14:02:32 +0800	[thread overview]
Message-ID: <20221229060232.25358-1-weiyuanx.li@intel.com> (raw)

modify the test plan need to set port stop first when set the tx_vlan.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---

v2:
-fix typos.

 test_plans/dual_vlan_test_plan.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/test_plans/dual_vlan_test_plan.rst b/test_plans/dual_vlan_test_plan.rst
index fd953cd9..11dfa332 100644
--- a/test_plans/dual_vlan_test_plan.rst
+++ b/test_plans/dual_vlan_test_plan.rst
@@ -242,7 +242,9 @@ Enable vlan packet forwarding on port ``0`` first::
 
 Insert VLAN Tag Identifier ``1`` on port ``1``::
 
+    testpmd> port stop all
     testpmd> tx_vlan set 1 1
+    testpmd> port start all
 
 Configure the traffic generator to send VLAN packet without VLAN Tag Identifier
 and send 1 packet on port ``A``. Verify that the packet can been received on port
@@ -250,7 +252,9 @@ and send 1 packet on port ``A``. Verify that the packet can been received on por
 
 Delete the VLAN Tag Identifier ``1`` on port ``1``::
 
+    testpmd> port stop all
     testpmd> tx_vlan reset 1
+    testpmd> port start all
 
 Configure the traffic generator to send VLAN packet without VLAN Tag Identifier
 and send 1 packet on port ``A``. Verify that the packet can been received on port
-- 
2.25.1


             reply	other threads:[~2022-12-29  6:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29  6:02 Weiyuan Li [this message]
2023-01-04  1:13 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221229060232.25358-1-weiyuanx.li@intel.com \
    --to=weiyuanx.li@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).