test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V2] test*: Add ieee1588_enable on ICE
@ 2023-01-04  2:42 Lingli Chen
  2023-01-05 14:26 ` lijuan.tu
  0 siblings, 1 reply; 2+ messages in thread
From: Lingli Chen @ 2023-01-04  2:42 UTC (permalink / raw)
  To: dts; +Cc: Lingli Chen

According to dpdk commit f5ada3bcf12d (net/ice: fix mbuf offload flag for Rx timestamp)
add ieee1588_enable on ICE.

Signed-off-by: Lingli Chen <linglix.chen@intel.com>
---
V2: update test plan accordingly

 conf/test_case_checklist.json     |  4 +---
 test_plans/ieee1588_test_plan.rst |  4 ++++
 tests/TestSuite_ieee1588.py       | 12 +++++++++---
 3 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
index 98f3eb49..f31daf62 100644
--- a/conf/test_case_checklist.json
+++ b/conf/test_case_checklist.json
@@ -1293,9 +1293,7 @@
             "NIC": [
                 "IGB_1G-I210_COPPER",
                 "cavium_a034",
-                "cavium_0011",
-                "ICE_25G-E810C_SFP",
-                "ICE_100G-E810C_QSFP"
+                "cavium_0011"
             ],
             "Target": [
                 "ALL"
diff --git a/test_plans/ieee1588_test_plan.rst b/test_plans/ieee1588_test_plan.rst
index 285ca306..f5c826e7 100644
--- a/test_plans/ieee1588_test_plan.rst
+++ b/test_plans/ieee1588_test_plan.rst
@@ -68,6 +68,10 @@ The -n command is used to select the number of memory channels. It should match
 --tx-offloads: for IEEE1588, the full-feature tx path needs to be enabled. Enabling any tx offload will force DPDK utilize full tx path.
 Enabling multiple segment offload is more reasonable for user cases.
 
+If test on ICE, start testpmd with the following parameters::
+
+   -cffffff -n 3 -- -i --tx-offloads=0x00008000 --enable-rx-timestamp
+
 Test Case: Enable IEEE1588 PTP packet reception and generation
 ==============================================================
 
diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
index 300d85d4..8a43a8c2 100644
--- a/tests/TestSuite_ieee1588.py
+++ b/tests/TestSuite_ieee1588.py
@@ -37,9 +37,15 @@ class TestIeee1588(TestCase):
         # For IEEE1588, the full-feature tx path needs to be enabled.
         # Enabling any tx offload will force DPDK utilize full tx path.
         # Enabling multiple segment offload is more reasonable for user cases.
-        self.pmdout.start_testpmd(
-            "Default", " --tx-offloads=%s" % DEV_TX_OFFLOAD_MULTI_SEGS
-        )
+        if self.kdriver == "ice":
+            self.pmdout.start_testpmd(
+                "Default",
+                " --enable-rx-timestamp --tx-offloads=%s" % DEV_TX_OFFLOAD_MULTI_SEGS,
+            )
+        else:
+            self.pmdout.start_testpmd(
+                "Default", " --tx-offloads=%s" % DEV_TX_OFFLOAD_MULTI_SEGS
+            )
 
     def set_up(self):
         """
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-05 14:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-04  2:42 [dts][PATCH V2] test*: Add ieee1588_enable on ICE Lingli Chen
2023-01-05 14:26 ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).