test suite reviews and discussions
 help / color / mirror / Atom feed
From: Weiyuan Li <weiyuanx.li@intel.com>
To: dts@dpdk.org
Cc: Weiyuan Li <weiyuanx.li@intel.com>
Subject: [dts][PATCH V1 2/2] tests/kernelpf_iavf: remove duplicate cases
Date: Wed,  4 Jan 2023 16:32:38 +0800	[thread overview]
Message-ID: <20230104083238.13296-2-weiyuanx.li@intel.com> (raw)
In-Reply-To: <20230104083238.13296-1-weiyuanx.li@intel.com>

Case kernelpf_iavf/vf_mac_filter and vf_macfilter/kernel_2pf_2vf_1vm_mac_add_filter duplicate remove this test case from kernelpf_iavf.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 42 +-------------------------------
 1 file changed, 1 insertion(+), 41 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 27daa525..2cc0ff7d 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -78,11 +78,7 @@ class TestKernelpfIavf(TestCase):
 
     def set_up(self):
 
-        if self.running_case == "test_vf_mac_filter":
-            self.destroy_vm_env()
-            if self.env_done is False:
-                self.setup_vm_env(driver="", set_vf_mac=False)
-        elif self.running_case == "test_vf_rx_interrupt":
+        if self.running_case == "test_vf_rx_interrupt":
             self.destroy_vm_env()
         elif self.env_done is False:
             self.setup_vm_env()
@@ -249,40 +245,6 @@ class TestKernelpfIavf(TestCase):
             stats["TX-packets"] != 0 and nums > 0, "vf send packet num is not match"
         )
 
-    def test_vf_mac_filter(self):
-        """
-        Not set VF MAC from kernel PF for this case, if set, will print
-        "not permitted error" when add new MAC for VF.
-        """
-        out = self.launch_testpmd(dcf_flag=self.dcf_mode)
-        self.testpmd_mac = self.get_testpmd_vf_mac(out)
-        self.vm_testpmd.execute_cmd("set fwd mac")
-        self.vm_testpmd.execute_cmd("set promisc all off")
-        self.vm_testpmd.execute_cmd("mac_addr add 0 %s" % self.add_addr)
-        self.vm_testpmd.execute_cmd("start")
-        # send packet with current mac
-        self.send_random_pkt(self.testpmd_mac, count=100)
-        self.verify_packet_count(100)
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        # send packet with add mac
-        self.send_random_pkt(self.add_addr, count=100)
-        self.verify_packet_count(100)
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        # send packet with wrong mac
-        self.send_random_pkt(self.wrong_mac, count=100)
-        self.verify_packet_count(0)
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        self.vm_testpmd.execute_cmd("mac_addr remove 0 %s" % self.add_addr)
-        self.send_random_pkt(self.add_addr, count=100)
-        self.verify_packet_count(0)
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        self.vm_testpmd.execute_cmd("mac_addr add 0 00:01:23:45:67:11")
-        self.send_random_pkt(self.add_addr, count=100)
-        self.verify_packet_count(0)
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        self.send_random_pkt("00:01:23:45:67:11", count=100)
-        self.verify_packet_count(100)
-
     def get_testpmd_vf_mac(self, out):
         result = re.search("([a-f0-9]{2}:){5}[a-f0-9]{2}", out, re.IGNORECASE)
         mac = result.group()
@@ -926,8 +888,6 @@ class TestKernelpfIavf(TestCase):
         else:
             self.vm_testpmd.execute_cmd("quit", "#")
             time.sleep(1)
-        if self.running_case == "test_vf_mac_filter":
-            self.destroy_vm_env()
         if not self.dcf_mode:
             self.dut.send_expect(
                 "ip link set dev %s vf 0 trust off" % self.host_intf, "# "
-- 
2.27.0


  reply	other threads:[~2023-01-04  8:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04  8:32 [dts][PATCH V1 1/2] test_plans/kernelpf_iavf: " Weiyuan Li
2023-01-04  8:32 ` Weiyuan Li [this message]
2023-01-05 14:28   ` [dts][PATCH V1 2/2] tests/kernelpf_iavf: " lijuan.tu
2023-01-06  2:12   ` Peng, Yuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230104083238.13296-2-weiyuanx.li@intel.com \
    --to=weiyuanx.li@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).