[dts][PATCH V1 1/2] test_plans/kernelpf_iavf: remove duplicate cases

[dts][PATCH V1 1/2] test_plans/kernelpf_iavf: remove duplicate cases

[Weiyuan Li]

Case kernelpf_iavf/vf_mac_filter and vf_macfilter/kernel_2pf_2vf_1vm_mac_add_filter duplicate remove this test case from kernelpf_iavf.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
 test_plans/kernelpf_iavf_test_plan.rst | 54 --------------------------
 1 file changed, 54 deletions(-)

diff --git a/test_plans/kernelpf_iavf_test_plan.rst b/test_plans/kernelpf_iavf_test_plan.rst
index c26aebd4..7af79f1b 100644
--- a/test_plans/kernelpf_iavf_test_plan.rst
+++ b/test_plans/kernelpf_iavf_test_plan.rst
@@ -69,60 +69,6 @@ Set txonly forward, start testpmd
 
 Check tester could receive the packets from application generated
 
-
-Test case: VF MAC filter
-========================
-Disable promisc mode, add a new MAC to VF0 and then start testpmd::
-
-    testpmd> set promisc all off
-    testpmd> mac_addr add 0 00:11:22:33:44:55
-    testpmd> set fwd mac
-    testpmd> start
-
-Use scapy to send 100 random packets with current VF0's MAC, verify the
-packets can be received and forwarded by the VF::
-
-    p=Ether(dst="00:01:23:45:67:89")/IP()/Raw(load='X'*30)
-
-Use scapy to send 100 random packets with new added VF0's MAC, verify the
-packets can be received and forwarded by the VF::
-
-    p=Ether(dst="00:11:22:33:44:55")/IP()/Raw(load='X'*30)
-
-Use scapy to send 100 random packets with a wrong MAC to VF0, verify the
-packets can't be received by the VF.
-
-Remove the MAC 00:11:22:33:44:55::
-
-    testpmd> mac_addr remove 0 00:11:22:33:44:55
-
-Use scapy to send 100 random packets with removed VF0's MAC, verify the
-packets can't be received and forwarded by the VF::
-
-    p=Ether(dst="00:11:22:33:44:55")/IP()/Raw(load='X'*30)
-
-Set the default mac address to other mac, check the mac address has be changed
-to new set mac::
-
-    testpmd> mac_addr set 0 00:01:23:45:67:11
-    testpmd> show port info 0
-
-Use scapy to send 100 random packets with original VF0's MAC, verify the
-packets can't be received and forwarded by the VF::
-
-    p=Ether(dst="00:01:23:45:67:89")/IP()/Raw(load='X'*30)
-
-Use scapy to send 100 random packets with new set VF0's MAC, verify the
-packets can be received and forwarded by the VF::
-
-    p=Ether(dst="00:01:23:45:67:11")/IP()/Raw(load='X'*30)
-
-Reset to original mac address
-
-Note::
-    Not set VF MAC from kernel PF for this case, if set, will print
-    "not permitted error" when add new MAC for VF.
-
 Test case: VF promisc
 =====================
 Enable kernel trust mode::
-- 
2.27.0

[dts][PATCH V1 2/2] tests/kernelpf_iavf: remove duplicate cases

[Weiyuan Li]

Case kernelpf_iavf/vf_mac_filter and vf_macfilter/kernel_2pf_2vf_1vm_mac_add_filter duplicate remove this test case from kernelpf_iavf.

Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 42 +-------------------------------
 1 file changed, 1 insertion(+), 41 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 27daa525..2cc0ff7d 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -78,11 +78,7 @@ class TestKernelpfIavf(TestCase):
 
     def set_up(self):
 
-        if self.running_case == "test_vf_mac_filter":
-            self.destroy_vm_env()
-            if self.env_done is False:
-                self.setup_vm_env(driver="", set_vf_mac=False)
-        elif self.running_case == "test_vf_rx_interrupt":
+        if self.running_case == "test_vf_rx_interrupt":
             self.destroy_vm_env()
         elif self.env_done is False:
             self.setup_vm_env()
@@ -249,40 +245,6 @@ class TestKernelpfIavf(TestCase):
             stats["TX-packets"] != 0 and nums > 0, "vf send packet num is not match"
         )
 
-    def test_vf_mac_filter(self):
-        """
-        Not set VF MAC from kernel PF for this case, if set, will print
-        "not permitted error" when add new MAC for VF.
-        """
-        out = self.launch_testpmd(dcf_flag=self.dcf_mode)
-        self.testpmd_mac = self.get_testpmd_vf_mac(out)
-        self.vm_testpmd.execute_cmd("set fwd mac")
-        self.vm_testpmd.execute_cmd("set promisc all off")
-        self.vm_testpmd.execute_cmd("mac_addr add 0 %s" % self.add_addr)
-        self.vm_testpmd.execute_cmd("start")
-        # send packet with current mac
-        self.send_random_pkt(self.testpmd_mac, count=100)
-        self.verify_packet_count(100)
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        # send packet with add mac
-        self.send_random_pkt(self.add_addr, count=100)
-        self.verify_packet_count(100)
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        # send packet with wrong mac
-        self.send_random_pkt(self.wrong_mac, count=100)
-        self.verify_packet_count(0)
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        self.vm_testpmd.execute_cmd("mac_addr remove 0 %s" % self.add_addr)
-        self.send_random_pkt(self.add_addr, count=100)
-        self.verify_packet_count(0)
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        self.vm_testpmd.execute_cmd("mac_addr add 0 00:01:23:45:67:11")
-        self.send_random_pkt(self.add_addr, count=100)
-        self.verify_packet_count(0)
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        self.send_random_pkt("00:01:23:45:67:11", count=100)
-        self.verify_packet_count(100)
-
     def get_testpmd_vf_mac(self, out):
         result = re.search("([a-f0-9]{2}:){5}[a-f0-9]{2}", out, re.IGNORECASE)
         mac = result.group()
@@ -926,8 +888,6 @@ class TestKernelpfIavf(TestCase):
         else:
             self.vm_testpmd.execute_cmd("quit", "#")
             time.sleep(1)
-        if self.running_case == "test_vf_mac_filter":
-            self.destroy_vm_env()
         if not self.dcf_mode:
             self.dut.send_expect(
                 "ip link set dev %s vf 0 trust off" % self.host_intf, "# "
-- 
2.27.0

[dts][PATCH V1 2/2] tests/kernelpf_iavf: remove duplicate cases

[lijuan.tu]

On Wed,  4 Jan 2023 16:32:38 +0800, Weiyuan Li <weiyuanx.li@intel.com> wrote:
> Case kernelpf_iavf/vf_mac_filter and vf_macfilter/kernel_2pf_2vf_1vm_mac_add_filter duplicate remove this test case from kernelpf_iavf.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Series applied, thanks

RE: [dts][PATCH V1 2/2] tests/kernelpf_iavf: remove duplicate cases

[Peng, Yuan]

> -----Original Message-----
> From: Weiyuan Li <weiyuanx.li@intel.com>
> Sent: Wednesday, January 4, 2023 4:33 PM
> To: dts@dpdk.org
> Cc: Li, WeiyuanX <weiyuanx.li@intel.com>
> Subject: [dts][PATCH V1 2/2] tests/kernelpf_iavf: remove duplicate cases
> 
> Case kernelpf_iavf/vf_mac_filter and
> vf_macfilter/kernel_2pf_2vf_1vm_mac_add_filter duplicate remove this
> test case from kernelpf_iavf.
> 
> Signed-off-by: Weiyuan Li <weiyuanx.li@intel.com>
> ---

Acked-by: Yuan Peng <yuan.peng@intel.com>