test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V2 1/2] test_plans/vf_pf_reset: add new case and plan for pf_reset_trigger_vf_reset
@ 2023-01-06 10:27 Hongbo Li
  2023-01-06 10:27 ` [dts][PATCH V2 2/2] tests/vf_pf_reset: " Hongbo Li
  0 siblings, 1 reply; 4+ messages in thread
From: Hongbo Li @ 2023-01-06 10:27 UTC (permalink / raw)
  To: dts; +Cc: Hongbo Li, Tang Yaqi

add case test_pf_reset_trigger_vf_reset according to test plan.

Signed-off-by: Tang Yaqi <yaqi.tang@intel.com>
Signed-off-by: Hongbo Li <hongbox.li@intel.com>
---

v2:
-modify git comments
 test_plans/vf_pf_reset_test_plan.rst | 40 ++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/test_plans/vf_pf_reset_test_plan.rst b/test_plans/vf_pf_reset_test_plan.rst
index 866214f7..cc204e26 100644
--- a/test_plans/vf_pf_reset_test_plan.rst
+++ b/test_plans/vf_pf_reset_test_plan.rst
@@ -630,3 +630,43 @@ test Case 10: vf reset (two vfs passed through to two VM)
 
 8. Reset vf0 and vf1, send the two packets,
    vf0 can forward both of the two type packets to VF1.
+
+test case 11: pf reset trigger vf reset
+=======================================
+
+1. Execute step1-step6 of test case 1.
+
+2. Reset PF::
+
+     echo 1 > /sys/bus/pci/devices/0000:81:00.0/reset
+
+3. Testpmd shows::
+
+     Port 0: reset event
+     Port 1: reset event
+
+4. Reset the vfs::
+
+     testpmd> stop
+     testpmd> port stop all
+     testpmd> port reset all
+     testpmd> port start all
+     testpmd> start
+
+   Send the same 1000 packets with scapy from tester, verify the packets can be
+   received by one VF and can be forward to another VF correctly,
+   check the port info::
+
+     testpmd> show port info all
+
+     ********************* Infos for port 0  *********************
+     MAC address: 00:11:22:33:44:11
+     Promiscuous mode: disabled
+     Allmulticast mode: enabled
+
+     ********************* Infos for port 1  *********************
+     MAC address: 00:11:22:33:44:12
+     Promiscuous mode: disabled
+     Allmulticast mode: enabled
+
+   The info status is consistent to the status before reset.
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts][PATCH V2 2/2] tests/vf_pf_reset: add new case and plan for pf_reset_trigger_vf_reset
  2023-01-06 10:27 [dts][PATCH V2 1/2] test_plans/vf_pf_reset: add new case and plan for pf_reset_trigger_vf_reset Hongbo Li
@ 2023-01-06 10:27 ` Hongbo Li
  2023-01-10  7:26   ` Jiale, SongX
  2023-01-10  7:36   ` lijuan.tu
  0 siblings, 2 replies; 4+ messages in thread
From: Hongbo Li @ 2023-01-06 10:27 UTC (permalink / raw)
  To: dts; +Cc: Hongbo Li

1.add case test_pf_reset_trigger_vf_reset according to test plan.
2.optimize the logic of finding the tester port in the script

Signed-off-by: Hongbo Li <hongbox.li@intel.com>
---
 tests/TestSuite_vf_pf_reset.py | 111 +++++++++++++++++++++++++++++++--
 1 file changed, 106 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_vf_pf_reset.py b/tests/TestSuite_vf_pf_reset.py
index 6a9b5969..31cdbb39 100644
--- a/tests/TestSuite_vf_pf_reset.py
+++ b/tests/TestSuite_vf_pf_reset.py
@@ -61,12 +61,12 @@ class TestVfPfReset(TestCase):
         self.host_intf_1 = self.dut.ports_info[self.used_dut_port_1]["intf"]
 
         tester_port_0 = self.tester.get_local_port(self.used_dut_port_0)
-        self.tester_intf_0 = self.tester.get_interface(self.used_dut_port_0)
-        self.tester_mac_0 = self.tester.get_mac(self.used_dut_port_0)
+        self.tester_intf_0 = self.tester.get_interface(tester_port_0)
+        self.tester_mac_0 = self.tester.get_mac(tester_port_0)
 
         tester_port_1 = self.tester.get_local_port(self.used_dut_port_1)
-        self.tester_intf_1 = self.tester.get_interface(self.used_dut_port_1)
-        self.tester_mac_1 = self.tester.get_mac(self.used_dut_port_1)
+        self.tester_intf_1 = self.tester.get_interface(tester_port_1)
+        self.tester_mac_1 = self.tester.get_mac(tester_port_1)
 
         self.vf_mac1 = "00:11:22:33:44:11"
         self.vf_mac2 = "00:11:22:33:44:12"
@@ -251,7 +251,8 @@ class TestVfPfReset(TestCase):
         pmd_output.execute_cmd(f"port reset {port}")
         pmd_output.execute_cmd(f"port start {port}")
         pmd_output.execute_cmd("start")
-        pmd_output.execute_cmd(f"show port info {port}")
+        port_info = pmd_output.execute_cmd(f"show port info {port}")
+        return port_info
 
     def setup_vm_env(self):
         """
@@ -1305,6 +1306,106 @@ class TestVfPfReset(TestCase):
         self.vm0_testpmd.quit()
         self.vm1_testpmd.quit()
 
+    def test_pf_reset_trigger_vf_reset(self):
+        """
+        check pf reset and trigger vf reset
+        """
+        # Set mac
+        self.ip_link_set(
+            host_intf=self.host_intf_0,
+            cmd="vf",
+            port=0,
+            types="mac",
+            value=self.vf_mac1,
+        )
+        self.ip_link_set(
+            host_intf=self.host_intf_0,
+            cmd="vf",
+            port=1,
+            types="mac",
+            value=self.vf_mac2,
+        )
+
+        # Set the VLAN id of VF0 and VF1
+        self.ip_link_set(
+            host_intf=self.host_intf_0, cmd="vf", port=0, types="vlan", value="1"
+        )
+        self.ip_link_set(
+            host_intf=self.host_intf_0, cmd="vf", port=1, types="vlan", value="1"
+        )
+
+        # Launch pmd
+        param = "--portmask=0x3" + " --port-topology=paired"
+        self.pmd_output.start_testpmd(
+            cores="1S/4C/1T",
+            ports=[self.sriov_vfs_port[0].pci, self.sriov_vfs_port[1].pci],
+            param=param,
+        )
+
+        # Input pmd command
+        self.pmd_output.execute_cmd("set fwd mac")
+        self.pmd_output.execute_cmd("start")
+        self.pmd_output.execute_cmd("set allmulti all on")
+        self.pmd_output.execute_cmd("set promisc all off")
+        self.pmd_output.execute_cmd("set verbose 1")
+        out = self.pmd_output.execute_cmd("show port info all")
+        # Diable Promiscuous mode and enable Allmulticast mode
+        self.verify(
+            "Promiscuous mode: enabled" not in out, "disable promiscuous mode failed."
+        )
+        self.verify(
+            "Allmulticast mode: disabled" not in out,
+            "enabled allmulticast mode failed.",
+        )
+
+        # The packets can be received
+        # By one VF and can be forward to another VF correctly
+        self.verify_send_packets(
+            self.tester_intf_0,
+            self.vf_mac1,
+            expect_value=1000,
+            count=1000,
+            vlan=1,
+            tx_port=self.tester_intf_0,
+        )
+        # Pf reset
+        self.used_dut_port = self.dut_ports[0]
+        self.domain_id_0 = self.dut.ports_info[self.used_dut_port]["port"].domain_id
+        self.bus_id_0 = self.dut.ports_info[self.used_dut_port]["port"].bus_id
+        self.devfun_id_0 = self.dut.ports_info[self.used_dut_port]["port"].devfun_id
+        reset_cmd = (
+            "echo 1 > /sys/bus/pci/devices/"
+            + self.domain_id_0
+            + "\\:"
+            + self.bus_id_0
+            + "\\:"
+            + self.devfun_id_0
+            + "/reset"
+        )
+        self.dut_new_session.send_expect(reset_cmd, "#")
+        # Check testpmd output "reset event"
+        out = self.pmd_output.get_output()
+        self.verify("reset event" in out, "testpmd did not report reset event")
+        # Send packets and verify again
+        port_info = self.reset_vf_ports(self.pmd_output)
+        # Check Diable Promiscuous mode and enable Allmulticast mode
+        self.verify(
+            "Promiscuous mode: enabled" not in port_info,
+            "disable promiscuous mode failed.",
+        )
+        self.verify(
+            "Allmulticast mode: disabled" not in port_info,
+            "enabled allmulticast mode failed.",
+        )
+        self.verify_send_packets(
+            self.tester_intf_0,
+            self.vf_mac1,
+            expect_value=1000,
+            count=1000,
+            vlan=1,
+            tx_port=self.tester_intf_0,
+        )
+
     def tear_down(self):
         """
         Run after each test case.
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [dts][PATCH V2 2/2] tests/vf_pf_reset: add new case and plan for pf_reset_trigger_vf_reset
  2023-01-06 10:27 ` [dts][PATCH V2 2/2] tests/vf_pf_reset: " Hongbo Li
@ 2023-01-10  7:26   ` Jiale, SongX
  2023-01-10  7:36   ` lijuan.tu
  1 sibling, 0 replies; 4+ messages in thread
From: Jiale, SongX @ 2023-01-10  7:26 UTC (permalink / raw)
  To: Li, HongboX, dts; +Cc: Li, HongboX

> -----Original Message-----
> From: Hongbo Li <hongbox.li@intel.com>
> Sent: Friday, January 6, 2023 6:28 PM
> To: dts@dpdk.org
> Cc: Li, HongboX <hongbox.li@intel.com>
> Subject: [dts][PATCH V2 2/2] tests/vf_pf_reset: add new case and plan for
> pf_reset_trigger_vf_reset
> 
> 1.add case test_pf_reset_trigger_vf_reset according to test plan.
> 2.optimize the logic of finding the tester port in the script
> 
> Signed-off-by: Hongbo Li <hongbox.li@intel.com>
> ---
Tested-by: Song Jiale <songx.jiale@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts][PATCH V2 2/2] tests/vf_pf_reset: add new case and plan for pf_reset_trigger_vf_reset
  2023-01-06 10:27 ` [dts][PATCH V2 2/2] tests/vf_pf_reset: " Hongbo Li
  2023-01-10  7:26   ` Jiale, SongX
@ 2023-01-10  7:36   ` lijuan.tu
  1 sibling, 0 replies; 4+ messages in thread
From: lijuan.tu @ 2023-01-10  7:36 UTC (permalink / raw)
  To: dts, Hongbo Li; +Cc: Hongbo Li

On Fri,  6 Jan 2023 18:27:58 +0800, Hongbo Li <hongbox.li@intel.com> wrote:
> 1.add case test_pf_reset_trigger_vf_reset according to test plan.
> 2.optimize the logic of finding the tester port in the script
> 
> Signed-off-by: Hongbo Li <hongbox.li@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Series applied, thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-01-10  7:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-06 10:27 [dts][PATCH V2 1/2] test_plans/vf_pf_reset: add new case and plan for pf_reset_trigger_vf_reset Hongbo Li
2023-01-06 10:27 ` [dts][PATCH V2 2/2] tests/vf_pf_reset: " Hongbo Li
2023-01-10  7:26   ` Jiale, SongX
2023-01-10  7:36   ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).