test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1 0/2] remove unit_tests_* and replace with meson_tests and remove other invalid suites
@ 2023-01-13  9:38 Yu Jiang
  2023-01-13  9:38 ` [dts][PATCH V1] tests/pf_smoke: modify script when TG with Trex and SUT are the same server Yu Jiang
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Yu Jiang @ 2023-01-13  9:38 UTC (permalink / raw)
  To: lijuan.tu, dts; +Cc: Yu Jiang

remove unit_tests_* and replace with meson_tests and remove other invalid suites

Yu Jiang (2):
  usr_guide and executions: remove unit_tests_* and replace with
    meson_tests
  test_plans/ABI_stable: remove unit_tests_* and replace with
    meson_tests and remove other invalid suites

 doc/dts_gsg/usr_guide/usage.rst     |  2 +-
 executions/execution_smoke.cfg      | 14 +---------
 test_plans/ABI_stable_test_plan.rst | 40 +++--------------------------
 3 files changed, 6 insertions(+), 50 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dts][PATCH V1] tests/pf_smoke: modify script when TG with Trex and SUT are the same server
  2023-01-13  9:38 [dts][PATCH V1 0/2] remove unit_tests_* and replace with meson_tests and remove other invalid suites Yu Jiang
@ 2023-01-13  9:38 ` Yu Jiang
  2023-01-13  9:38 ` [dts][PATCH V1] tests/vf_l2fwd: rebind interfaces to vfio-pci to avoid impacting pf suite Yu Jiang
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 7+ messages in thread
From: Yu Jiang @ 2023-01-13  9:38 UTC (permalink / raw)
  To: lijuan.tu, dts; +Cc: Yu Jiang

"TREX" directory also under /var/run/dpdk, 
When TG with Trex and SUT are the same server, 

Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
 tests/TestSuite_pf_smoke.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_pf_smoke.py b/tests/TestSuite_pf_smoke.py
index 909c7e1b..19cac513 100644
--- a/tests/TestSuite_pf_smoke.py
+++ b/tests/TestSuite_pf_smoke.py
@@ -68,7 +68,7 @@ class TestPfSmoke(TestCase):
         out = self.check_session.send_expect(
             "ls -l /var/run/dpdk |awk '/^d/ {print $NF}'", "# ", 1
         )
-        if out == "" or "No such file or directory" in out:
+        if out == "" or out == 'TREX'  or "No such file or directory" in out:
             self.pf_launch_dpdk_app()
 
     def pf_launch_dpdk_app(self):
-- 
2.25.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dts][PATCH V1] tests/vf_l2fwd: rebind interfaces to vfio-pci to avoid impacting pf suite
  2023-01-13  9:38 [dts][PATCH V1 0/2] remove unit_tests_* and replace with meson_tests and remove other invalid suites Yu Jiang
  2023-01-13  9:38 ` [dts][PATCH V1] tests/pf_smoke: modify script when TG with Trex and SUT are the same server Yu Jiang
@ 2023-01-13  9:38 ` Yu Jiang
  2023-01-13  9:41   ` Yuan, DukaiX
  2023-01-13  9:38 ` [dts][PATCH V1 1/2] usr_guide and executions: remove unit_tests_* and replace with meson_tests Yu Jiang
  2023-01-13  9:38 ` [dts][PATCH V1 2/2] test_plans/ABI_stable: remove unit_tests_* and replace with meson_tests and remove other invalid suites Yu Jiang
  3 siblings, 1 reply; 7+ messages in thread
From: Yu Jiang @ 2023-01-13  9:38 UTC (permalink / raw)
  To: lijuan.tu, dts; +Cc: Yu Jiang

rebind interfaces to vfio-pci to avoid impacting pf suite

Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
 tests/TestSuite_vf_l2fwd.py | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_vf_l2fwd.py b/tests/TestSuite_vf_l2fwd.py
index 542838c6..849ba638 100644
--- a/tests/TestSuite_vf_l2fwd.py
+++ b/tests/TestSuite_vf_l2fwd.py
@@ -36,6 +36,7 @@ class TestVfL2fwd(TestCase):
             len(self.dut_ports) >= self.number_of_ports,
             "Not enough ports for " + self.nic,
         )
+        self.vf_ports = ""
         self.ports_socket = self.dut.get_numa_id(self.dut_ports[0])
         # compile
         out = self.dut.build_dpdk_apps("./examples/l2fwd")
@@ -64,7 +65,8 @@ class TestVfL2fwd(TestCase):
         self.verify(len(self.sriov_vfs_port_0) != 0, "VF create failed")
         self.dut.generate_sriov_vfs_by_port(self.dut_ports[1], 1, self.kdriver)
         self.sriov_vfs_port_1 = self.dut.ports_info[self.dut_ports[1]]["vfs_port"]
-        self.vf_ports = [self.sriov_vfs_port_0[0].pci, self.sriov_vfs_port_1[0].pci]
+        self.vf_ports = [self.dut_ports[0], self.dut_ports[1]]
+        self.vf_ports_pci = [self.sriov_vfs_port_0[0].pci, self.sriov_vfs_port_1[0].pci]
         for port in self.sriov_vfs_port_0 + self.sriov_vfs_port_1:
             port.bind_driver(self.drivername)
 
@@ -82,7 +84,7 @@ class TestVfL2fwd(TestCase):
         # the cases use the first two ports
         port_mask = utils.create_mask([self.dut_ports[0], self.dut_ports[1]])
         cores = self.dut.get_core_list(self.core_config, socket=self.ports_socket)
-        eal_params = self.dut.create_eal_parameters(cores=cores, ports=self.vf_ports)
+        eal_params = self.dut.create_eal_parameters(cores=cores, ports=self.vf_ports_pci)
         for queues in self.test_queues:
             command_line = "./%s  %s -- -q %s -p %s &" % (
                 self.app_l2fwd_path,
@@ -133,4 +135,8 @@ class TestVfL2fwd(TestCase):
         """
         Run after each test suite.
         """
-        pass
+        self.dut.kill_all()
+        if self.vf_ports:
+            for item in self.vf_ports:
+                self.dut.destroy_sriov_vfs_by_port(item)
+        self.dut.bind_interfaces_linux(self.drivername)
-- 
2.25.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dts][PATCH V1 1/2] usr_guide and executions: remove unit_tests_* and replace with meson_tests
  2023-01-13  9:38 [dts][PATCH V1 0/2] remove unit_tests_* and replace with meson_tests and remove other invalid suites Yu Jiang
  2023-01-13  9:38 ` [dts][PATCH V1] tests/pf_smoke: modify script when TG with Trex and SUT are the same server Yu Jiang
  2023-01-13  9:38 ` [dts][PATCH V1] tests/vf_l2fwd: rebind interfaces to vfio-pci to avoid impacting pf suite Yu Jiang
@ 2023-01-13  9:38 ` Yu Jiang
  2023-01-13  9:38 ` [dts][PATCH V1 2/2] test_plans/ABI_stable: remove unit_tests_* and replace with meson_tests and remove other invalid suites Yu Jiang
  3 siblings, 0 replies; 7+ messages in thread
From: Yu Jiang @ 2023-01-13  9:38 UTC (permalink / raw)
  To: lijuan.tu, dts; +Cc: Yu Jiang

remove unit_tests_* and replace with meson_tests

Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
 doc/dts_gsg/usr_guide/usage.rst |  2 +-
 executions/execution_smoke.cfg  | 14 +-------------
 2 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/doc/dts_gsg/usr_guide/usage.rst b/doc/dts_gsg/usr_guide/usage.rst
index 24bf8d70..2c853dc8 100644
--- a/doc/dts_gsg/usr_guide/usage.rst
+++ b/doc/dts_gsg/usr_guide/usage.rst
@@ -50,7 +50,7 @@ Here are an example for functional testing:
    drivername=vfio-pci
    build_type=meson
    test_suites=
-        unit_tests_eal:test_version\test_common,
+        meson_tests:test_fasts\test_driver,
    targets=
         x86_64-default-linuxapp-gcc,
    parameters=nic_type=cfg:func=true
diff --git a/executions/execution_smoke.cfg b/executions/execution_smoke.cfg
index c7b5cbb3..5b2bb734 100644
--- a/executions/execution_smoke.cfg
+++ b/executions/execution_smoke.cfg
@@ -4,19 +4,7 @@ crbs=<CRB IP Address>
 drivername=<driver name igb_uio or vfio-pci or mlx5_core or uio_pci_generic>
 build_type=<meson>
 test_suites=
-    unit_tests_cmdline,
-    unit_tests_eal,
-    unit_tests_dump,
-    unit_tests_kni,
-    unit_tests_lpm,
-    unit_tests_mbuf,
-    unit_tests_mempool,
-    unit_tests_power,
-    unit_tests_pmd_perf,
-    unit_tests_qos,
-    unit_tests_ring,
-    unit_tests_ringpmd,
-    unit_tests_timer,
+    meson_tests:test_fasts,
     dynamic_config,
     jumboframes,
     scatter,
-- 
2.25.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dts][PATCH V1 2/2] test_plans/ABI_stable: remove unit_tests_* and replace with meson_tests and remove other invalid suites
  2023-01-13  9:38 [dts][PATCH V1 0/2] remove unit_tests_* and replace with meson_tests and remove other invalid suites Yu Jiang
                   ` (2 preceding siblings ...)
  2023-01-13  9:38 ` [dts][PATCH V1 1/2] usr_guide and executions: remove unit_tests_* and replace with meson_tests Yu Jiang
@ 2023-01-13  9:38 ` Yu Jiang
  3 siblings, 0 replies; 7+ messages in thread
From: Yu Jiang @ 2023-01-13  9:38 UTC (permalink / raw)
  To: lijuan.tu, dts; +Cc: Yu Jiang

1, remove unit_tests_* and replace with meson_tests;
2, remove invalid suites: vhost_dequeue_zero_copy,flow_classify_softnic;
  - vhost_dequeue_zero_copy: dpdk20.11 cacf8267cc (vhost: remove dequeue zero-copy support)
  - flow_classify_softnic: 
	 * dts commit 6090a316 (test/flow_classify_softnic): removed the test suite as per dpdk changes
3, remove vhost_enqueue_interrupt and replace with vhost_user_interrupt according to dts changes commit:71b154651;
4, correct type for vhost_virtio_pmd_interrupt;

Signed-off-by: Yu Jiang <yux.jiang@intel.com>
---
 test_plans/ABI_stable_test_plan.rst | 40 +++--------------------------
 1 file changed, 4 insertions(+), 36 deletions(-)

diff --git a/test_plans/ABI_stable_test_plan.rst b/test_plans/ABI_stable_test_plan.rst
index 9f05cc6e..762e1779 100644
--- a/test_plans/ABI_stable_test_plan.rst
+++ b/test_plans/ABI_stable_test_plan.rst
@@ -57,57 +57,25 @@ Execute Test Suites
   +-------------------------------+------------------------+
   |       Test Suites             |          Type          |
   +===============================+========================+
-  |   unit_tests_cmdline          |     functional         |
-  +-------------------------------+------------------------+
-  |   unit_tests_crc              |     functional         |
-  +-------------------------------+------------------------+
-  |   unit_tests_dump             |     functional         |
-  +-------------------------------+------------------------+
-  |   unit_tests_eal              |     functional         |
-  +-------------------------------+------------------------+
-  |   unit_tests_kni              |     functional         |
-  +-------------------------------+------------------------+
-  |   unit_tests_loopback         |     functional         |
-  +-------------------------------+------------------------+
-  |   unit_tests_lpm              |     functional         |
-  +-------------------------------+------------------------+
-  |   unit_tests_mbuf             |     functional         |
-  +-------------------------------+------------------------+
-  |   unit_tests_mempool          |     functional         |
-  +-------------------------------+------------------------+
-  |   unit_tests_pmd_perf         |     functional         |
-  +-------------------------------+------------------------+
-  |   unit_tests_power            |     functional         |
-  +-------------------------------+------------------------+
-  |   unit_tests_qos              |     functional         |
-  +-------------------------------+------------------------+
-  |   unit_tests_ringpmd          |     functional         |
-  +-------------------------------+------------------------+
-  |   unit_tests_ring             |     functional         |
-  +-------------------------------+------------------------+
-  |   unit_tests_timer            |     functional         |
+  |   meson_tests                 |     functional         |
   +-------------------------------+------------------------+
   |   vhost_1024_ethports         |     functional         |
   +-------------------------------+------------------------+
-  |   vhost_dequeue_zero_copy     |     functional         |
-  +-------------------------------+------------------------+
-  |   vhost_enqueue_interrupt     |     functional         |
-  +-------------------------------+------------------------+
   |   vhost_event_idx_interrupt   |     functional         |
   +-------------------------------+------------------------+
   |   vhost_multi_queue_qemu      |     functional         |
   +-------------------------------+------------------------+
   |   vhost_pmd_xstats            |     functional         |
   +-------------------------------+------------------------+
+  |   vhost_user_interrupt        |     functional         |
+  +-------------------------------+------------------------+
   |   vhost_virtio_user_interrupt |     functional         |
   +-------------------------------+------------------------+
   |   vhost_user_live_migration   |     functional         |
   +-------------------------------+------------------------+
   |   flow_classify               |     functional         |
   +-------------------------------+------------------------+
-  |   flow_classify_softnic       |     functional         |
-  +-------------------------------+------------------------+
-  |   vhost_virtio_pmd_interrupt  |     functional         |
+  |   vhost_virtio_pmd_interrupt  |     performance        |
   +-------------------------------+------------------------+
   |   l2fwd                       |     performance        |
   +-------------------------------+------------------------+
-- 
2.25.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [dts][PATCH V1] tests/vf_l2fwd: rebind interfaces to vfio-pci to avoid impacting pf suite
  2023-01-13  9:38 ` [dts][PATCH V1] tests/vf_l2fwd: rebind interfaces to vfio-pci to avoid impacting pf suite Yu Jiang
@ 2023-01-13  9:41   ` Yuan, DukaiX
  0 siblings, 0 replies; 7+ messages in thread
From: Yuan, DukaiX @ 2023-01-13  9:41 UTC (permalink / raw)
  To: Jiang, YuX, Tu, Lijuan, dts; +Cc: Jiang, YuX

> -----Original Message-----
> From: Yu Jiang <yux.jiang@intel.com>
> Sent: 2023年1月13日 17:39
> To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
> Cc: Jiang, YuX <yux.jiang@intel.com>
> Subject: [dts][PATCH V1] tests/vf_l2fwd: rebind interfaces to vfio-pci to
> avoid impacting pf suite
> 
> rebind interfaces to vfio-pci to avoid impacting pf suite
> 
> Signed-off-by: Yu Jiang <yux.jiang@intel.com>
> ---
Tested-by: Dukai Yuan<dukaix.yuan@intel.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dts][PATCH V1 0/2] remove unit_tests_* and replace with meson_tests and remove other invalid suites
@ 2023-01-13  5:34 Yu Jiang
  0 siblings, 0 replies; 7+ messages in thread
From: Yu Jiang @ 2023-01-13  5:34 UTC (permalink / raw)
  To: lijuan.tu, dts; +Cc: Yu Jiang

remove unit_tests_* and replace with meson_tests and remove other invalid suites

Yu Jiang (2):
  usr_guide and executions: remove unit_tests_* and replace with
    meson_tests
  test_plans/ABI_stable: remove unit_tests_* and replace with
    meson_tests and remove other invalid suites

 doc/dts_gsg/usr_guide/usage.rst     |  2 +-
 executions/execution_smoke.cfg      | 14 +---------
 test_plans/ABI_stable_test_plan.rst | 40 +++--------------------------
 3 files changed, 6 insertions(+), 50 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-01-13  9:41 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13  9:38 [dts][PATCH V1 0/2] remove unit_tests_* and replace with meson_tests and remove other invalid suites Yu Jiang
2023-01-13  9:38 ` [dts][PATCH V1] tests/pf_smoke: modify script when TG with Trex and SUT are the same server Yu Jiang
2023-01-13  9:38 ` [dts][PATCH V1] tests/vf_l2fwd: rebind interfaces to vfio-pci to avoid impacting pf suite Yu Jiang
2023-01-13  9:41   ` Yuan, DukaiX
2023-01-13  9:38 ` [dts][PATCH V1 1/2] usr_guide and executions: remove unit_tests_* and replace with meson_tests Yu Jiang
2023-01-13  9:38 ` [dts][PATCH V1 2/2] test_plans/ABI_stable: remove unit_tests_* and replace with meson_tests and remove other invalid suites Yu Jiang
  -- strict thread matches above, loose matches on Subject: below --
2023-01-13  5:34 [dts][PATCH V1 0/2] " Yu Jiang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).