test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/queue_start_stop: optimize script
@ 2023-01-18 15:48 Song Jiale
  2023-01-29  2:13 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Song Jiale @ 2023-01-18 15:48 UTC (permalink / raw)
  To: dts; +Cc: Song Jiale

there is "#" in the echo after the "patch -p0" command of Linux is executed.
this "#" is not the expected value, which will affect the subsequent tests.

Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 tests/TestSuite_queue_start_stop.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_queue_start_stop.py b/tests/TestSuite_queue_start_stop.py
index b6f4ba96..80baf8d6 100644
--- a/tests/TestSuite_queue_start_stop.py
+++ b/tests/TestSuite_queue_start_stop.py
@@ -93,9 +93,9 @@ class TestQueueStartStop(TestCase):
         """
         try:
             if on:
-                self.dut.send_expect("patch -p0 < %s" % patch_dir, "#")
+                self.dut.send_expect("patch -p0 < %s" % patch_dir, "[~|~\]]# ")
             else:
-                self.dut.send_expect("patch -p0 -R < %s" % patch_dir, "#")
+                self.dut.send_expect("patch -p0 -R < %s" % patch_dir, "[~|~\]]# ")
         except Exception as e:
             raise ValueError("patch_hotfix_dpdk failure: %s" % e)
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [dts] [PATCH V1] tests/queue_start_stop: optimize script
  2023-01-18 15:48 [dts] [PATCH V1] tests/queue_start_stop: optimize script Song Jiale
@ 2023-01-29  2:13 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2023-01-29  2:13 UTC (permalink / raw)
  To: Jiale, SongX, dts; +Cc: Jiale, SongX



> -----Original Message-----
> From: Song Jiale <songx.jiale@intel.com>
> Sent: Wednesday, January 18, 2023 11:48 PM
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>
> Subject: [dts] [PATCH V1] tests/queue_start_stop: optimize script
> 
> there is "#" in the echo after the "patch -p0" command of Linux is executed.
> this "#" is not the expected value, which will affect the subsequent tests.
> 
> Signed-off-by: Song Jiale <songx.jiale@intel.com>
> ---
>  tests/TestSuite_queue_start_stop.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_queue_start_stop.py
> b/tests/TestSuite_queue_start_stop.py
> index b6f4ba96..80baf8d6 100644
> --- a/tests/TestSuite_queue_start_stop.py
> +++ b/tests/TestSuite_queue_start_stop.py
> @@ -93,9 +93,9 @@ class TestQueueStartStop(TestCase):
>          """
>          try:
>              if on:
> -                self.dut.send_expect("patch -p0 < %s" % patch_dir, "#")
> +                self.dut.send_expect("patch -p0 < %s" % patch_dir, "[~|~\]]# ")
>              else:
> -                self.dut.send_expect("patch -p0 -R < %s" % patch_dir, "#")
> +                self.dut.send_expect("patch -p0 -R < %s" % patch_dir, "[~|~\]]# ")
>          except Exception as e:
>              raise ValueError("patch_hotfix_dpdk failure: %s" % e)

Applied, but it is not a good idea to apply a patch to change DPDK source code, even it is only a "printf" statement. 
Checking  queue statistics can be an alternative.

thanks


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-29  2:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-18 15:48 [dts] [PATCH V1] tests/queue_start_stop: optimize script Song Jiale
2023-01-29  2:13 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).