test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund@corigine.com>
To: dts@dpdk.org
Cc: oss-drivers@corigine.com, "Qin Ke" <qin.ke@corigine.com>,
	"Niklas Söderlund" <niklas.soderlund@corigine.com>,
	"Chaoyong He" <chaoyong.he@corigine.com>
Subject: [PATCH 2/5] framework/dut: only map ports not already matched
Date: Wed,  8 Feb 2023 17:46:21 +0100	[thread overview]
Message-ID: <20230208164624.2997614-3-niklas.soderlund@corigine.com> (raw)
In-Reply-To: <20230208164624.2997614-1-niklas.soderlund@corigine.com>

From: Qin Ke <qin.ke@corigine.com>

When NIC has two ports but single PCI address, the function of
map_available_ports_uncached will match both the two dut ports
with the first tester port beacause the two tester ports have the
same PCI address as the only matching condition.

Add support for it by only mapping ports not already matched. It
ignores the tester port which has been matched and added to dut
ports map, then the second tester port can be matched correctly.

Signed-off-by: Qin Ke <qin.ke@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Signed-off-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
 framework/dut.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/dut.py b/framework/dut.py
index eb988ac3e265..df6986ed450c 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -1249,7 +1249,7 @@ class Dut(Crb):
                             break
                     elif (
                         self.tester.ports_info[remotePort]["pci"].lower()
-                        == peer.lower()
+                        == peer.lower() and hits[remotePort] == False
                     ):
                         hits[remotePort] = True
                         self.ports_map[dutPort] = remotePort
-- 
2.39.1


  parent reply	other threads:[~2023-02-08 16:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 16:46 [PATCH 0/5] Add initial support for NFP PMD Niklas Söderlund
2023-02-08 16:46 ` [PATCH 1/5] framework/dut: add support for restoring dual-port NIC with single PCI address Niklas Söderlund
2023-02-08 16:46 ` Niklas Söderlund [this message]
2023-02-08 16:46 ` [PATCH 3/5] nics/net_device: add support for dual-port nfp " Niklas Söderlund
2023-02-08 16:46 ` [PATCH 4/5] framework/dut: add longer timeout for loading driver and firmware Niklas Söderlund
2023-02-08 16:46 ` [PATCH 5/5] framework/setting: enable Corigine and Netronome NIC for dts Niklas Söderlund
2023-02-09 15:27 ` [PATCH v2 0/5] Add initial support for NFP PMD Niklas Söderlund
2023-02-09 15:27   ` [PATCH v2 1/5] framework/dut: add support for restoring dual-port NIC with single PCI address Niklas Söderlund
2023-02-09 15:27   ` [PATCH v2 2/5] framework/dut: only map ports not already matched Niklas Söderlund
2023-02-09 15:27   ` [PATCH v2 3/5] nics/net_device: add support for dual-port nfp NIC with single PCI address Niklas Söderlund
2023-02-09 15:27   ` [PATCH v2 4/5] framework/dut: add longer timeout for loading driver and firmware Niklas Söderlund
2023-02-09 15:27   ` [PATCH v2 5/5] framework/setting: enable Corigine and Netronome NIC for dts Niklas Söderlund
2023-03-06 13:06   ` [PATCH v2 0/5] Add initial support for NFP PMD Niklas Söderlund
2023-03-07  3:35   ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230208164624.2997614-3-niklas.soderlund@corigine.com \
    --to=niklas.soderlund@corigine.com \
    --cc=chaoyong.he@corigine.com \
    --cc=dts@dpdk.org \
    --cc=oss-drivers@corigine.com \
    --cc=qin.ke@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).