test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund@corigine.com>
To: dts@dpdk.org
Cc: oss-drivers@corigine.com, "Qin Ke" <qin.ke@corigine.com>,
	"Niklas Söderlund" <niklas.soderlund@corigine.com>,
	"Chaoyong He" <chaoyong.he@corigine.com>
Subject: [PATCH v2 4/5] framework/dut: add longer timeout for loading driver and firmware
Date: Thu,  9 Feb 2023 16:27:16 +0100	[thread overview]
Message-ID: <20230209152717.4057220-5-niklas.soderlund@corigine.com> (raw)
In-Reply-To: <20230209152717.4057220-1-niklas.soderlund@corigine.com>

From: Qin Ke <qin.ke@corigine.com>

Nfp NIC may take a long time whiling loading its driver and firmware
at probe time. Add longer timeout to ensure that these operations can
excutes successfully and stably for all NIC.

Signed-off-by: Qin Ke <qin.ke@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Signed-off-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
 framework/dut.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/framework/dut.py b/framework/dut.py
index 64de28a5fdd8..31c04e4a8044 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -424,9 +424,11 @@ class Dut(Crb):
                 )
                 # bind to linux kernel driver
                 if not self.is_container:
-                    self.send_expect("modprobe %s" % driver, "# ")
+                    self.send_expect("modprobe %s" % driver, "# ", timeout=30)
                 self.send_expect(
-                    "echo %s > /sys/bus/pci/drivers/%s/bind" % (pci_bus, driver), "# "
+                    "echo %s > /sys/bus/pci/drivers/%s/bind" % (pci_bus, driver),
+                    "# ",
+                    timeout=30,
                 )
                 pull_retries = 5
                 itf = "N/A"
-- 
2.39.1


  parent reply	other threads:[~2023-02-09 15:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 16:46 [PATCH 0/5] Add initial support for NFP PMD Niklas Söderlund
2023-02-08 16:46 ` [PATCH 1/5] framework/dut: add support for restoring dual-port NIC with single PCI address Niklas Söderlund
2023-02-08 16:46 ` [PATCH 2/5] framework/dut: only map ports not already matched Niklas Söderlund
2023-02-08 16:46 ` [PATCH 3/5] nics/net_device: add support for dual-port nfp NIC with single PCI address Niklas Söderlund
2023-02-08 16:46 ` [PATCH 4/5] framework/dut: add longer timeout for loading driver and firmware Niklas Söderlund
2023-02-08 16:46 ` [PATCH 5/5] framework/setting: enable Corigine and Netronome NIC for dts Niklas Söderlund
2023-02-09 15:27 ` [PATCH v2 0/5] Add initial support for NFP PMD Niklas Söderlund
2023-02-09 15:27   ` [PATCH v2 1/5] framework/dut: add support for restoring dual-port NIC with single PCI address Niklas Söderlund
2023-02-09 15:27   ` [PATCH v2 2/5] framework/dut: only map ports not already matched Niklas Söderlund
2023-02-09 15:27   ` [PATCH v2 3/5] nics/net_device: add support for dual-port nfp NIC with single PCI address Niklas Söderlund
2023-02-09 15:27   ` Niklas Söderlund [this message]
2023-02-09 15:27   ` [PATCH v2 5/5] framework/setting: enable Corigine and Netronome NIC for dts Niklas Söderlund
2023-03-06 13:06   ` [PATCH v2 0/5] Add initial support for NFP PMD Niklas Söderlund
2023-03-07  3:35   ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230209152717.4057220-5-niklas.soderlund@corigine.com \
    --to=niklas.soderlund@corigine.com \
    --cc=chaoyong.he@corigine.com \
    --cc=dts@dpdk.org \
    --cc=oss-drivers@corigine.com \
    --cc=qin.ke@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).