test suite reviews and discussions
 help / color / mirror / Atom feed
From: Ke Xu <ke1.xu@intel.com>
To: dts@dpdk.org
Cc: ke1.xu@intel.com, qi.fu@intel.com, lijuan.tu@intel.com,
	yux.jiang@intel.com, zhiminx.huang@intel.com
Subject: [DTS][PATCH V3 3/5] tests/vf_offload: improve vector path validating.
Date: Mon, 13 Feb 2023 16:39:50 +0800	[thread overview]
Message-ID: <20230213083952.1350755-4-ke1.xu@intel.com> (raw)
In-Reply-To: <20230213083952.1350755-1-ke1.xu@intel.com>

For better deployment for daily regression, we introduce
 a wrapper to add cases for each path. Based on it,
 we add seperate cases for regression.

Signed-off-by: Ke Xu <ke1.xu@intel.com>
---
 tests/TestSuite_vf_offload.py | 176 ++++++++++++++++++++++++++++++++--
 1 file changed, 168 insertions(+), 8 deletions(-)

diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py
index c2ca0027..381f110c 100644
--- a/tests/TestSuite_vf_offload.py
+++ b/tests/TestSuite_vf_offload.py
@@ -185,11 +185,13 @@ class TestVfOffload(TestCase):
 
     def launch_testpmd(self, **kwargs):
         dcf_flag = kwargs.get("dcf_flag")
+        eal_param = kwargs.get("eal_param") if kwargs.get("eal_param") else ""
         param = kwargs.get("param") if kwargs.get("param") else ""
         if dcf_flag == "enable":
             self.vm0_testpmd.start_testpmd(
                 VM_CORES_MASK,
                 param=param,
+                eal_param=eal_param,
                 ports=[self.vf0_guest_pci, self.vf1_guest_pci],
                 port_options={
                     self.vf0_guest_pci: "cap=dcf",
@@ -197,7 +199,11 @@ class TestVfOffload(TestCase):
                 },
             )
         else:
-            self.vm0_testpmd.start_testpmd(VM_CORES_MASK, param=param)
+            self.vm0_testpmd.start_testpmd(
+                VM_CORES_MASK,
+                param=param,
+                eal_param=eal_param,
+            )
 
     def checksum_enablehw(self, port, dut):
         dut.send_expect("port stop all", "testpmd>")
@@ -336,7 +342,7 @@ class TestVfOffload(TestCase):
                 )
         return result
 
-    def test_checksum_offload_enable(self):
+    def exec_checksum_offload_enable(self, specific_bitwidth=None):
         """
         Enable HW checksum offload.
         Send packet with incorrect checksum,
@@ -346,6 +352,13 @@ class TestVfOffload(TestCase):
         self.launch_testpmd(
             dcf_flag=self.dcf_mode,
             param="--portmask=%s " % (self.portMask) + "--enable-rx-cksum " + "",
+            eal_param=(
+                "--force-max-simd-bitwidth=%d " % specific_bitwidth
+                + "--log-level='iavf,7' "
+                + "--log-level='dcf,7' "
+            )
+            if (not specific_bitwidth is None)
+            else "",
         )
         self.vm0_testpmd.execute_cmd("set fwd csum")
         self.vm0_testpmd.execute_cmd("csum mac-swap off 0", "testpmd>")
@@ -400,7 +413,7 @@ class TestVfOffload(TestCase):
 
         self.verify(len(result) == 0, ",".join(list(result.values())))
 
-    def test_checksum_offload_vlan_enable(self):
+    def exec_checksum_offload_vlan_enable(self, specific_bitwidth=None):
         """
         Enable HW checksum offload.
         Send packet with incorrect checksum,
@@ -410,6 +423,13 @@ class TestVfOffload(TestCase):
         self.launch_testpmd(
             dcf_flag=self.dcf_mode,
             param="--portmask=%s " % (self.portMask) + "--enable-rx-cksum " + "",
+            eal_param=(
+                "--force-max-simd-bitwidth=%d " % specific_bitwidth
+                + "--log-level='iavf,7' "
+                + "--log-level='dcf,7' "
+            )
+            if (not specific_bitwidth is None)
+            else "",
         )
         self.vm0_testpmd.execute_cmd("set fwd csum")
         self.vm0_testpmd.execute_cmd("csum mac-swap off 0", "testpmd>")
@@ -468,7 +488,7 @@ class TestVfOffload(TestCase):
         ["ICE_100G-E810C_QSFP", "ICE_25G-E810C_SFP", "ICE_25G-E810_XXV_SFP"]
     )
     @skip_unsupported_pkg(["os default"])
-    def test_checksum_offload_tunnel_enable(self):
+    def exec_checksum_offload_tunnel_enable(self, specific_bitwidth=None):
         """
         Enable HW checksum offload.
         Send packet with inner and outer incorrect checksum,
@@ -478,6 +498,13 @@ class TestVfOffload(TestCase):
         self.launch_testpmd(
             dcf_flag=self.dcf_mode,
             param="--portmask=%s " % (self.portMask) + "--enable-rx-cksum " + "",
+            eal_param=(
+                "--force-max-simd-bitwidth=%d " % specific_bitwidth
+                + "--log-level='iavf,7' "
+                + "--log-level='dcf,7' "
+            )
+            if (not specific_bitwidth is None)
+            else "",
         )
         self.vm0_testpmd.execute_cmd("set fwd csum")
         self.vm0_testpmd.execute_cmd("set promisc 1 on")
@@ -612,7 +639,7 @@ class TestVfOffload(TestCase):
         ["ICE_100G-E810C_QSFP", "ICE_25G-E810C_SFP", "ICE_25G-E810_XXV_SFP"]
     )
     @skip_unsupported_pkg(["os default"])
-    def test_checksum_offload_vlan_tunnel_enable(self):
+    def exec_checksum_offload_vlan_tunnel_enable(self, specific_bitwidth=None):
         """
         Enable HW checksum offload.
         Send packet with inner and outer incorrect checksum,
@@ -622,6 +649,13 @@ class TestVfOffload(TestCase):
         self.launch_testpmd(
             dcf_flag=self.dcf_mode,
             param="--portmask=%s " % (self.portMask) + "--enable-rx-cksum " + "",
+            eal_param=(
+                "--force-max-simd-bitwidth=%d " % specific_bitwidth
+                + "--log-level='iavf,7' "
+                + "--log-level='dcf,7' "
+            )
+            if (not specific_bitwidth is None)
+            else "",
         )
         self.vm0_testpmd.execute_cmd("set fwd csum")
         self.vm0_testpmd.execute_cmd("set promisc 1 on")
@@ -752,7 +786,7 @@ class TestVfOffload(TestCase):
 
         self.verify(len(result) == 0, ",".join(list(result.values())))
 
-    def test_checksum_offload_disable(self):
+    def exec_checksum_offload_disable(self, specific_bitwidth=None):
         """
         Enable SW checksum offload.
         Send same packet with incorrect checksum and verify checksum is valid.
@@ -761,6 +795,13 @@ class TestVfOffload(TestCase):
         self.launch_testpmd(
             dcf_flag=self.dcf_mode,
             param="--portmask=%s " % (self.portMask) + "--enable-rx-cksum " + "",
+            eal_param=(
+                "--force-max-simd-bitwidth=%d " % specific_bitwidth
+                + "--log-level='iavf,7' "
+                + "--log-level='dcf,7' "
+            )
+            if (not specific_bitwidth is None)
+            else "",
         )
         self.vm0_testpmd.execute_cmd("set fwd csum")
         self.vm0_testpmd.execute_cmd("csum mac-swap off 0", "testpmd>")
@@ -812,6 +853,81 @@ class TestVfOffload(TestCase):
 
         self.verify(len(result) == 0, ",".join(list(result.values())))
 
+    def test_checksum_offload_enable(self):
+        self.exec_checksum_offload_enable()
+
+    def test_checksum_offload_enable_scalar(self):
+        self.exec_checksum_offload_enable(specific_bitwidth=64)
+
+    def test_checksum_offload_enable_sse(self):
+        self.exec_checksum_offload_enable(specific_bitwidth=128)
+
+    def test_checksum_offload_enable_avx2(self):
+        self.exec_checksum_offload_enable(specific_bitwidth=256)
+
+    def test_checksum_offload_enable_avx512(self):
+        self.exec_checksum_offload_enable(specific_bitwidth=512)
+
+    def test_checksum_offload_vlan_enable(self):
+        self.exec_checksum_offload_vlan_enable()
+
+    def test_checksum_offload_vlan_enable_scalar(self):
+        self.exec_checksum_offload_vlan_enable(specific_bitwidth=64)
+
+    def test_checksum_offload_vlan_enable_sse(self):
+        self.exec_checksum_offload_vlan_enable(specific_bitwidth=128)
+
+    def test_checksum_offload_vlan_enable_avx2(self):
+        self.exec_checksum_offload_vlan_enable(specific_bitwidth=256)
+
+    def test_checksum_offload_vlan_enable_avx512(self):
+        self.exec_checksum_offload_vlan_enable(specific_bitwidth=512)
+
+    def test_checksum_offload_tunnel_enable(self):
+        self.exec_checksum_offload_tunnel_enable()
+
+    def test_checksum_offload_tunnel_enable_scalar(self):
+        self.exec_checksum_offload_tunnel_enable(specific_bitwidth=64)
+
+    def test_checksum_offload_tunnel_enable_sse(self):
+        self.exec_checksum_offload_tunnel_enable(specific_bitwidth=128)
+
+    def test_checksum_offload_tunnel_enable_avx2(self):
+        self.exec_checksum_offload_tunnel_enable(specific_bitwidth=256)
+
+    def test_checksum_offload_tunnel_enable_avx512(self):
+        self.exec_checksum_offload_tunnel_enable(specific_bitwidth=512)
+
+    def test_checksum_offload_vlan_tunnel_enable(self):
+        self.exec_checksum_offload_vlan_tunnel_enable()
+
+    def test_checksum_offload_vlan_tunnel_enable_scalar(self):
+        self.exec_checksum_offload_vlan_tunnel_enable(specific_bitwidth=64)
+
+    def test_checksum_offload_vlan_tunnel_enable_sse(self):
+        self.exec_checksum_offload_vlan_tunnel_enable(specific_bitwidth=128)
+
+    def test_checksum_offload_vlan_tunnel_enable_avx2(self):
+        self.exec_checksum_offload_vlan_tunnel_enable(specific_bitwidth=256)
+
+    def test_checksum_offload_vlan_tunnel_enable_avx512(self):
+        self.exec_checksum_offload_vlan_tunnel_enable(specific_bitwidth=512)
+
+    def test_checksum_offload_disable(self):
+        self.exec_checksum_offload_disable()
+
+    def test_checksum_offload_disable_scalar(self):
+        self.exec_checksum_offload_disable(specific_bitwidth=64)
+
+    def test_checksum_offload_disable_sse(self):
+        self.exec_checksum_offload_disable(specific_bitwidth=128)
+
+    def test_checksum_offload_disable_avx2(self):
+        self.exec_checksum_offload_disable(specific_bitwidth=256)
+
+    def test_checksum_offload_disable_avx512(self):
+        self.exec_checksum_offload_disable(specific_bitwidth=512)
+
     def tcpdump_start_sniffing(self, ifaces=[]):
         """
         Start tcpdump in the background to sniff the tester interface where
@@ -1010,7 +1126,7 @@ class TestVfOffload(TestCase):
                     validate_result.append(result_message)
         return validate_result
 
-    def test_tso(self):
+    def exec_tso(self, specific_bitwidth=None):
         """
         TSO IPv4 TCP, IPv6 TCP testing.
         """
@@ -1052,6 +1168,13 @@ class TestVfOffload(TestCase):
             param="--portmask=0x3 "
             + "--enable-rx-cksum "
             + "--max-pkt-len=%s" % TSO_MTU,
+            eal_param=(
+                "--force-max-simd-bitwidth=%d " % specific_bitwidth
+                + "--log-level='iavf,7' "
+                + "--log-level='dcf,7' "
+            )
+            if (not specific_bitwidth is None)
+            else "",
         )
 
         mac = self.vm0_testpmd.get_port_mac(0)
@@ -1086,7 +1209,7 @@ class TestVfOffload(TestCase):
         ["ICE_100G-E810C_QSFP", "ICE_25G-E810C_SFP", "ICE_25G-E810_XXV_SFP"]
     )
     @skip_unsupported_pkg(["os default"])
-    def test_tso_tunnel(self):
+    def exec_tso_tunnel(self, specific_bitwidth=None):
         """
         TSO tunneled IPv4 TCP, IPv6 TCP testing.
         """
@@ -1128,6 +1251,13 @@ class TestVfOffload(TestCase):
             param="--portmask=0x3 "
             + "--enable-rx-cksum "
             + "--max-pkt-len=%s" % TSO_MTU,
+            eal_param=(
+                "--force-max-simd-bitwidth=%d " % specific_bitwidth
+                + "--log-level='iavf,7' "
+                + "--log-level='dcf,7' "
+            )
+            if (not specific_bitwidth is None)
+            else "",
         )
 
         mac = self.vm0_testpmd.get_port_mac(0)
@@ -1179,6 +1309,36 @@ class TestVfOffload(TestCase):
         )
         self.verify(len(validate_result) == 0, ",".join(list(validate_result)))
 
+    def test_tso(self):
+        self.exec_tso()
+
+    def test_tso_scalar(self):
+        self.exec_tso(specific_bitwidth=64)
+
+    def test_tso_sse(self):
+        self.exec_tso(specific_bitwidth=128)
+
+    def test_tso_avx2(self):
+        self.exec_tso(specific_bitwidth=256)
+
+    def test_tso_avx512(self):
+        self.exec_tso(specific_bitwidth=512)
+
+    def test_tso_tunnel(self):
+        self.exec_tso_tunnel()
+
+    def test_tso_tunnel_scalar(self):
+        self.exec_tso_tunnel(specific_bitwidth=64)
+
+    def test_tso_sse(self):
+        self.exec_tso_tunnel(specific_bitwidth=128)
+
+    def test_tso_avx2(self):
+        self.exec_tso_tunnel(specific_bitwidth=256)
+
+    def test_tso_avx512(self):
+        self.exec_tso_tunnel(specific_bitwidth=512)
+
     def tear_down(self):
         self.vm0_testpmd.execute_cmd("quit", "# ")
         self.dut.send_expect(
-- 
2.25.1


  parent reply	other threads:[~2023-02-13  8:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13  8:39 [DTS][PATCH V3 0/5] Update vf_offload cases for DPDK-v23.03 validation Ke Xu
2023-02-13  8:39 ` [DTS][PATCH V3 1/5] tests/vf_offload: add VLAN packets to test scope Ke Xu
2023-02-13  8:39 ` [DTS][PATCH V3 2/5] tests/vf_offload: improve TSO validating Ke Xu
2023-02-13  8:39 ` Ke Xu [this message]
2023-02-13  8:39 ` [DTS][PATCH V3 4/5] tests/vf_offload: fix error when no packet captured Ke Xu
2023-02-13  8:39 ` [DTS][PATCH V3 5/5] test_plans/vf_offload: add VLAN packets to test scope and improve vector path validating Ke Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230213083952.1350755-4-ke1.xu@intel.com \
    --to=ke1.xu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=qi.fu@intel.com \
    --cc=yux.jiang@intel.com \
    --cc=zhiminx.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).