test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jiale Song <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Jiale Song <songx.jiale@intel.com>
Subject: [dts] [PATCH V1] tests/iavf_rss_protocol_agnostic_flow: optimize script
Date: Fri, 24 Feb 2023 16:51:50 +0000	[thread overview]
Message-ID: <20230224165150.1437970-1-songx.jiale@intel.com> (raw)

the correct error information is not obtained.the error message comes 
from "rte_flow_common.RssProcessing.error_msgs"."self.error_msgs" does 
not get the corresponding error message.

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 tests/TestSuite_iavf_rss_protocol_agnostic_flow.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_iavf_rss_protocol_agnostic_flow.py b/tests/TestSuite_iavf_rss_protocol_agnostic_flow.py
index 1a6fb2c3..e8d8d58f 100644
--- a/tests/TestSuite_iavf_rss_protocol_agnostic_flow.py
+++ b/tests/TestSuite_iavf_rss_protocol_agnostic_flow.py
@@ -484,7 +484,6 @@ class TestIavfRssProtocolAgnosticFlow(TestCase):
     def handle_rss_case(self, case_info):
         # clear hash_records before each sub case
         self.hash_records = {}
-        self.error_msgs = []
         self.current_saved_hash = ""
         sub_case_name = case_info.get("sub_casename")
         self.logger.info(
@@ -516,10 +515,12 @@ class TestIavfRssProtocolAgnosticFlow(TestCase):
             self.rsspro.destroy_rule(port_id=port_id, rule_id=rule_ids)
             self.rsspro.check_rule(port_id=port_id, stats=False)
             self.rsspro.handle_tests(case_info["post-test"], port_id=port_id)
-        if self.error_msgs:
+        if self.rsspro.error_msgs:
             self.verify(
                 False,
-                " ".join([errs.replace("'", " ") for errs in self.error_msgs[:500]]),
+                " ".join(
+                    [errs.replace("'", " ") for errs in self.rsspro.error_msgs[:500]]
+                ),
             )
 
     def rte_flow(self, case_list, func_name, **kwargs):
@@ -643,7 +644,6 @@ class TestIavfRssProtocolAgnosticFlow(TestCase):
         # create rule
         self.rsspro.create_rule(rules, check_stats=True)
         self.rsspro.error_msgs = []
-        self.rsspro.error_msgs = []
         self.handle_tests(tests, port_id=dPort, tport_id=tPort)
         if self.rsspro.error_msgs:
             self.verify(
-- 
2.25.1


             reply	other threads:[~2023-02-24  8:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-24 16:51 Jiale Song [this message]
2023-03-07  3:55 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230224165150.1437970-1-songx.jiale@intel.com \
    --to=songx.jiale@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).