test suite reviews and discussions
 help / color / mirror / Atom feed
From: Song Jiale <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Song Jiale <songx.jiale@intel.com>
Subject: [dts] [PATCH V2] tests/vf_offload: optimize script
Date: Mon, 27 Mar 2023 17:36:50 +0000	[thread overview]
Message-ID: <20230327173650.780985-1-songx.jiale@intel.com> (raw)

in general, vfs do not need to enable trust on. some intree drivers have
a issue that vfs with trust on cannot receive vf vlan packets, and
this issue will not be fixed. in order not to affect subsequent case
testing, do not enable trust on unnecessarily.

Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 tests/TestSuite_vf_offload.py | 29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)

V2:
-modify the comment description

diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py
index 9475ef22..47f6351b 100644
--- a/tests/TestSuite_vf_offload.py
+++ b/tests/TestSuite_vf_offload.py
@@ -91,20 +91,21 @@ class TestVfOffload(TestCase):
         self.host_intf_0 = self.dut.ports_info[self.used_dut_port_0]["intf"]
         self.host_intf_1 = self.dut.ports_info[self.used_dut_port_1]["intf"]
 
-        self.ip_link_set(
-            host_intf=self.host_intf_0,
-            cmd="vf",
-            port=0,
-            types="trust",
-            value="on",
-        )
-        self.ip_link_set(
-            host_intf=self.host_intf_1,
-            cmd="vf",
-            port=0,
-            types="trust",
-            value="on",
-        )
+        if self.dcf_mode:
+            self.ip_link_set(
+                host_intf=self.host_intf_0,
+                cmd="vf",
+                port=0,
+                types="trust",
+                value="on",
+            )
+            self.ip_link_set(
+                host_intf=self.host_intf_1,
+                cmd="vf",
+                port=0,
+                types="trust",
+                value="on",
+            )
         self.ip_link_set(
             host_intf=self.host_intf_0,
             cmd="vf",
-- 
2.25.1


             reply	other threads:[~2023-03-27  9:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-27 17:36 Song Jiale [this message]
2023-03-28  1:24 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230327173650.780985-1-songx.jiale@intel.com \
    --to=songx.jiale@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).