test suite reviews and discussions
 help / color / mirror / Atom feed
From: Dukai Yuan <dukaix.yuan@intel.com>
To: dts@dpdk.org
Cc: Dukai Yuan <dukaix.yuan@intel.com>
Subject: [dts][PATCH V1] tests/vm2vm_virtio_net_perf_cbdma & vswitch_sample_cbdma: Optimize the Secure Copy file size
Date: Wed, 26 Apr 2023 18:22:56 +0800	[thread overview]
Message-ID: <20230426102256.23323-1-dukaix.yuan@intel.com> (raw)

Secure Copy (scp) is used to verify whether the vm2vm established connection successful.
1MB file size is too small, which may cause verification failure.
So,change file size from 1MB to 10MB.

Signed-off-by: Dukai Yuan <dukaix.yuan@intel.com>
---
 .../TestSuite_vm2vm_virtio_net_perf_cbdma.py  | 28 +++++++++----------
 tests/TestSuite_vswitch_sample_cbdma.py       |  2 +-
 tests/virtio_common.py                        |  4 +--
 3 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/tests/TestSuite_vm2vm_virtio_net_perf_cbdma.py b/tests/TestSuite_vm2vm_virtio_net_perf_cbdma.py
index 8fece79f..176a25af 100644
--- a/tests/TestSuite_vm2vm_virtio_net_perf_cbdma.py
+++ b/tests/TestSuite_vm2vm_virtio_net_perf_cbdma.py
@@ -475,7 +475,7 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.BC.config_2_vms_ip()
         self.BC.config_2_vms_combined(combined=8)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
 
@@ -528,7 +528,7 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         )
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
@@ -547,7 +547,7 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         )
         self.BC.config_2_vms_combined(combined=8)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
 
@@ -741,7 +741,7 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.BC.config_2_vms_ip()
         self.BC.config_2_vms_combined(combined=16)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
 
@@ -871,12 +871,12 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.BC.config_2_vms_ip()
         self.BC.config_2_vms_combined(combined=8)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
@@ -961,12 +961,12 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.BC.config_2_vms_ip()
         self.BC.config_2_vms_combined(combined=8)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
@@ -1143,12 +1143,12 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.BC.config_2_vms_ip()
         self.BC.config_2_vms_combined(combined=16)
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
@@ -1180,12 +1180,12 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.start_vms(server_mode=False, vm_queue=1)
         self.BC.config_2_vms_ip()
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
@@ -1269,12 +1269,12 @@ class TestVM2VMVirtioNetPerfCbdma(TestCase):
         self.start_vms(server_mode=False, vm_queue=8)
         self.BC.config_2_vms_ip()
         self.BC.check_ping_between_2_vms()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         self.BC.check_iperf_result_between_2_vms()
         for _ in range(5):
             self.BC.check_ping_between_2_vms()
-            self.BC.check_scp_file_between_2_vms(file_size=1)
+            self.BC.check_scp_file_between_2_vms(file_size=10)
             self.BC.run_iperf_test_between_2_vms()
             self.BC.check_iperf_result_between_2_vms()
 
diff --git a/tests/TestSuite_vswitch_sample_cbdma.py b/tests/TestSuite_vswitch_sample_cbdma.py
index 783275f2..feb3b4f2 100644
--- a/tests/TestSuite_vswitch_sample_cbdma.py
+++ b/tests/TestSuite_vswitch_sample_cbdma.py
@@ -649,7 +649,7 @@ class TestVswitchSampleCBDMA(TestCase):
             self.vm0_pmd = PmdOutput(self.vm_dut[0])
             self.vm1_pmd = PmdOutput(self.vm_dut[1])
             self.BC.config_2_vms_ip()
-        self.BC.check_scp_file_between_2_vms(file_size=1)
+        self.BC.check_scp_file_between_2_vms(file_size=10)
         self.BC.run_iperf_test_between_2_vms()
         iperfdata = self.BC.check_iperf_result_between_2_vms()
         return iperfdata
diff --git a/tests/virtio_common.py b/tests/virtio_common.py
index cf1bbe43..eec8999b 100644
--- a/tests/virtio_common.py
+++ b/tests/virtio_common.py
@@ -87,7 +87,7 @@ class basic_common(object):
         fp.write(data)
         fp.close()
 
-        # scp file from tester on VM0
+        # scp file from tester to VM0
         out = self.test_case.vm_dut[0].send_command(
             "scp root@%s:/tmp/payload /tmp" % self.tester_ip, timeout=5
         )
@@ -95,7 +95,7 @@ class basic_common(object):
             self.test_case.vm_dut[0].send_command("yes", timeout=3)
         self.test_case.vm_dut[0].send_command(self.tester_passwd, timeout=3)
 
-        # scp file from VM0 on VM1
+        # scp file from VM0 to VM1
         out = self.test_case.vm_dut[1].send_command(
             "scp root@%s:/tmp/payload /tmp" % self.vm0_ip, timeout=5
         )
-- 
2.17.1


             reply	other threads:[~2023-04-26 10:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-26 10:22 Dukai Yuan [this message]
2023-04-27 10:06 ` Ling, WeiX
2023-04-28  0:40 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230426102256.23323-1-dukaix.yuan@intel.com \
    --to=dukaix.yuan@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).