test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1] tests/telemetry: Optimize the parameter for function json.load
@ 2023-05-26 14:08 Dukai Yuan
  2023-06-07  5:53 ` lijuan.tu
  0 siblings, 1 reply; 2+ messages in thread
From: Dukai Yuan @ 2023-05-26 14:08 UTC (permalink / raw)
  To: dts; +Cc: Dukai Yuan

In Python 3.10, the json.load() function removed the encoding parameter, 
because in Python 3, the json module uses UTF-8 encoding by default to process JSON data. 
As such, the encoding argument is no longer required, and has been removed in Python 3.10. 
If you need to specify other encoding methods, 
you can use the encoding parameter in the open() function to specify.
Please refer to the Python official documentation for more details. 
https://docs.python.org/3/library/json.html

Signed-off-by: Dukai Yuan <dukaix.yuan@intel.com>
---
 tests/TestSuite_telemetry.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_telemetry.py b/tests/TestSuite_telemetry.py
index ca2d74f5..b7593cb7 100644
--- a/tests/TestSuite_telemetry.py
+++ b/tests/TestSuite_telemetry.py
@@ -270,9 +270,9 @@ class TestTelemetry(TestCase):
         self.dut.session.copy_file_from(json_file, dst_file)
         msg = "failed to get {}".format(json_name)
         self.verify(os.path.exists(dst_file), msg)
-        with open(dst_file, "r") as fp:
+        with open(dst_file, "r", encoding="utf-8") as fp:
             try:
-                query_data = json.load(fp, encoding="utf-8")
+                query_data = json.load(fp)
             except Exception as e:
                 msg = "failed to load metrics json data"
                 self.verify(False, msg)
-- 
2.31.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dts][PATCH V1] tests/telemetry: Optimize the parameter for function json.load
  2023-05-26 14:08 [dts][PATCH V1] tests/telemetry: Optimize the parameter for function json.load Dukai Yuan
@ 2023-06-07  5:53 ` lijuan.tu
  0 siblings, 0 replies; 2+ messages in thread
From: lijuan.tu @ 2023-06-07  5:53 UTC (permalink / raw)
  To: dts, Dukai Yuan; +Cc: Dukai Yuan

On Fri, 26 May 2023 14:08:12 +0000, Dukai Yuan <dukaix.yuan@intel.com> wrote:
> In Python 3.10, the json.load() function removed the encoding parameter, 
> because in Python 3, the json module uses UTF-8 encoding by default to process JSON data. 
> As such, the encoding argument is no longer required, and has been removed in Python 3.10. 
> If you need to specify other encoding methods, 
> you can use the encoding parameter in the open() function to specify.
> Please refer to the Python official documentation for more details. 
> https://docs.python.org/3/library/json.html
> 
> Signed-off-by: Dukai Yuan <dukaix.yuan@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-07  5:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-26 14:08 [dts][PATCH V1] tests/telemetry: Optimize the parameter for function json.load Dukai Yuan
2023-06-07  5:53 ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).