From: Jiale Song <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Jiale Song <songx.jiale@intel.com>
Subject: [dts] [PATCH V1] tests/vf_pmd_stacked_bonded: optimize scripts
Date: Fri, 30 Jun 2023 23:19:43 +0800 [thread overview]
Message-ID: <20230630151943.103932-1-songx.jiale@intel.com> (raw)
when rebinding the network card to the kdriver, the network card link
status is down, and the network card should be up first before checking
the status.
Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
tests/TestSuite_vf_pmd_stacked_bonded.py | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tests/TestSuite_vf_pmd_stacked_bonded.py b/tests/TestSuite_vf_pmd_stacked_bonded.py
index 4c3fe634..f330db55 100644
--- a/tests/TestSuite_vf_pmd_stacked_bonded.py
+++ b/tests/TestSuite_vf_pmd_stacked_bonded.py
@@ -445,11 +445,10 @@ class TestVfPmdStackedBonded(TestCase):
Run before each test case.
"""
self.create_vfs(pf_list=self.dut_ports, vf_num=1)
- port0_stats = self.dut.is_interface_up(self.dport_ifaces_port0)
- port1_stats = self.dut.is_interface_up(self.dport_ifaces_port1)
- if not all([port0_stats, port1_stats]):
- self.dut.send_expect(f"ip link set {self.dport_ifaces_port0} up", "# ")
- self.dut.send_expect(f"ip link set {self.dport_ifaces_port1} up", "# ")
+ self.dut.send_expect(f"ip link set {self.dport_ifaces_port0} up", "# ")
+ self.dut.send_expect(f"ip link set {self.dport_ifaces_port1} up", "# ")
+ self.dut.is_interface_up(self.dport_ifaces_port0)
+ self.dut.is_interface_up(self.dport_ifaces_port1)
self.eal_param = ""
for pci in self.vfs_pci:
self.eal_param += " -a %s" % pci
--
2.25.1
reply other threads:[~2023-06-30 7:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630151943.103932-1-songx.jiale@intel.com \
--to=songx.jiale@intel.com \
--cc=dts@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).