[PATCH] tests/compress_common: replace coremask with corelist in compress_common

[PATCH] tests/compress_common: replace coremask with corelist in compress_common

[Manit Mahajan]

The compress_common.py script previously used the --coremask parameter,
which has been removed from DPDK. As a result, zlib_pmd test cases
fail when invoking this script. This patch updates the script to
use the --corelist parameter instead, which is the more common
way to specify core assignment in DPDK.

Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
---
 tests/compress_common.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tests/compress_common.py b/tests/compress_common.py
index aa591270..22ce4b74 100644
--- a/tests/compress_common.py
+++ b/tests/compress_common.py
@@ -94,12 +94,14 @@ def get_input_file(test_case):
 
 def run_unit(test_case, eal={}):
     cores = test_case.dut.get_core_list("1S/3C/1T")
-    core_mask = utils.create_mask(cores)
+    core_list = []
+    for core in cores:
+        core_list.append(str(core))
+    core_str = ",".join(core_list)
     mem_channels = test_case.dut.get_memory_channels()
 
     default = default_eals.copy()
-    default["l"] = None
-    default["c"] = core_mask
+    default["l"] = core_str
     default["n"] = mem_channels
 
     eal_str = get_opt_str(test_case, default, eal)
-- 
2.41.0

Re: [PATCH] tests/compress_common: replace coremask with corelist in compress_common

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 1709 bytes --]

This seems fine in principle.

Did you ever figure out why the compressdev_autotest was failing with
coremask used in the first place? I haven't looked at the coremask
deprecation patch that you had found, but David said on slack that it
didn't remove the option to use the coremask EAL arg, it just discourages
it with a warning.

On Fri, Jul 11, 2025 at 4:32 PM Manit Mahajan <mmahajan@iol.unh.edu> wrote:

> The compress_common.py script previously used the --coremask parameter,
> which has been removed from DPDK. As a result, zlib_pmd test cases
> fail when invoking this script. This patch updates the script to
> use the --corelist parameter instead, which is the more common
> way to specify core assignment in DPDK.
>
> Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
> ---
>  tests/compress_common.py | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/tests/compress_common.py b/tests/compress_common.py
> index aa591270..22ce4b74 100644
> --- a/tests/compress_common.py
> +++ b/tests/compress_common.py
> @@ -94,12 +94,14 @@ def get_input_file(test_case):
>
>  def run_unit(test_case, eal={}):
>      cores = test_case.dut.get_core_list("1S/3C/1T")
> -    core_mask = utils.create_mask(cores)
> +    core_list = []
> +    for core in cores:
> +        core_list.append(str(core))
> +    core_str = ",".join(core_list)
>      mem_channels = test_case.dut.get_memory_channels()
>
>      default = default_eals.copy()
> -    default["l"] = None
> -    default["c"] = core_mask
> +    default["l"] = core_str
>      default["n"] = mem_channels
>
>      eal_str = get_opt_str(test_case, default, eal)
> --
> 2.41.0
>
>

[-- Attachment #2: Type: text/html, Size: 2273 bytes --]

Re: [PATCH] tests/compress_common: replace coremask with corelist in compress_common

[David Marchand]

Hello,

On Fri, Jul 11, 2025 at 11:36 PM Patrick Robb <probb@iol.unh.edu> wrote:
>
> This seems fine in principle.
>
> Did you ever figure out why the compressdev_autotest was failing with coremask used in the first place? I haven't looked at the coremask deprecation patch that you had found, but David said on slack that it didn't remove the option to use the coremask EAL arg, it just discourages it with a warning.
>
> On Fri, Jul 11, 2025 at 4:32 PM Manit Mahajan <mmahajan@iol.unh.edu> wrote:
>>
>> The compress_common.py script previously used the --coremask parameter,
>> which has been removed from DPDK. As a result, zlib_pmd test cases
>> fail when invoking this script. This patch updates the script to

There is no --coremask EAL option.
And the option -c was not removed.

Please refine the rca.

>> use the --corelist parameter instead, which is the more common
>> way to specify core assignment in DPDK.

There is no --corelist EAL option.

Only -c, -l and --lcores exist atm.


-- 
David Marchand

Re: [PATCH] tests/compress_common: replace coremask with corelist in compress_common

[Manit Mahajan]

[-- Attachment #1: Type: text/plain, Size: 1701 bytes --]

Hi,

Thanks for the clarification. I had misunderstood the patch that added the
coremask warning and incorrectly assumed that -c was deprecated. Upon
closer review, I see that the patch only adds warning logs when using
coremask but does not deprecate the -c option. The actual problem is that
the warning message includes a '>', which causes send_expect('>') to return
prematurely and miss important test output. I will address this in v2 by
changing the expected prompt to 'RTE>'.


On Tue, Jul 15, 2025 at 3:42 AM David Marchand <david.marchand@redhat.com>
wrote:

> Hello,
>
> On Fri, Jul 11, 2025 at 11:36 PM Patrick Robb <probb@iol.unh.edu> wrote:
> >
> > This seems fine in principle.
> >
> > Did you ever figure out why the compressdev_autotest was failing with
> coremask used in the first place? I haven't looked at the coremask
> deprecation patch that you had found, but David said on slack that it
> didn't remove the option to use the coremask EAL arg, it just discourages
> it with a warning.
> >
> > On Fri, Jul 11, 2025 at 4:32 PM Manit Mahajan <mmahajan@iol.unh.edu>
> wrote:
> >>
> >> The compress_common.py script previously used the --coremask parameter,
> >> which has been removed from DPDK. As a result, zlib_pmd test cases
> >> fail when invoking this script. This patch updates the script to
>
> There is no --coremask EAL option.
> And the option -c was not removed.
>
> Please refine the rca.
>
> >> use the --corelist parameter instead, which is the more common
> >> way to specify core assignment in DPDK.
>
> There is no --corelist EAL option.
>
> Only -c, -l and --lcores exist atm.
>
>
> --
> David Marchand
>
>

[-- Attachment #2: Type: text/html, Size: 2286 bytes --]

[PATCH v2] compress: resolve test failure from incomplete output capture

[Manit Mahajan]

The compress unit test uses send_expect() with '>' to determine
when the command completed. A recent patch introduced a
deprecation warning for coremask, which includes a '>' in the
output. This causes send_expect() to exit early,
resulting in missed test output, leading to false failures.

This is fixed by changing the expected termination prompt from
'>' to 'RTE>'. This change address issues from the v1 patch,
which incorrectly modified the EAL option from coremask to
corelist.

Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
---
 tests/compress_common.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/compress_common.py b/tests/compress_common.py
index aa591270..b4fd1921 100644
--- a/tests/compress_common.py
+++ b/tests/compress_common.py
@@ -106,8 +106,8 @@ def run_unit(test_case, eal={}):
     cmdline = "./{app_path} {eal}".format(
         app_path=test_case.dut.apps_name["test"], eal=eal_str
     )
-    test_case.dut.send_expect(cmdline, ">", 30)
-    out = test_case.dut.send_expect("compressdev_autotest", ">", 30)
+    test_case.dut.send_expect(cmdline, "RTE>", 30)
+    out = test_case.dut.send_expect("compressdev_autotest", "RTE>", 30)
     test_case.dut.send_expect("quit", "# ", 30)
     print(out)
 
-- 
2.41.0

Re: [PATCH v2] compress: resolve test failure from incomplete output capture

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 1627 bytes --]

Thanks. So, if we change the expect string to "RTE>", the warning will not
trigger the expect and unit tests will complete before the execution
proceeds? Sounds good.

On Wed, Jul 16, 2025 at 3:24 PM Manit Mahajan <mmahajan@iol.unh.edu> wrote:

> The compress unit test uses send_expect() with '>' to determine
> when the command completed. A recent patch introduced a
> deprecation warning for coremask, which includes a '>' in the
> output. This causes send_expect() to exit early,
> resulting in missed test output, leading to false failures.
>
> This is fixed by changing the expected termination prompt from
> '>' to 'RTE>'. This change address issues from the v1 patch,
> which incorrectly modified the EAL option from coremask to
> corelist.
>
> Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
> ---
>  tests/compress_common.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/compress_common.py b/tests/compress_common.py
> index aa591270..b4fd1921 100644
> --- a/tests/compress_common.py
> +++ b/tests/compress_common.py
> @@ -106,8 +106,8 @@ def run_unit(test_case, eal={}):
>      cmdline = "./{app_path} {eal}".format(
>          app_path=test_case.dut.apps_name["test"], eal=eal_str
>      )
> -    test_case.dut.send_expect(cmdline, ">", 30)
> -    out = test_case.dut.send_expect("compressdev_autotest", ">", 30)
> +    test_case.dut.send_expect(cmdline, "RTE>", 30)
> +    out = test_case.dut.send_expect("compressdev_autotest", "RTE>", 30)
>      test_case.dut.send_expect("quit", "# ", 30)
>      print(out)
>
> --
> 2.41.0
>
>

[-- Attachment #2: Type: text/html, Size: 2256 bytes --]

Re: [PATCH v2] compress: resolve test failure from incomplete output capture

[David Marchand]

Hello,

On Wed, Jul 16, 2025 at 10:36 PM Patrick Robb <probb@iol.unh.edu> wrote:
>
> On Wed, Jul 16, 2025 at 3:24 PM Manit Mahajan <mmahajan@iol.unh.edu> wrote:
>>
>> The compress unit test uses send_expect() with '>' to determine
>> when the command completed. A recent patch introduced a
>> deprecation warning for coremask, which includes a '>' in the
>> output. This causes send_expect() to exit early,
>> resulting in missed test output, leading to false failures.
>>
>> This is fixed by changing the expected termination prompt from
>> '>' to 'RTE>'. This change address issues from the v1 patch,
>> which incorrectly modified the EAL option from coremask to
>> corelist.
>>
>> Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
>
> Thanks. So, if we change the expect string to "RTE>", the warning will not trigger the expect and unit tests will complete before the execution proceeds? Sounds good.

On the principle, that sounds good to me too.

Just a note that other parts of "old" dts may be affected:
$ git grep 'send_expect.*">"'
tests/TestSuite_ieee1588.py:        self.dut.send_expect("start", ">", 10)
tests/TestSuite_multiprocess.py:
self.session_secondary.send_expect("send hello_primary", ">")
tests/TestSuite_multiprocess.py:
self.session_secondary.send_expect("send hello_secondary", ">")
tests/TestSuite_multiprocess.py:            self.dut.send_expect("send
%s" % line, ">")
tests/TestSuite_multiprocess.py:
self.session_secondary.send_expect("send hello_primary", ">")
tests/TestSuite_multiprocess.py:
self.session_secondary.send_expect("send hello_secondary", ">", 100)
tests/TestSuite_multiprocess_iavf.py:
self.session_secondary.send_expect("send hello_primary", ">")
tests/TestSuite_multiprocess_iavf.py:
self.session_secondary.send_expect("send hello_secondary", ">")
tests/TestSuite_multiprocess_iavf.py:
self.dut.send_expect("send %s" % line, ">")
tests/TestSuite_multiprocess_iavf.py:
self.session_secondary.send_expect("send hello_primary", ">")
tests/TestSuite_multiprocess_iavf.py:
self.session_secondary.send_expect("send hello_secondary", ">", 100)
tests/TestSuite_shutdown_api.py:            self.dut.send_expect("set
link-up port %d" % i, ">")
tests/TestSuite_speed_capabilities.py:
self.dut.send_expect("set link-up port %d" % i, ">")
tests/compress_common.py:    test_case.dut.send_expect(cmdline, ">", 30)
tests/compress_common.py:    out =
test_case.dut.send_expect("compressdev_autotest", ">", 30)


How do we proceed now?
Do you want me to push this fix in the dts legacy repo?


-- 
David Marchand

Re: [PATCH v2] compress: resolve test failure from incomplete output capture

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 3432 bytes --]

Hi David,

Because Legacy DTS is deprecated, I think you should just push Manit's
patch as is.

In the case of the Zlib test, this is a legacy DTS test which we are still
running at UNH, and we had to patch it locally to keep using the test, so
of course we felt we should push the patch to patchwork for visibility at a
minimum, and to be merged if maintainers want.

Again I don't think it is the best use of Manit's time to have him doing
further fixes in legacy DTS when he could be making other contributions to
DPDK testing efforts elsewhere. But, if you don't agree, we will adjust.

On Thu, Jul 17, 2025 at 4:40 AM David Marchand <david.marchand@redhat.com>
wrote:

> Hello,
>
> On Wed, Jul 16, 2025 at 10:36 PM Patrick Robb <probb@iol.unh.edu> wrote:
> >
> > On Wed, Jul 16, 2025 at 3:24 PM Manit Mahajan <mmahajan@iol.unh.edu>
> wrote:
> >>
> >> The compress unit test uses send_expect() with '>' to determine
> >> when the command completed. A recent patch introduced a
> >> deprecation warning for coremask, which includes a '>' in the
> >> output. This causes send_expect() to exit early,
> >> resulting in missed test output, leading to false failures.
> >>
> >> This is fixed by changing the expected termination prompt from
> >> '>' to 'RTE>'. This change address issues from the v1 patch,
> >> which incorrectly modified the EAL option from coremask to
> >> corelist.
> >>
> >> Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
> >
> > Thanks. So, if we change the expect string to "RTE>", the warning will
> not trigger the expect and unit tests will complete before the execution
> proceeds? Sounds good.
>
> On the principle, that sounds good to me too.
>
> Just a note that other parts of "old" dts may be affected:
> $ git grep 'send_expect.*">"'
> tests/TestSuite_ieee1588.py:        self.dut.send_expect("start", ">", 10)
> tests/TestSuite_multiprocess.py:
> self.session_secondary.send_expect("send hello_primary", ">")
> tests/TestSuite_multiprocess.py:
> self.session_secondary.send_expect("send hello_secondary", ">")
> tests/TestSuite_multiprocess.py:            self.dut.send_expect("send
> %s" % line, ">")
> tests/TestSuite_multiprocess.py:
> self.session_secondary.send_expect("send hello_primary", ">")
> tests/TestSuite_multiprocess.py:
> self.session_secondary.send_expect("send hello_secondary", ">", 100)
> tests/TestSuite_multiprocess_iavf.py:
> self.session_secondary.send_expect("send hello_primary", ">")
> tests/TestSuite_multiprocess_iavf.py:
> self.session_secondary.send_expect("send hello_secondary", ">")
> tests/TestSuite_multiprocess_iavf.py:
> self.dut.send_expect("send %s" % line, ">")
> tests/TestSuite_multiprocess_iavf.py:
> self.session_secondary.send_expect("send hello_primary", ">")
> tests/TestSuite_multiprocess_iavf.py:
> self.session_secondary.send_expect("send hello_secondary", ">", 100)
> tests/TestSuite_shutdown_api.py:            self.dut.send_expect("set
> link-up port %d" % i, ">")
> tests/TestSuite_speed_capabilities.py:
> self.dut.send_expect("set link-up port %d" % i, ">")
> tests/compress_common.py:    test_case.dut.send_expect(cmdline, ">", 30)
> tests/compress_common.py:    out =
> test_case.dut.send_expect("compressdev_autotest", ">", 30)
>
>
> How do we proceed now?
> Do you want me to push this fix in the dts legacy repo?
>
>
> --
> David Marchand
>
>

[-- Attachment #2: Type: text/html, Size: 4649 bytes --]