test suite reviews and discussions
 help / color / mirror / Atom feed
From: Manit Mahajan <mmahajan@iol.unh.edu>
To: dts@dpdk.org
Cc: probb@iol.unh.edu, david.marchand@redhat.com,
	Manit Mahajan <mmahajan@iol.unh.edu>
Subject: [PATCH v2] compress: resolve test failure from incomplete output capture
Date: Wed, 16 Jul 2025 11:28:50 -0400	[thread overview]
Message-ID: <20250716152850.11195-1-mmahajan@iol.unh.edu> (raw)

The compress unit test uses send_expect() with '>' to determine
when the command completed. A recent patch introduced a
deprecation warning for coremask, which includes a '>' in the
output. This causes send_expect() to exit early,
resulting in missed test output, leading to false failures.

This is fixed by changing the expected termination prompt from
'>' to 'RTE'. This change address issues from the v1 patch,
which incorrectly modified the EAL option from coremask to
corelist.

Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
---
 tests/compress_common.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/compress_common.py b/tests/compress_common.py
index aa591270..94c6f9dd 100644
--- a/tests/compress_common.py
+++ b/tests/compress_common.py
@@ -63,6 +63,7 @@ def bind_qat_device(test_case, driver="igb_uio"):
 
 def get_opt_str(test_case, default_opts={}, override_opts={}):
     case_cfg = conf.load_case_config(test_case._suite_result.test_case)
+    print("case_cfg ", case_cfg)
     opts = default_opts.copy()
     for key in list(default_opts.keys()):
         if key in case_cfg:
@@ -70,6 +71,8 @@ def get_opt_str(test_case, default_opts={}, override_opts={}):
 
     opts.update(override_opts)
 
+    print("opts ", opts)
+
     opt_str = ""
     for key, value in list(opts.items()):
         if value is None:
@@ -77,6 +80,7 @@ def get_opt_str(test_case, default_opts={}, override_opts={}):
         dash = "-" if len(key) == 1 else "--"
         opt_str = opt_str + "{0}{1} {2} ".format(dash, key, value)
 
+    print('opt_str ', opt_str)
     return opt_str
 
 
@@ -106,8 +110,8 @@ def run_unit(test_case, eal={}):
     cmdline = "./{app_path} {eal}".format(
         app_path=test_case.dut.apps_name["test"], eal=eal_str
     )
-    test_case.dut.send_expect(cmdline, ">", 30)
-    out = test_case.dut.send_expect("compressdev_autotest", ">", 30)
+    test_case.dut.send_expect(cmdline, "RTE>", 30)
+    out = test_case.dut.send_expect("compressdev_autotest", "RTE>", 30)
     test_case.dut.send_expect("quit", "# ", 30)
     print(out)
 
-- 
2.41.0


             reply	other threads:[~2025-07-17  8:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-16 15:28 Manit Mahajan [this message]
2025-07-16 15:43 ` Manit Mahajan
  -- strict thread matches above, loose matches on Subject: below --
2025-07-11 20:30 [PATCH] tests/compress_common: replace coremask with corelist in compress_common Manit Mahajan
2025-07-16 19:24 ` [PATCH v2] compress: resolve test failure from incomplete output capture Manit Mahajan
2025-07-16 20:30   ` Patrick Robb
2025-07-17  8:40     ` David Marchand
2025-07-17 18:33       ` Patrick Robb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250716152850.11195-1-mmahajan@iol.unh.edu \
    --to=mmahajan@iol.unh.edu \
    --cc=david.marchand@redhat.com \
    --cc=dts@dpdk.org \
    --cc=probb@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).