test suite reviews and discussions
 help / color / mirror / Atom feed
From: Manit Mahajan <mmahajan@iol.unh.edu>
To: probb@iol.unh.edu
Cc: dts@dpdk.org, david.marchand@redhat.com,
	Manit Mahajan <mmahajan@iol.unh.edu>
Subject: [PATCH v2] compress: resolve test failure from incomplete output capture
Date: Wed, 16 Jul 2025 15:24:56 -0400	[thread overview]
Message-ID: <20250716192456.30120-1-mmahajan@iol.unh.edu> (raw)
In-Reply-To: <20250711203030.10147-1-mmahajan@iol.unh.edu>

The compress unit test uses send_expect() with '>' to determine
when the command completed. A recent patch introduced a
deprecation warning for coremask, which includes a '>' in the
output. This causes send_expect() to exit early,
resulting in missed test output, leading to false failures.

This is fixed by changing the expected termination prompt from
'>' to 'RTE>'. This change address issues from the v1 patch,
which incorrectly modified the EAL option from coremask to
corelist.

Signed-off-by: Manit Mahajan <mmahajan@iol.unh.edu>
---
 tests/compress_common.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/compress_common.py b/tests/compress_common.py
index aa591270..b4fd1921 100644
--- a/tests/compress_common.py
+++ b/tests/compress_common.py
@@ -106,8 +106,8 @@ def run_unit(test_case, eal={}):
     cmdline = "./{app_path} {eal}".format(
         app_path=test_case.dut.apps_name["test"], eal=eal_str
     )
-    test_case.dut.send_expect(cmdline, ">", 30)
-    out = test_case.dut.send_expect("compressdev_autotest", ">", 30)
+    test_case.dut.send_expect(cmdline, "RTE>", 30)
+    out = test_case.dut.send_expect("compressdev_autotest", "RTE>", 30)
     test_case.dut.send_expect("quit", "# ", 30)
     print(out)
 
-- 
2.41.0


  parent reply	other threads:[~2025-07-17  8:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-11 20:30 [PATCH] tests/compress_common: replace coremask with corelist in compress_common Manit Mahajan
2025-07-11 21:30 ` Patrick Robb
2025-07-15  7:42   ` David Marchand
2025-07-16 15:53     ` Manit Mahajan
2025-07-16 19:24 ` Manit Mahajan [this message]
2025-07-16 20:30   ` [PATCH v2] compress: resolve test failure from incomplete output capture Patrick Robb
2025-07-17  8:40     ` David Marchand
2025-07-17 18:33       ` Patrick Robb
2025-07-16 15:28 Manit Mahajan
2025-07-16 15:43 ` Manit Mahajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250716192456.30120-1-mmahajan@iol.unh.edu \
    --to=mmahajan@iol.unh.edu \
    --cc=david.marchand@redhat.com \
    --cc=dts@dpdk.org \
    --cc=probb@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).