test suite reviews and discussions
 help / color / Atom feed
* Re: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func increase kill testpmd statement. check_packet_transmission func exiting abnormally willcause testpmd to not exit. The next test case continues to use untested testpmd, causing the test case to
@ 2019-09-20  6:24 Tu, Lijuan
  2019-09-23  1:49 ` Peng, ZhihongX
  0 siblings, 1 reply; 4+ messages in thread
From: Tu, Lijuan @ 2019-09-20  6:24 UTC (permalink / raw)
  To: Peng, ZhihongX, dts; +Cc: Peng, ZhihongX, Peng

Comment inline

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Monday, September 16, 2019 10:10 PM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>; Peng@dpdk.org
> Subject: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func increase
> kill testpmd statement. check_packet_transmission func exiting abnormally
> willcause testpmd to not exit. The next test case continues to use untested
> testpmd, causing the test case to f...
> 
> From: "Peng, ZhihongX" <zhihongx.peng@intel.com>
> 
> Signed-off-by: Peng, ZhihongX <zhihongx.peng@intel.com>
> ---
>  tests/TestSuite_ipgre.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index
> d74ac05..d1db8df 100644
> --- a/tests/TestSuite_ipgre.py
> +++ b/tests/TestSuite_ipgre.py
> @@ -439,6 +439,7 @@ class TestIpgre(TestCase):
>          Run after each test case.
>          Nothing to do.
>          """
> +        self.dut.kill_all()
>          pass
[Lijuan] Please remove "pass" 
> 
>      def tear_down_all(self):
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func increase kill testpmd statement. check_packet_transmission func exiting abnormally willcause testpmd to not exit. The next test case continues to use untested testpmd, causing the test case to
  2019-09-20  6:24 [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func increase kill testpmd statement. check_packet_transmission func exiting abnormally willcause testpmd to not exit. The next test case continues to use untested testpmd, causing the test case to Tu, Lijuan
@ 2019-09-23  1:49 ` Peng, ZhihongX
  0 siblings, 0 replies; 4+ messages in thread
From: Peng, ZhihongX @ 2019-09-23  1:49 UTC (permalink / raw)
  To: Tu, Lijuan, dts; +Cc: Peng

Liwenjie has submitted.

-----Original Message-----
From: Tu, Lijuan 
Sent: Friday, September 20, 2019 2:24 PM
To: Peng, ZhihongX <zhihongx.peng@intel.com>; dts@dpdk.org
Cc: Peng, ZhihongX <zhihongx.peng@intel.com>; Peng@dpdk.org
Subject: RE: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func increase kill testpmd statement. check_packet_transmission func exiting abnormally willcause testpmd to not exit. The next test case continues to use untested testpmd, causing the test case to 

Comment inline

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Monday, September 16, 2019 10:10 PM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>; Peng@dpdk.org
> Subject: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func 
> increase kill testpmd statement. check_packet_transmission func 
> exiting abnormally willcause testpmd to not exit. The next test case 
> continues to use untested testpmd, causing the test case to f...
> 
> From: "Peng, ZhihongX" <zhihongx.peng@intel.com>
> 
> Signed-off-by: Peng, ZhihongX <zhihongx.peng@intel.com>
> ---
>  tests/TestSuite_ipgre.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index 
> d74ac05..d1db8df 100644
> --- a/tests/TestSuite_ipgre.py
> +++ b/tests/TestSuite_ipgre.py
> @@ -439,6 +439,7 @@ class TestIpgre(TestCase):
>          Run after each test case.
>          Nothing to do.
>          """
> +        self.dut.kill_all()
>          pass
[Lijuan] Please remove "pass" 
> 
>      def tear_down_all(self):
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func increase kill testpmd statement. check_packet_transmission func exiting abnormally willcause testpmd to not exit. The next test case continues to use untested testpmd, causing the test case to
  2019-09-16  8:31 Mo, YufengX
@ 2019-09-16  8:35 ` Li, WenjieX A
  0 siblings, 0 replies; 4+ messages in thread
From: Li, WenjieX A @ 2019-09-16  8:35 UTC (permalink / raw)
  To: Mo, YufengX, dts, Peng, ZhihongX, Zhang, YanX A; +Cc: Yu, PingX

[-- Attachment #1: Type: text/plain, Size: 1906 bytes --]

FYI

> -----Original Message-----
> From: Mo, YufengX
> Sent: Monday, September 16, 2019 4:32 PM
> To: dts@dpdk.org; Peng, ZhihongX <zhihongx.peng@intel.com>; Li, WenjieX A
> <wenjiex.a.li@intel.com>; Zhang, YanX A <yanx.a.zhang@intel.com>
> Cc: Yu, PingX <pingx.yu@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func increase
> kill testpmd statement. check_packet_transmission func exiting abnormally
> willcause testpmd to not exit. The next test case continues to use untested
> testpmd, causing the test case to
> 
> Hi, peng zhihong
> 
> Li,wenjie has one patch to do the same thing. Could you sync with him?
> 
> [dts] [PATCH V1] tests/ipgre: optimize script
> 
> BRs
> Yufen, Mo
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> > Sent: Monday, September 16, 2019 10:10 PM
> > To: dts@dpdk.org
> > Cc: Peng, ZhihongX <zhihongx.peng@intel.com>; Peng@dpdk.org
> > Subject: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func
> > increase kill testpmd statement. check_packet_transmission func exiting
> abnormally willcause testpmd to not exit. The next test case continues to use
> untested testpmd, causing the test case to f...
> >
> > From: "Peng, ZhihongX" <zhihongx.peng@intel.com>
> >
> > Signed-off-by: Peng, ZhihongX <zhihongx.peng@intel.com>
> > ---
> >  tests/TestSuite_ipgre.py | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index
> > d74ac05..d1db8df 100644
> > --- a/tests/TestSuite_ipgre.py
> > +++ b/tests/TestSuite_ipgre.py
> > @@ -439,6 +439,7 @@ class TestIpgre(TestCase):
> >          Run after each test case.
> >          Nothing to do.
> >          """
> > +        self.dut.kill_all()
> >          pass
> >
> >      def tear_down_all(self):
> > --
> > 2.17.1


[-- Attachment #2: Type: message/rfc822, Size: 2990 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func increase kill testpmd statement. check_packet_transmission func exiting abnormally willcause testpmd to not exit. The next test case continues to use untested testpmd, causing the test case to
@ 2019-09-16  8:31 Mo, YufengX
  2019-09-16  8:35 ` Li, WenjieX A
  0 siblings, 1 reply; 4+ messages in thread
From: Mo, YufengX @ 2019-09-16  8:31 UTC (permalink / raw)
  To: dts, Peng, ZhihongX, Li, WenjieX A, Zhang, YanX A; +Cc: Yu, PingX

Hi, peng zhihong

Li,wenjie has one patch to do the same thing. Could you sync with him?

[dts] [PATCH V1] tests/ipgre: optimize script

BRs
Yufen, Mo

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Monday, September 16, 2019 10:10 PM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>; Peng@dpdk.org
> Subject: [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func increase kill testpmd statement. check_packet_transmission func
> exiting abnormally willcause testpmd to not exit. The next test case continues to use untested testpmd, causing the test case to f...
> 
> From: "Peng, ZhihongX" <zhihongx.peng@intel.com>
> 
> Signed-off-by: Peng, ZhihongX <zhihongx.peng@intel.com>
> ---
>  tests/TestSuite_ipgre.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py
> index d74ac05..d1db8df 100644
> --- a/tests/TestSuite_ipgre.py
> +++ b/tests/TestSuite_ipgre.py
> @@ -439,6 +439,7 @@ class TestIpgre(TestCase):
>          Run after each test case.
>          Nothing to do.
>          """
> +        self.dut.kill_all()
>          pass
> 
>      def tear_down_all(self):
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-20  6:24 [dts] [PATCH V1] tests/TestSuite_ipgre.py: Tear_down func increase kill testpmd statement. check_packet_transmission func exiting abnormally willcause testpmd to not exit. The next test case continues to use untested testpmd, causing the test case to Tu, Lijuan
2019-09-23  1:49 ` Peng, ZhihongX
  -- strict thread matches above, loose matches on Subject: below --
2019-09-16  8:31 Mo, YufengX
2019-09-16  8:35 ` Li, WenjieX A

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox