test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V2] Modify the clv offset code
@ 2019-10-21 11:21 Peng Zhihong
  2019-10-22  9:51 ` Tu, Lijuan
  0 siblings, 1 reply; 6+ messages in thread
From: Peng Zhihong @ 2019-10-21 11:21 UTC (permalink / raw)
  To: dts; +Cc: Peng Zhihong

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 116fd3a..94918e9 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -546,9 +546,16 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
         mtus = [1519, 2048]
         mtu_threshold = 2022
         offset = 0
+        
         if self.nic in ['powerville', 'springville']:
             mtu_threshold = 2026
             offset = 4
+        elif self.nic in ['columbiaville_25g', 'columbiaville_100g']:
+            #ICE_ETH_OVERHEAD is 8
+            offset = 8
+        else:
+            pass
+
         for index in range(len(self.ports)):
             port = self.ports[index]
             # change mtu
@@ -561,10 +568,9 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
                 if mtu > mtu_threshold:
                     if self.nic in ['powerville', 'springville']:
                         mtu = mtu_threshold
-                    self.dut.send_expect("stop %s" % index, "EthApp>")
-                    self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
-                    self.dut.send_expect("open %s" % index, "EthApp>")
+                self.dut.send_expect("stop %s" % index, "EthApp>")
                 self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
+                self.dut.send_expect("open %s" % index, "EthApp>")
                 time.sleep(5)
                 ori_rx_pkts, _ = self.strip_portstats(index)
                 pkt_size = mtu + HEADER_SIZE['eth'] + offset
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V2] Modify the clv offset code
  2019-10-21 11:21 [dts] [PATCH V2] Modify the clv offset code Peng Zhihong
@ 2019-10-22  9:51 ` Tu, Lijuan
  2019-10-22  9:56   ` Peng, ZhihongX
  2019-10-22  9:59   ` Peng, ZhihongX
  0 siblings, 2 replies; 6+ messages in thread
From: Tu, Lijuan @ 2019-10-22  9:51 UTC (permalink / raw)
  To: Peng, ZhihongX, dts; +Cc: Peng, ZhihongX

I can't understand why is the patch, thanks

Columbiaville and Fortville has the same overhead length, so why they are in different catalogs.
#define ICE_ETH_OVERHEAD \
        (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + ICE_VLAN_TAG_SIZE * 2)

#define I40E_ETH_OVERHEAD \
        (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + I40E_VLAN_TAG_SIZE * 2)


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Monday, October 21, 2019 7:22 PM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
> Subject: [dts] [PATCH V2] Modify the clv offset code
> 
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>  tests/TestSuite_userspace_ethtool.py | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index 116fd3a..94918e9 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -546,9 +546,16 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>          mtus = [1519, 2048]
>          mtu_threshold = 2022
>          offset = 0
> +
>          if self.nic in ['powerville', 'springville']:
>              mtu_threshold = 2026
>              offset = 4
> +        elif self.nic in ['columbiaville_25g', 'columbiaville_100g']:
> +            #ICE_ETH_OVERHEAD is 8
> +            offset = 8
> +        else:
> +            pass
> +
>          for index in range(len(self.ports)):
>              port = self.ports[index]
>              # change mtu
> @@ -561,10 +568,9 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>                  if mtu > mtu_threshold:
>                      if self.nic in ['powerville', 'springville']:
>                          mtu = mtu_threshold
> -                    self.dut.send_expect("stop %s" % index, "EthApp>")
> -                    self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
> -                    self.dut.send_expect("open %s" % index, "EthApp>")
> +                self.dut.send_expect("stop %s" % index, "EthApp>")
>                  self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
> +                self.dut.send_expect("open %s" % index, "EthApp>")
>                  time.sleep(5)
>                  ori_rx_pkts, _ = self.strip_portstats(index)
>                  pkt_size = mtu + HEADER_SIZE['eth'] + offset
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V2] Modify the clv offset code
  2019-10-22  9:51 ` Tu, Lijuan
@ 2019-10-22  9:56   ` Peng, ZhihongX
  2019-10-22  9:59   ` Peng, ZhihongX
  1 sibling, 0 replies; 6+ messages in thread
From: Peng, ZhihongX @ 2019-10-22  9:56 UTC (permalink / raw)
  To: Tu, Lijuan, dts

My test results show that packets can be received up to 8 bytes above the maximum mtu and can be forwarded normally.

-----Original Message-----
From: Tu, Lijuan 
Sent: Tuesday, October 22, 2019 5:51 PM
To: Peng, ZhihongX <zhihongx.peng@intel.com>; dts@dpdk.org
Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
Subject: RE: [dts] [PATCH V2] Modify the clv offset code

I can't understand why is the patch, thanks

Columbiaville and Fortville has the same overhead length, so why they are in different catalogs.
#define ICE_ETH_OVERHEAD \
        (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + ICE_VLAN_TAG_SIZE * 2)

#define I40E_ETH_OVERHEAD \
        (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + I40E_VLAN_TAG_SIZE * 2)


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Monday, October 21, 2019 7:22 PM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
> Subject: [dts] [PATCH V2] Modify the clv offset code
> 
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>  tests/TestSuite_userspace_ethtool.py | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index 116fd3a..94918e9 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -546,9 +546,16 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>          mtus = [1519, 2048]
>          mtu_threshold = 2022
>          offset = 0
> +
>          if self.nic in ['powerville', 'springville']:
>              mtu_threshold = 2026
>              offset = 4
> +        elif self.nic in ['columbiaville_25g', 'columbiaville_100g']:
> +            #ICE_ETH_OVERHEAD is 8
> +            offset = 8
> +        else:
> +            pass
> +
>          for index in range(len(self.ports)):
>              port = self.ports[index]
>              # change mtu
> @@ -561,10 +568,9 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>                  if mtu > mtu_threshold:
>                      if self.nic in ['powerville', 'springville']:
>                          mtu = mtu_threshold
> -                    self.dut.send_expect("stop %s" % index, "EthApp>")
> -                    self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
> -                    self.dut.send_expect("open %s" % index, "EthApp>")
> +                self.dut.send_expect("stop %s" % index, "EthApp>")
>                  self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
> +                self.dut.send_expect("open %s" % index, "EthApp>")
>                  time.sleep(5)
>                  ori_rx_pkts, _ = self.strip_portstats(index)
>                  pkt_size = mtu + HEADER_SIZE['eth'] + offset
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V2] Modify the clv offset code
  2019-10-22  9:51 ` Tu, Lijuan
  2019-10-22  9:56   ` Peng, ZhihongX
@ 2019-10-22  9:59   ` Peng, ZhihongX
  1 sibling, 0 replies; 6+ messages in thread
From: Peng, ZhihongX @ 2019-10-22  9:59 UTC (permalink / raw)
  To: Tu, Lijuan, dts

https://jira.devtools.intel.com/browse/DPDK-16219 
Wang, Ying A gave me the wrong advice. She asked me to follow my test

-----Original Message-----
From: Peng, ZhihongX 
Sent: Tuesday, October 22, 2019 5:56 PM
To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
Subject: RE: [dts] [PATCH V2] Modify the clv offset code

My test results show that packets can be received up to 8 bytes above the maximum mtu and can be forwarded normally.

-----Original Message-----
From: Tu, Lijuan 
Sent: Tuesday, October 22, 2019 5:51 PM
To: Peng, ZhihongX <zhihongx.peng@intel.com>; dts@dpdk.org
Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
Subject: RE: [dts] [PATCH V2] Modify the clv offset code

I can't understand why is the patch, thanks

Columbiaville and Fortville has the same overhead length, so why they are in different catalogs.
#define ICE_ETH_OVERHEAD \
        (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + ICE_VLAN_TAG_SIZE * 2)

#define I40E_ETH_OVERHEAD \
        (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + I40E_VLAN_TAG_SIZE * 2)


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Monday, October 21, 2019 7:22 PM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
> Subject: [dts] [PATCH V2] Modify the clv offset code
> 
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>  tests/TestSuite_userspace_ethtool.py | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index 116fd3a..94918e9 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -546,9 +546,16 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>          mtus = [1519, 2048]
>          mtu_threshold = 2022
>          offset = 0
> +
>          if self.nic in ['powerville', 'springville']:
>              mtu_threshold = 2026
>              offset = 4
> +        elif self.nic in ['columbiaville_25g', 'columbiaville_100g']:
> +            #ICE_ETH_OVERHEAD is 8
> +            offset = 8
> +        else:
> +            pass
> +
>          for index in range(len(self.ports)):
>              port = self.ports[index]
>              # change mtu
> @@ -561,10 +568,9 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>                  if mtu > mtu_threshold:
>                      if self.nic in ['powerville', 'springville']:
>                          mtu = mtu_threshold
> -                    self.dut.send_expect("stop %s" % index, "EthApp>")
> -                    self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
> -                    self.dut.send_expect("open %s" % index, "EthApp>")
> +                self.dut.send_expect("stop %s" % index, "EthApp>")
>                  self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
> +                self.dut.send_expect("open %s" % index, "EthApp>")
>                  time.sleep(5)
>                  ori_rx_pkts, _ = self.strip_portstats(index)
>                  pkt_size = mtu + HEADER_SIZE['eth'] + offset
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V2] Modify the clv offset code
@ 2019-10-21 10:24 Peng Zhihong
  2019-10-21  2:30 ` Ma, LihongX
  0 siblings, 1 reply; 6+ messages in thread
From: Peng Zhihong @ 2019-10-21 10:24 UTC (permalink / raw)
  To: dts; +Cc: Peng Zhihong

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index bdbbea3..5898511 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -546,10 +546,16 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
         mtus = [1519, 2048]
         mtu_threshold = 2022
         offset = 0
-        ice_eth_overhead = 8
+        
         if self.nic in ['powerville', 'springville']:
             mtu_threshold = 2026
             offset = 4
+        elif self.nic in ['columbiaville_25g', 'columbiaville_100g']:
+            #jira DPDK-16219
+            offset = 8
+        else:
+            pass
+
         for index in range(len(self.ports)):
             port = self.ports[index]
             # change mtu
@@ -573,10 +579,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
                 pkt.send_pkt(self.tester, tx_port=intf, count=4)
                 rx_pkts, _ = self.strip_portstats(index)
                 self.verify(rx_pkts == ori_rx_pkts + 4, "Packet match mtu not forwarded as expected")
-                if self.nic in ['columbiaville_25g', 'columbiaville_100g']:
-                    pkt = Packet(pkt_type='UDP', pkt_len=mtu + ice_eth_overhead + 1 + HEADER_SIZE['eth'] + offset)
-                else:
-                    pkt = Packet(pkt_type='UDP', pkt_len=mtu + 1 + HEADER_SIZE['eth'] + offset)
+                pkt = Packet(pkt_type='UDP', pkt_len=mtu + 1 + HEADER_SIZE['eth'] + offset)
                 pkt.send_pkt(self.tester, tx_port=intf, count=4)
                 rx_pkts_over, _ = self.strip_portstats(index)
                 self.verify(rx_pkts == rx_pkts_over, "Packet over mtu should not be forwarded")
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V2] Modify the clv offset code
  2019-10-21 10:24 Peng Zhihong
@ 2019-10-21  2:30 ` Ma, LihongX
  0 siblings, 0 replies; 6+ messages in thread
From: Ma, LihongX @ 2019-10-21  2:30 UTC (permalink / raw)
  To: Peng, ZhihongX, dts; +Cc: Peng, ZhihongX

Hi, zhihong
This patch will apply failed, because you base dts is not right.

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
Sent: Monday, October 21, 2019 6:25 PM
To: dts@dpdk.org
Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
Subject: [dts] [PATCH V2] Modify the clv offset code

Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index bdbbea3..5898511 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -546,10 +546,16 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
         mtus = [1519, 2048]
         mtu_threshold = 2022
         offset = 0
-        ice_eth_overhead = 8
+        
         if self.nic in ['powerville', 'springville']:
             mtu_threshold = 2026
             offset = 4
+        elif self.nic in ['columbiaville_25g', 'columbiaville_100g']:
+            #jira DPDK-16219
+            offset = 8
+        else:
+            pass
+
         for index in range(len(self.ports)):
             port = self.ports[index]
             # change mtu
@@ -573,10 +579,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
                 pkt.send_pkt(self.tester, tx_port=intf, count=4)
                 rx_pkts, _ = self.strip_portstats(index)
                 self.verify(rx_pkts == ori_rx_pkts + 4, "Packet match mtu not forwarded as expected")
-                if self.nic in ['columbiaville_25g', 'columbiaville_100g']:
-                    pkt = Packet(pkt_type='UDP', pkt_len=mtu + ice_eth_overhead + 1 + HEADER_SIZE['eth'] + offset)
-                else:
-                    pkt = Packet(pkt_type='UDP', pkt_len=mtu + 1 + HEADER_SIZE['eth'] + offset)
+                pkt = Packet(pkt_type='UDP', pkt_len=mtu + 1 + HEADER_SIZE['eth'] + offset)
                 pkt.send_pkt(self.tester, tx_port=intf, count=4)
                 rx_pkts_over, _ = self.strip_portstats(index)
                 self.verify(rx_pkts == rx_pkts_over, "Packet over mtu should not be forwarded")
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-21 11:21 [dts] [PATCH V2] Modify the clv offset code Peng Zhihong
2019-10-22  9:51 ` Tu, Lijuan
2019-10-22  9:56   ` Peng, ZhihongX
2019-10-22  9:59   ` Peng, ZhihongX
  -- strict thread matches above, loose matches on Subject: below --
2019-10-21 10:24 Peng Zhihong
2019-10-21  2:30 ` Ma, LihongX

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox