From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14B31A328D for ; Tue, 22 Oct 2019 11:59:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CFCB11BE95; Tue, 22 Oct 2019 11:59:20 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 4D89D4C9D for ; Tue, 22 Oct 2019 11:59:19 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2019 02:59:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,326,1566889200"; d="scan'208";a="372472976" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 22 Oct 2019 02:59:18 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 22 Oct 2019 02:59:17 -0700 Received: from cdsmsx151.ccr.corp.intel.com (172.17.4.38) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 22 Oct 2019 02:59:17 -0700 Received: from cdsmsx102.ccr.corp.intel.com ([169.254.2.114]) by CDSMSX151.ccr.corp.intel.com ([169.254.3.155]) with mapi id 14.03.0439.000; Tue, 22 Oct 2019 17:59:15 +0800 From: "Peng, ZhihongX" To: "Tu, Lijuan" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V2] Modify the clv offset code Thread-Index: AQHViL4+4mztIVXO7U2ZxCyPpw48V6dma3xwgAABSNA= Date: Tue, 22 Oct 2019 09:59:14 +0000 Message-ID: <218C9AAF1879E445B4BC31BDA3D0850295823E@CDSMSX102.ccr.corp.intel.com> References: <20191021112143.27230-1-zhihongx.peng@intel.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BB450D9@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.17.6.105] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] Modify the clv offset code X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" https://jira.devtools.intel.com/browse/DPDK-16219=20 Wang, Ying A gave me the wrong advice. She asked me to follow my test -----Original Message----- From: Peng, ZhihongX=20 Sent: Tuesday, October 22, 2019 5:56 PM To: Tu, Lijuan ; dts@dpdk.org Subject: RE: [dts] [PATCH V2] Modify the clv offset code My test results show that packets can be received up to 8 bytes above the m= aximum mtu and can be forwarded normally. -----Original Message----- From: Tu, Lijuan=20 Sent: Tuesday, October 22, 2019 5:51 PM To: Peng, ZhihongX ; dts@dpdk.org Cc: Peng, ZhihongX Subject: RE: [dts] [PATCH V2] Modify the clv offset code I can't understand why is the patch, thanks Columbiaville and Fortville has the same overhead length, so why they are i= n different catalogs. #define ICE_ETH_OVERHEAD \ (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + ICE_VLAN_TAG_SIZE * 2) #define I40E_ETH_OVERHEAD \ (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + I40E_VLAN_TAG_SIZE * 2) > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong > Sent: Monday, October 21, 2019 7:22 PM > To: dts@dpdk.org > Cc: Peng, ZhihongX > Subject: [dts] [PATCH V2] Modify the clv offset code >=20 > Signed-off-by: Peng Zhihong > --- > tests/TestSuite_userspace_ethtool.py | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) >=20 > diff --git a/tests/TestSuite_userspace_ethtool.py > b/tests/TestSuite_userspace_ethtool.py > index 116fd3a..94918e9 100644 > --- a/tests/TestSuite_userspace_ethtool.py > +++ b/tests/TestSuite_userspace_ethtool.py > @@ -546,9 +546,16 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > mtus =3D [1519, 2048] > mtu_threshold =3D 2022 > offset =3D 0 > + > if self.nic in ['powerville', 'springville']: > mtu_threshold =3D 2026 > offset =3D 4 > + elif self.nic in ['columbiaville_25g', 'columbiaville_100g']: > + #ICE_ETH_OVERHEAD is 8 > + offset =3D 8 > + else: > + pass > + > for index in range(len(self.ports)): > port =3D self.ports[index] > # change mtu > @@ -561,10 +568,9 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > if mtu > mtu_threshold: > if self.nic in ['powerville', 'springville']: > mtu =3D mtu_threshold > - self.dut.send_expect("stop %s" % index, "EthApp>") > - self.dut.send_expect("mtu %d %d" % (index, mtu), "Et= hApp>") > - self.dut.send_expect("open %s" % index, "EthApp>") > + self.dut.send_expect("stop %s" % index, "EthApp>") > self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp= >") > + self.dut.send_expect("open %s" % index, "EthApp>") > time.sleep(5) > ori_rx_pkts, _ =3D self.strip_portstats(index) > pkt_size =3D mtu + HEADER_SIZE['eth'] + offset > -- > 2.17.1