test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Yao, Lei A" <lei.a.yao@intel.com>
To: "Wang, Yinan" <yinan.wang@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Wang, Yinan" <yinan.wang@intel.com>
Subject: Re: [dts] [PATCH v2] test_plans/pvp_multi_paths_vhost_max_efficiency:	add test plan of pvp multi-paths for vhost max efficiency
Date: Sat, 19 Jan 2019 02:14:49 +0000	[thread overview]
Message-ID: <2DBBFF226F7CF64BAFCA79B681719D9549615A2D@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20190110005102.107452-1-yinan.wang@intel.com>



> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yinan
> Sent: Thursday, January 10, 2019 8:51 AM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>
> Subject: [dts] [PATCH v2]
> test_plans/pvp_multi_paths_vhost_max_efficiency: add test plan of pvp
> multi-paths for vhost max efficiency
The test plan name is a little confusing, seems the test topology is testing 
Virtio single core performance , not vhost.  

> 
> From: Wang Yinan <yinan.wang@intel.com>
> 
> Signed-off-by: Wang Yinan <yinan.wang@intel.com>
> ---
>  ...i_paths_vhost_max_efficiency_test_plan.rst | 218 ++++++++++++++++++
>  1 file changed, 218 insertions(+)
>  create mode 100644
> test_plans/pvp_multi_paths_vhost_max_efficiency_test_plan.rst
> 
> diff --git a/test_plans/pvp_multi_paths_vhost_max_efficiency_test_plan.rst
> b/test_plans/pvp_multi_paths_vhost_max_efficiency_test_plan.rst
> new file mode 100644
> index 0000000..bbeff3d
> --- /dev/null
> +++ b/test_plans/pvp_multi_paths_vhost_max_efficiency_test_plan.rst
> @@ -0,0 +1,218 @@
> +.. Copyright (c) <2019>, Intel Corporation
> +   All rights reserved.
> +
> +   Redistribution and use in source and binary forms, with or without
> +   modification, are permitted provided that the following conditions
> +   are met:
> +
> +   - Redistributions of source code must retain the above copyright
> +     notice, this list of conditions and the following disclaimer.
> +
> +   - Redistributions in binary form must reproduce the above copyright
> +     notice, this list of conditions and the following disclaimer in
> +     the documentation and/or other materials provided with the
> +     distribution.
> +
> +   - Neither the name of Intel Corporation nor the names of its
> +     contributors may be used to endorse or promote products derived
> +     from this software without specific prior written permission.
> +
> +   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
> CONTRIBUTORS
> +   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT
> NOT
> +   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
> FITNESS
> +   FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> +   COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
> INDIRECT,
> +   INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
> +   (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE
> GOODS OR
> +   SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
> +   HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> CONTRACT,
> +   STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> +   ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
> ADVISED
> +   OF THE POSSIBILITY OF SUCH DAMAGE.
> +
> +=====================================
> +PVP multi-paths vhost max efficiency Tests
> +=====================================
> +
> +Description
> +===========
> +
> +Benchmark vhost/virtio-user PVP performance with 7 TX/RX PATHs.
> +Includes Mergeable, Normal, Vector_RX, Inorder mergeable,
> +Inorder no-mergeable, Virtio 1.1 mergeable, Virtio 1.1 no-mergeable Path.
> +For vhost max efficiency,give 1 core for vhost and virtio respectively.
> +
The description don't match the suite name. 
> +Test Case 1: vhost/virtio-user pvp test with Virtio 1.1 mergeable path
> +=========================================================
> ==============
Test case name don't match the test suite name. From this name , user will think
this is one normal PVP test, not vhost or virtio single core performance test 
> +
> +flow:
> +TG --> NIC --> Vhost --> Virtio--> Vhost --> NIC --> TG
The flow is not testing vhost max performance .  It should be
TG --> NIC --> virtio --> vhost--> virtio --> NIC --> TG
> +
> +1. Bind one port to igb_uio, then launch testpmd by below command::
> +
> +    rm -rf vhost-net*
> +    ./testpmd -n 4 -l 2-4  --socket-mem 1024,1024 --legacy-mem \
> +    --file-prefix=vhost --vdev 'net_vhost0,iface=vhost-
> net,queues=1,client=0' -- -i --nb-cores=1 --txd=1024 --rxd=1024
> +    testpmd>set fwd mac
> +    testpmd>start
Seems nb-cores should be 2, if we are testing virtio single core 
performance

> +
> +2. Launch virtio-user by below command::
> +
> +    ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
> +    --legacy-mem --no-pci --file-prefix=virtio \
> +    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,packed_vq=1,mrg_rxbuf=1 \
> +    -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --rss-ip --nb-cores=1 --
> txd=1024 --rxd=1024
> +    >set fwd mac
> +    >start
> +
> +3. Send packet with packet generator with different packet size, check the
> throughput.
> +
> +Test Case 2: vhost/virtio-user pvp test with Virtio 1.1 no-mergeable path
> +=========================================================
> ==============
> +
> +flow:
> +TG --> NIC --> Vhost --> Virtio--> Vhost --> NIC --> TG
> +
> +1. Bind one port to igb_uio, then launch testpmd by below command::
> +
> +    rm -rf vhost-net*
> +    ./testpmd -n 4 -l 2-4  --socket-mem 1024,1024 --legacy-mem \
> +    --file-prefix=vhost --vdev 'net_vhost0,iface=vhost-
> net,queues=1,client=0' -- -i --nb-cores=1 --txd=1024 --rxd=1024
> +    testpmd>set fwd mac
> +    testpmd>start
> +
> +2. Launch virtio-user by below command::
> +
> +    ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
> +    --legacy-mem --no-pci --file-prefix=virtio \
> +    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,packed_vq=1,mrg_rxbuf=0 \
> +    -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --rss-ip --nb-cores=1 --
> txd=1024 --rxd=1024
> +    >set fwd mac
> +    >start
> +
> +3. Send packet with packet generator with different packet size, check the
> throughput.
> +
> +Test Case 3: vhost/virtio-user pvp test with Inorder mergeable path
> +=========================================================
> ==============
> +
> +flow:
> +TG --> NIC --> Vhost --> Virtio--> Vhost --> NIC --> TG
> +
> +1. Bind one port to igb_uio, then launch testpmd by below command::
> +
> +    rm -rf vhost-net*
> +    ./testpmd -n 4 -l 2-4  --socket-mem 1024,1024 --legacy-mem \
> +    --file-prefix=vhost --vdev 'net_vhost0,iface=vhost-
> net,queues=1,client=0' -- -i --nb-cores=1 --txd=1024 --rxd=1024
> +    testpmd>set fwd mac
> +    testpmd>start
> +
> +2. Launch virtio-user by below command::
> +
> +    ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
> +    --legacy-mem --no-pci --file-prefix=virtio \
> +    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,in_order=1 \
> +    -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --rss-ip --nb-cores=1 --
> txd=1024 --rxd=1024
> +    >set fwd mac
> +    >start
> +
> +3. Send packet with packet generator with different packet size, check the
> throughput.
> +
> +Test Case 4: vhost/virtio-user pvp test with Inorder no-mergeable path
> +=========================================================
> ==============
> +
> +flow:
> +TG --> NIC --> Vhost --> Virtio--> Vhost --> NIC --> TG
> +
> +1. Bind one port to igb_uio, then launch testpmd by below command::
> +
> +    rm -rf vhost-net*
> +    ./testpmd -n 4 -l 2-4  --socket-mem 1024,1024 --legacy-mem \
> +    --file-prefix=vhost --vdev 'net_vhost0,iface=vhost-
> net,queues=1,client=0' -- -i --nb-cores=1 --txd=1024 --rxd=1024
> +    testpmd>set fwd mac
> +    testpmd>start
> +
> +2. Launch virtio-user by below command::
> +
> +    ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
> +    --legacy-mem --no-pci --file-prefix=virtio \
> +    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,in_order=1,mrg_rxbuf=0 \
> +    -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --rss-ip --nb-cores=1 --
> txd=1024 --rxd=1024
> +    >set fwd mac
> +    >start
> +
> +3. Send packet with packet generator with different packet size, check the
> throughput.
> +
> +Test Case 5: vhost/virtio-user pvp test with Mergeable path
> +=========================================================
> ==============
> +
> +flow:
> +TG --> NIC --> Vhost --> Virtio--> Vhost --> NIC --> TG
> +
> +1. Bind one port to igb_uio, then launch testpmd by below command::
> +
> +    rm -rf vhost-net*
> +    ./testpmd -n 4 -l 2-4  --socket-mem 1024,1024 --legacy-mem \
> +    --file-prefix=vhost --vdev 'net_vhost0,iface=vhost-
> net,queues=1,client=0' -- -i --nb-cores=1 --txd=1024 --rxd=1024
> +    testpmd>set fwd mac
> +    testpmd>start
> +
> +2. Launch virtio-user by below command::
> +
> +    ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
> +    --legacy-mem --no-pci --file-prefix=virtio \
> +    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,in_order=0,mrg_rxbuf=1 \
> +    -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --rss-ip --nb-cores=1 --
> txd=1024 --rxd=1024
> +    >set fwd mac
> +    >start
> +
> +3. Send packet with packet generator with different packet size, check the
> throughput.
> +
> +Test Case 6: vhost/virtio-user pvp test with Normal path
> +=========================================================
> ==============
> +
> +flow:
> +TG --> NIC --> Vhost --> Virtio--> Vhost --> NIC --> TG
> +
> +1. Bind one port to igb_uio, then launch testpmd by below command::
> +
> +    rm -rf vhost-net*
> +    ./testpmd -n 4 -l 2-4  --socket-mem 1024,1024 --legacy-mem \
> +    --file-prefix=vhost --vdev 'net_vhost0,iface=vhost-
> net,queues=1,client=0' -- -i --nb-cores=1 --txd=1024 --rxd=1024
> +    testpmd>set fwd mac
> +    testpmd>start
> +
> +2. Launch virtio-user by below command::
> +
> +    ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
> +    --legacy-mem --no-pci --file-prefix=virtio \
> +    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,in_order=0,mrg_rxbuf=0 \
> +    -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --rss-ip --nb-cores=1 --
> txd=1024 --rxd=1024
> +    >set fwd mac
> +    >start
> +
> +3. Send packet with packet generator with different packet size, check the
> throughput.
> +
> +Test Case 7: vhost/virtio-user pvp test with Vector_RX path
> +=========================================================
> ==============
> +
> +flow:
> +TG --> NIC --> Vhost --> Virtio--> Vhost --> NIC --> TG
> +
> +1. Bind one port to igb_uio, then launch testpmd by below command::
> +
> +    rm -rf vhost-net*
> +    ./testpmd -n 4 -l 2-4  --socket-mem 1024,1024 --legacy-mem \
> +    --file-prefix=vhost --vdev 'net_vhost0,iface=vhost-
> net,queues=1,client=0' -- -i --nb-cores=1 --txd=1024 --rxd=1024
> +    testpmd>set fwd mac
> +    testpmd>start
> +
> +2. Launch virtio-user by below command::
> +
> +    ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
> +    --legacy-mem --no-pci --file-prefix=virtio \
> +    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,in_order=0,mrg_rxbuf=0 \
> +    -- -i --tx-offloads=0x0 --rss-ip --nb-cores=1 --txd=1024 --rxd=1024
> +    >set fwd mac
> +    >start
> +
> +3. Send packet with packet generator with different packet size, check the
> throughput.
> --
> 2.17.1

      reply	other threads:[~2019-01-19  2:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10  0:51 Yinan
2019-01-19  2:14 ` Yao, Lei A [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2DBBFF226F7CF64BAFCA79B681719D9549615A2D@shsmsx102.ccr.corp.intel.com \
    --to=lei.a.yao@intel.com \
    --cc=dts@dpdk.org \
    --cc=yinan.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).