test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1] tests/unit_tests_eal:remove unnecessary test commands
@ 2021-11-19 16:59 Lewei Yang
  2021-11-22 15:01 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Lewei Yang @ 2021-11-19 16:59 UTC (permalink / raw)
  To: dts; +Cc: Lewei Yang

According to dpdk commit 81169a01ff2e("test: remove unnecessary test commands"),
Nothing is referencing eal_flags_autotest and rwlock_autotest anymore,since we dropped the python wrapper.

Signed-off-by: Lewei Yang <leweix.yang@intel.com>
---
 test_plans/unit_tests_eal_test_plan.rst | 21 ---------------------
 tests/TestSuite_unit_tests_eal.py       | 23 -----------------------
 2 files changed, 44 deletions(-)

diff --git a/test_plans/unit_tests_eal_test_plan.rst b/test_plans/unit_tests_eal_test_plan.rst
index 4cb9d6b9..f4aacb67 100644
--- a/test_plans/unit_tests_eal_test_plan.rst
+++ b/test_plans/unit_tests_eal_test_plan.rst
@@ -111,27 +111,6 @@ Spinlock
   for each core, in the correct order. The autotest script checks that
   this order is correct.
 
-Rwlock
-======
-
-- There is a global rwlock and a table of rwlocks (one per lcore).
-
-- The test function takes all of these locks and launches the
-  ``test_rwlock_per_core()`` function on each core (except the master).
-
-  - The function takes the global write lock, display something,
-    then releases the global lock.
-  - Then, it takes the per-lcore write lock, display something, and
-    releases the per-core lock.
-  - Finally, a read lock is taken during 100 ms, then released.
-
-- The main function unlocks the per-lcore locks sequentially and
-  waits between each lock. This triggers the display of a message
-  for each core, in the correct order.
-
-  Then, it tries to take the global write lock and display the last
-  message. The autotest script checks that the message order is correct.
-
 Atomic Variables
 ================
 
diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
index 8096183c..db2579ce 100644
--- a/tests/TestSuite_unit_tests_eal.py
+++ b/tests/TestSuite_unit_tests_eal.py
@@ -286,16 +286,6 @@ class TestUnitTestsEal(TestCase):
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Test failed")
 
-    def test_rwlock(self):
-        """
-        Run rwlock autotest.
-        """
-
-        self.dut.send_expect(self.test_app_cmdline, "R.*T.*E.*>.*>", self.start_test_time)
-        out = self.dut.send_expect("rwlock_autotest", "RTE>>", self.run_cmd_time)
-        self.dut.send_expect("quit", "# ")
-        self.verify("Test OK" in out, "Test failed")
-
     def test_prefetch(self):
         """
         Run prefetch autotest.
@@ -356,19 +346,6 @@ class TestUnitTestsEal(TestCase):
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Test failed")
 
-    def test_flags(self):
-        """
-        Run eal flags autotest.
-        """
-
-        self.dut.unbind_interfaces_linux()
-        self.dut.send_expect(self.test_app_cmdline + ' -m 64', "R.*T.*E.*>.*>", self.start_test_time)
-        # on FreeBSD need more time than other OS
-        out = self.dut.send_expect("eal_flags_autotest", "RTE>>", 600)
-        self.dut.send_expect("quit", "# ")
-        self.dut.bind_interfaces_linux(driver=self.drivername)
-        self.verify("Test OK" in out, "Test failed")
-
     def test_alarm(self):
         """
         Run alarm autotest.
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [dts][PATCH V1] tests/unit_tests_eal:remove unnecessary test commands
  2021-11-19 16:59 [dts][PATCH V1] tests/unit_tests_eal:remove unnecessary test commands Lewei Yang
@ 2021-11-22 15:01 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2021-11-22 15:01 UTC (permalink / raw)
  To: Yang, LeweiX, dts; +Cc: Yang, LeweiX


> -----Original Message-----
> From: Lewei Yang <leweix.yang@intel.com>
> Sent: 2021年11月20日 0:59
> To: dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: [dts][PATCH V1] tests/unit_tests_eal:remove unnecessary test
> commands
> 
> According to dpdk commit 81169a01ff2e("test: remove unnecessary test
> commands"), Nothing is referencing eal_flags_autotest and rwlock_autotest
> anymore,since we dropped the python wrapper.
> 
> Signed-off-by: Lewei Yang <leweix.yang@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-22 15:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-19 16:59 [dts][PATCH V1] tests/unit_tests_eal:remove unnecessary test commands Lewei Yang
2021-11-22 15:01 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git