test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "An, XiangX" <xiangx.an@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "An, XiangX" <xiangx.an@intel.com>
Subject: Re: [dts] [PATCH V2 2/4] tests/vf_vlan: modify code to adapt avx512
Date: Fri, 5 Nov 2021 12:31:38 +0000	[thread overview]
Message-ID: <2fdd6428adad4da385c01ced912b2509@intel.com> (raw)
In-Reply-To: <1636008699-16970-2-git-send-email-xiangx.an@intel.com>



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xiang An
> Sent: 2021年11月4日 14:52
> To: dts@dpdk.org
> Cc: An, XiangX <xiangx.an@intel.com>
> Subject: [dts] [PATCH V2 2/4] tests/vf_vlan: modify code to adapt avx512
> 
> Based on dpdk commit:4b64ccb328 modify dts code to adapt avx512.
> 
> Signed-off-by: Xiang An <xiangx.an@intel.com>
> ---
>  tests/TestSuite_vf_vlan.py | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py index
> 127eca3..ff3e13f 100644
> --- a/tests/TestSuite_vf_vlan.py
> +++ b/tests/TestSuite_vf_vlan.py
> @@ -35,7 +35,7 @@ import time
> 
>  from framework.packet import Packet
>  from framework.pmd_output import PmdOutput -from framework.settings
> import get_nic_name
> +from framework.settings import get_nic_name, load_global_setting,
> +DPDK_RXMODE_SETTING
>  from framework.test_case import TestCase  from framework.virt_common
> import VM
> 
> @@ -346,7 +346,10 @@ class TestVfVlan(TestCase):
>          self.vm0_dut_ports = self.vm_dut_0.get_ports('any')
> 
>          self.vm0_testpmd = PmdOutput(self.vm_dut_0)
> -        self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
> +        if load_global_setting(DPDK_RXMODE_SETTING) == 'avx512':
> +            self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--enable-rx-cksum')
> +        else:
> +            self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
>          self.vm0_testpmd.execute_cmd('set fwd rxonly')
>          self.vm0_testpmd.execute_cmd('set verbose 1')
>          self.vm0_testpmd.execute_cmd('vlan set strip on 0') @@ -417,7 +420,10
> @@ class TestVfVlan(TestCase):
>          if self.kdriver == "i40e":
>              self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '')
>          else:
> -            self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
> +            if load_global_setting(DPDK_RXMODE_SETTING) == 'avx512':
> +                self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--enable-rx-
> cksum')
> +            else:
> +                self.vm0_testpmd.start_testpmd(VM_CORES_MASK)

AVX512 should have the same behavior with other path,  is this a know issue in dpdk21.11 ? if not, please submit a bug to dpdk.

  reply	other threads:[~2021-11-05 12:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04  6:51 [dts] [PATCH V2 1/4] tests/kernelpf_iavf: " Xiang An
2021-11-04  6:51 ` [dts] [PATCH V2 2/4] tests/vf_vlan: " Xiang An
2021-11-05 12:31   ` Tu, Lijuan [this message]
2021-11-04  6:51 ` [dts] [PATCH V2 3/4] tests/l3fwdacl: " Xiang An
2021-11-05 13:24   ` Tu, Lijuan
2021-11-04  6:51 ` [dts] [PATCH V2 4/4] tests/unit_tests_eal: " Xiang An
2021-11-05 13:22   ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2fdd6428adad4da385c01ced912b2509@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=xiangx.an@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).