test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V2] tests/unit_tests_eal:remove strict timing requirements some tests
@ 2021-11-23 11:00 Lewei Yang
  2021-11-23 14:00 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Lewei Yang @ 2021-11-23 11:00 UTC (permalink / raw)
  To: dts; +Cc: Lewei Yang

According to dpdk commit ee00af60170b("test: remove strict timing requirements some tests"),
Remove the timing related tests from the test suites

Signed-off-by: Lewei Yang <leweix.yang@intel.com>
---
 test_plans/unit_tests_eal_test_plan.rst | 24 ------------------------
 tests/TestSuite_unit_tests_eal.py       | 21 ---------------------
 2 files changed, 45 deletions(-)

diff --git a/test_plans/unit_tests_eal_test_plan.rst b/test_plans/unit_tests_eal_test_plan.rst
index 4cb9d6b9..3b871513 100644
--- a/test_plans/unit_tests_eal_test_plan.rst
+++ b/test_plans/unit_tests_eal_test_plan.rst
@@ -189,15 +189,6 @@ Byteorder functions
 Check the result of optimized byte swap functions for each size (16-,
 32- and 64-bit).
 
-Cycles Test
-===========
-
-- Loop N times and check that the timer always increments and
-  never decrements during this loop.
-
-- Wait one second using rte_usleep() and check that the increment
-  of cycles is correct with regard to the frequency of the timer.
-
 Logs
 ====
 
@@ -244,21 +235,6 @@ Debug test
 
 - Call rte_dump_stack() and rte_dump_registers().
 
-Alarm
-=====
-
-- Check that the callback for the alarm can to be called.
-- Check that it is not possible to set alarm with invalid time value.
-- Check that it is not possible to set alarm without a callback.
-- Check that it is not possible to cancel alarm without a callback pointer.
-- Check that multiple callbacks for the alarm can be called.
-- Check that the number of removed and unremoved alarms are correct.
-- Check that no callback is called if all alarm removed.
-- Check that it is not possible to cancel an alarm within the callback itself.
-- Check that the callback which is the head of all is able to be removed.
-- Check that all alarms for the same callback can be canceled.
-
-
 CPU flags
 =========
 
diff --git a/tests/TestSuite_unit_tests_eal.py b/tests/TestSuite_unit_tests_eal.py
index 8096183c..5a3d3922 100644
--- a/tests/TestSuite_unit_tests_eal.py
+++ b/tests/TestSuite_unit_tests_eal.py
@@ -316,16 +316,6 @@ class TestUnitTestsEal(TestCase):
         self.dut.send_expect("quit", "# ")
         self.verify("Test OK" in out, "Test failed")
 
-    def test_cycles(self):
-        """
-        Run cycles autotest.
-        """
-
-        self.dut.send_expect(self.test_app_cmdline, "R.*T.*E.*>.*>", self.start_test_time)
-        out = self.dut.send_expect("cycles_autotest", "RTE>>", self.run_cmd_time)
-        self.dut.send_expect("quit", "# ")
-        self.verify("Test OK" in out, "Test failed")
-
     def test_logs(self):
         """
         Run logs autotest.
@@ -369,17 +359,6 @@ class TestUnitTestsEal(TestCase):
         self.dut.bind_interfaces_linux(driver=self.drivername)
         self.verify("Test OK" in out, "Test failed")
 
-    def test_alarm(self):
-        """
-        Run alarm autotest.
-        """
-
-        self.verify(self.env == "linuxapp", "Alarm only supported in linux env")
-        self.dut.send_expect(self.test_app_cmdline, "R.*T.*E.*>.*>", self.start_test_time)
-        out = self.dut.send_expect("alarm_autotest", "RTE>>", self.run_cmd_time)
-        self.dut.send_expect("quit", "# ")
-        self.verify("Test OK" in out, "Test failed")
-
     def test_cpuflags(self):
         """
         Run CPU flags autotest.
-- 
2.33.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [dts][PATCH V2] tests/unit_tests_eal:remove strict timing requirements some tests
  2021-11-23 11:00 [dts][PATCH V2] tests/unit_tests_eal:remove strict timing requirements some tests Lewei Yang
@ 2021-11-23 14:00 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2021-11-23 14:00 UTC (permalink / raw)
  To: Yang, LeweiX, dts; +Cc: Yang, LeweiX

> -----Original Message-----
> From: Lewei Yang <leweix.yang@intel.com>
> Sent: 2021年11月23日 19:01
> To: dts@dpdk.org
> Cc: Yang, LeweiX <leweix.yang@intel.com>
> Subject: [dts][PATCH V2] tests/unit_tests_eal:remove strict timing requirements
> some tests
> 
> According to dpdk commit ee00af60170b("test: remove strict timing
> requirements some tests"), Remove the timing related tests from the test suites
> 
> Signed-off-by: Lewei Yang <leweix.yang@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-23 14:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-23 11:00 [dts][PATCH V2] tests/unit_tests_eal:remove strict timing requirements some tests Lewei Yang
2021-11-23 14:00 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).