From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 54C46239 for ; Tue, 30 Oct 2018 07:54:49 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Oct 2018 23:54:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,443,1534834800"; d="scan'208";a="85564727" Received: from dts-maintain.sh.intel.com (HELO [10.67.119.110]) ([10.67.119.110]) by orsmga008.jf.intel.com with ESMTP; 29 Oct 2018 23:54:46 -0700 To: wenjieli , dts@dpdk.org References: <1540549459-14228-1-git-send-email-wenjiex.a.li@intel.com> From: Lijuan Tu Message-ID: <33dbbd04-8bda-9483-7fdd-af6766ba0310@intel.com> Date: Tue, 30 Oct 2018 23:22:42 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1540549459-14228-1-git-send-email-wenjiex.a.li@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dts] [PATCH V2] tests/shutdown_api: add sagepond support speed to change_linkspeed X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 06:54:49 -0000 Applied, thanks On 2018年10月26日 18:24, wenjieli wrote: > Sagepond nic only support 1000baseT and 10000baseT, but the peer nic > might support more speeds, sagepond could be set to unsupport mode; to > avoid such issue, add sagepond support speed to change_linkspeed case. > > Signed-off-by: wenjieli > --- > tests/TestSuite_shutdown_api.py | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py > index 1282cf7..ba4c6cb 100644 > --- a/tests/TestSuite_shutdown_api.py > +++ b/tests/TestSuite_shutdown_api.py > @@ -312,6 +312,9 @@ class TestShutdownApi(TestCase): > elif self.nic in ["fortville_eagle"]: > if config[0] != '10000': > continue > + elif self.nic in ["sagepond"]: > + if config[0] != '1000' and '10000': > + continue > self.dut.send_expect("port stop all", "testpmd> ", 100) > for port in self.ports: > self.dut.send_expect("port config %d speed %s duplex %s" % (port,