From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 196F4A0C53; Fri, 3 Sep 2021 11:42:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 107D240E09; Fri, 3 Sep 2021 11:42:47 +0200 (CEST) Received: from mailgw01.pantheon.sk (mailgw01.pantheon.sk [46.229.239.26]) by mails.dpdk.org (Postfix) with ESMTP id 5BEE240DF4 for ; Fri, 3 Sep 2021 11:42:46 +0200 (CEST) Received: from mailgw01.pantheon.sk (localhost.localdomain [127.0.0.1]) by mailgw01.pantheon.sk (Proxmox) with ESMTP id 163A4201B2E; Fri, 3 Sep 2021 11:42:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; h=cc:cc:content-transfer-encoding:content-type:content-type :date:from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=dkim; bh=M9QL8NigWm0otr4Dqo55 0mMoMY9qzNYAd6K+s5RJebE=; b=gzR8CFCs7Iv1Eua9/vyElLBJ0lu33qe6p4iC SfKntzHoxC+on/S1dUDhvx7Zq17kiJ1NdxSaaqnm36E7xwDTo5Yo7Fr0BxbumUqG uA8k9rSsRLIxmwVgDEWevDE0fQvm6jU44uXNXSKVrzg5MZS/s2OtibB2URqc+CBz YI7HvC5l/Z0zOo7eMi2ujFgx7nbfa1zQqSJxI2VtEzb4ZO3Qt2e5aiknnn1+hdU4 hONJTFdt9aIJvIKPEX4oi3gDfJvkch3Ea32TrL6EhfIHrHERYtYI1lMx03qSO0k5 lEl2Dy1rIjiOPlUvW6rCPriujQH1CVxLQ5+zx56NYEeLFimbmQ== From: =?iso-8859-2?Q?Juraj_Linke=B9?= To: "ohilyard@iol.unh.edu" , "dts@dpdk.org" CC: "lijuan.tu@intel.com" Thread-Topic: [dts] [PATCH v2] ci/initial: Added script to get the tests for a patchset Thread-Index: AQHXj4/i7dF/XFspfkqnv5BI4uy5pquSFdZw Date: Fri, 3 Sep 2021 09:42:44 +0000 Message-ID: <35cfdcbff7f54d9d9e00d611d1490db8@pantheon.tech> References: <20210812153647.74262-1-ohilyard@iol.unh.edu> In-Reply-To: <20210812153647.74262-1-ohilyard@iol.unh.edu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.101.4.10] Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH v2] ci/initial: Added script to get the tests for a patchset X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" > -----Original Message----- > From: dts On Behalf Of ohilyard@iol.unh.edu > Sent: Thursday, August 12, 2021 5:37 PM > To: dts@dpdk.org > Cc: lijuan.tu@intel.com; Owen Hilyard > Subject: [dts] [PATCH v2] ci/initial: Added script to get the tests for a= patchset I'd strongly suggest using these guidelines (and also adding them to the DT= S WG requirements) for writing commit messages: https://chris.beams.io/post= s/git-commit/ I think DPDK also uses those (or very similar) guidelines. We'll be consist= ent and the just rules make sense. In this commit message I think only the form in the subject should be chang= ed to imperative. >=20 > From: Owen Hilyard >=20 > This script should be run after the patchset has been applied. > It will check all files that have a diff to the git ref in DTS_MAIN_BRANC= H_REF > (currently origin/master). >=20 > It will also issue warnings to standard error if a "protected path" is ch= anged. This > is currently configured to only by the ci scripts folder, since under mos= t > circumstances a patch should not need to change anything in there. This w= arning > will be in the format: > "WARNING: {file_name} is protected" >=20 > The script will also issue a warning if a config file is changed. This wa= rning is also > sent to standard error and takes the form of: > "WARNING: {file_name} is a config file and was changed" >=20 > The script will output a list of the test suites to run to standard out, = with each > entry having one line. >=20 > Signed-off-by: Owen Hilyard > --- > ci/Dockerfile | 18 ++++ > ci/README.txt | 37 +++++++ > ci/build_image.sh | 0 > ci/get_tests_for_patchset.py | 197 +++++++++++++++++++++++++++++++++++ > ci/requirements.txt | 32 ++++++ > 5 files changed, 284 insertions(+) > create mode 100644 ci/Dockerfile > create mode 100644 ci/README.txt > create mode 100644 ci/build_image.sh > create mode 100644 ci/get_tests_for_patchset.py create mode 100644 > ci/requirements.txt >=20 > diff --git a/ci/Dockerfile b/ci/Dockerfile new file mode 100644 index > 00000000..89645b36 > --- /dev/null > +++ b/ci/Dockerfile > @@ -0,0 +1,18 @@ > +# This container should be build in the ci directory, and then the # > +DTS directory should be mounted as a volume at /dts/ FROM > +python:3.9-slim-buster > + > +ENV DEBIAN_FRONTEND=3Dnoninteractive > + > +COPY requirements.txt . > +COPY dts_requirements.txt dts_requirements.txt > + > +RUN apt-get update && apt-get install --no-install-recommends -y \ > + # Add a C compiler for all of the c modules in DTS > + build-essential make gcc git libpcap-dev\ > + python3-pip > + > +RUN pip3 install -r requirements.txt > +RUN pip3 install -r dts_requirements.txt > +# install formatter > +RUN pip3 > +install black > \ No newline at end of file Are these missing newlines intentional? > diff --git a/ci/README.txt b/ci/README.txt new file mode 100644 index > 00000000..281329f7 > --- /dev/null > +++ b/ci/README.txt > @@ -0,0 +1,37 @@ > +# BSD LICENSE > +# > +# Copyright(c) 2021 University of New Hampshire Interoperability Laborat= ory. > All rights reserved. > +# All rights reserved. > +# > +# Redistribution and use in source and binary forms, with or without # > +modification, are permitted provided that the following conditions # > +are met: > +# > +# * Redistributions of source code must retain the above copyright > +# notice, this list of conditions and the following disclaimer. > +# * Redistributions in binary form must reproduce the above copyright > +# notice, this list of conditions and the following disclaimer in > +# the documentation and/or other materials provided with the > +# distribution. > +# * Neither the name of Intel Corporation nor the names of its > +# contributors may be used to endorse or promote products derived > +# from this software without specific prior written permission. > +# Should Intel be still mentioned here? In general, how should the licence look like? Was there a discussion about = this? > +argparse=3D=3D1.4.0 > \ No newline at end of file The other newline and the reason for plural earlier. Pointing this out in c= ase we'll change it. > -- > 2.30.2 >=20