test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1 1/2] tests/TestSuite_cvl_fdir:remove flow-mark-support param
@ 2020-09-29  6:17 Xie wei
  2020-09-29  6:17 ` [dts] [PATCH V1 2/2] test_plans/cvl_fdir_test_plan:remove " Xie wei
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Xie wei @ 2020-09-29  6:17 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

According to dpdk commit 62451c94a, remove flow-mark-support param when
it starts testpmd.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_cvl_fdir.py | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_cvl_fdir.py b/tests/TestSuite_cvl_fdir.py
index 474ec2c9..e5a9c71e 100644
--- a/tests/TestSuite_cvl_fdir.py
+++ b/tests/TestSuite_cvl_fdir.py
@@ -2290,7 +2290,7 @@ class TestCVLFdir(TestCase):
         self.pmd_output.start_testpmd(cores="1S/4C/1T",
                                       param="--portmask=%s --rxq=%d --txq=%d --port-topology=loop" % (
                                           self.portMask, rxq, txq),
-                                      eal_param="-w %s,flow-mark-support=1 -w %s,flow-mark-support=1 --log-level=ice,7" % (
+                                      eal_param="-w %s -w %s --log-level=ice,7" % (
                                           self.pci0, self.pci1), socket=self.ports_socket)
         self.config_testpmd()
 
@@ -3031,9 +3031,7 @@ class TestCVLFdir(TestCase):
             f.writelines(cmds_li)
         self.dut.session.copy_file_to(cmd_path, cmd_path)
         try:
-            eal_param = self.dut.create_eal_parameters(cores="1S/4C/1T", ports=[self.pci0 + ",flow-mark-support=1",
-                                                                                self.pci1 + ",flow-mark-support=1"],
-                                                       socket=self.ports_socket)
+            eal_param = self.dut.create_eal_parameters(cores="1S/4C/1T", ports=[self.pci0, self.pci1], socket=self.ports_socket)
             param = " --log-level='ice,7' -- -i --portmask=%s --rxq=%d --txq=%d --port-topology=loop --cmdline-file=%s" % (
                 self.portMask, 64, 64, cmd_path)
             command_line = self.dut.apps_name['test-pmd'] + eal_param + param
@@ -3140,7 +3138,7 @@ class TestCVLFdir(TestCase):
             out = self.pmd_output.start_testpmd(cores="1S/4C/1T",
                                                 param="--portmask=%s --rxq=%d --txq=%d --port-topology=loop --cmdline-file=%s" % (
                                                     self.portMask, 64, 64, cmd_path),
-                                                eal_param="-w %s,flow-mark-support=1 -w %s,flow-mark-support=1 --log-level='ice,7'" % (
+                                                eal_param="-w %s -w %s --log-level='ice,7'" % (
                                                     self.pci0, self.pci1), socket=self.ports_socket)
             self.verify('Failed to create flow' not in out, "create some rule failed")
             self.config_testpmd()
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V1 2/2] test_plans/cvl_fdir_test_plan:remove flow-mark-support param
  2020-09-29  6:17 [dts] [PATCH V1 1/2] tests/TestSuite_cvl_fdir:remove flow-mark-support param Xie wei
@ 2020-09-29  6:17 ` " Xie wei
  2020-09-29  6:54   ` Peng, Yuan
  2020-09-29  6:53 ` [dts] [PATCH V1 1/2] tests/TestSuite_cvl_fdir:remove " Peng, Yuan
  2020-10-12  8:10 ` Tu, Lijuan
  2 siblings, 1 reply; 5+ messages in thread
From: Xie wei @ 2020-09-29  6:17 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

According to dpdk commit 62451c94a, remove flow-mark-support param when
it launches testpmd.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 test_plans/cvl_fdir_test_plan.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test_plans/cvl_fdir_test_plan.rst b/test_plans/cvl_fdir_test_plan.rst
index 7c2357e4..0e1521fe 100644
--- a/test_plans/cvl_fdir_test_plan.rst
+++ b/test_plans/cvl_fdir_test_plan.rst
@@ -137,7 +137,7 @@ Prerequisites
 
 5. Launch the app ``testpmd`` with the following arguments::
 
-    ./testpmd -c 0xff -n 6 -w 86:00.0,,flow-mark-support=1 --log-level="ice,7" -- -i --portmask=0xff --rxq=64 --txq=64 --port-topology=loop
+    ./testpmd -c 0xff -n 6 -w 86:00.0 --log-level="ice,7" -- -i --portmask=0xff --rxq=64 --txq=64 --port-topology=loop
     testpmd> set fwd rxonly
     testpmd> set verbose 1
 
@@ -148,7 +148,7 @@ Prerequisites
 
    Notes: if need two ports environment, launch ``testpmd`` with the following arguments::
 
-    ./testpmd -c 0xff -n 6 -w 86:00.0,flow-mark-support=1 -w 86:00.1,flow-mark-support=1 --log-level="ice,7" -- -i --portmask=0xff --rxq=64 --txq=64 --port-topology=loop
+    ./testpmd -c 0xff -n 6 -w 86:00.0 -w 86:00.1 --log-level="ice,7" -- -i --portmask=0xff --rxq=64 --txq=64 --port-topology=loop
 
 
 Default parameters
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 1/2] tests/TestSuite_cvl_fdir:remove flow-mark-support param
  2020-09-29  6:17 [dts] [PATCH V1 1/2] tests/TestSuite_cvl_fdir:remove flow-mark-support param Xie wei
  2020-09-29  6:17 ` [dts] [PATCH V1 2/2] test_plans/cvl_fdir_test_plan:remove " Xie wei
@ 2020-09-29  6:53 ` " Peng, Yuan
  2020-10-12  8:10 ` Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: Peng, Yuan @ 2020-09-29  6:53 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

Acked by Peng, Yuan <yuan.peng@intel.com>


-----Original Message-----
From: dts <dts-bounces@dpdk.org> On Behalf Of Xie wei
Sent: Tuesday, September 29, 2020 2:18 PM
To: dts@dpdk.org
Cc: Xie, WeiX <weix.xie@intel.com>
Subject: [dts] [PATCH V1 1/2] tests/TestSuite_cvl_fdir:remove flow-mark-support param

According to dpdk commit 62451c94a, remove flow-mark-support param when it starts testpmd.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_cvl_fdir.py | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_cvl_fdir.py b/tests/TestSuite_cvl_fdir.py index 474ec2c9..e5a9c71e 100644
--- a/tests/TestSuite_cvl_fdir.py
+++ b/tests/TestSuite_cvl_fdir.py
@@ -2290,7 +2290,7 @@ class TestCVLFdir(TestCase):
         self.pmd_output.start_testpmd(cores="1S/4C/1T",
                                       param="--portmask=%s --rxq=%d --txq=%d --port-topology=loop" % (
                                           self.portMask, rxq, txq),
-                                      eal_param="-w %s,flow-mark-support=1 -w %s,flow-mark-support=1 --log-level=ice,7" % (
+                                      eal_param="-w %s -w %s 
+ --log-level=ice,7" % (
                                           self.pci0, self.pci1), socket=self.ports_socket)
         self.config_testpmd()
 
@@ -3031,9 +3031,7 @@ class TestCVLFdir(TestCase):
             f.writelines(cmds_li)
         self.dut.session.copy_file_to(cmd_path, cmd_path)
         try:
-            eal_param = self.dut.create_eal_parameters(cores="1S/4C/1T", ports=[self.pci0 + ",flow-mark-support=1",
-                                                                                self.pci1 + ",flow-mark-support=1"],
-                                                       socket=self.ports_socket)
+            eal_param = 
+ self.dut.create_eal_parameters(cores="1S/4C/1T", ports=[self.pci0, 
+ self.pci1], socket=self.ports_socket)
             param = " --log-level='ice,7' -- -i --portmask=%s --rxq=%d --txq=%d --port-topology=loop --cmdline-file=%s" % (
                 self.portMask, 64, 64, cmd_path)
             command_line = self.dut.apps_name['test-pmd'] + eal_param + param @@ -3140,7 +3138,7 @@ class TestCVLFdir(TestCase):
             out = self.pmd_output.start_testpmd(cores="1S/4C/1T",
                                                 param="--portmask=%s --rxq=%d --txq=%d --port-topology=loop --cmdline-file=%s" % (
                                                     self.portMask, 64, 64, cmd_path),
-                                                eal_param="-w %s,flow-mark-support=1 -w %s,flow-mark-support=1 --log-level='ice,7'" % (
+                                                eal_param="-w %s -w %s 
+ --log-level='ice,7'" % (
                                                     self.pci0, self.pci1), socket=self.ports_socket)
             self.verify('Failed to create flow' not in out, "create some rule failed")
             self.config_testpmd()
--
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 2/2] test_plans/cvl_fdir_test_plan:remove flow-mark-support param
  2020-09-29  6:17 ` [dts] [PATCH V1 2/2] test_plans/cvl_fdir_test_plan:remove " Xie wei
@ 2020-09-29  6:54   ` Peng, Yuan
  0 siblings, 0 replies; 5+ messages in thread
From: Peng, Yuan @ 2020-09-29  6:54 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

Acked by Peng, Yuan <yuan.peng@intel.com>


-----Original Message-----
From: dts <dts-bounces@dpdk.org> On Behalf Of Xie wei
Sent: Tuesday, September 29, 2020 2:18 PM
To: dts@dpdk.org
Cc: Xie, WeiX <weix.xie@intel.com>
Subject: [dts] [PATCH V1 2/2] test_plans/cvl_fdir_test_plan:remove flow-mark-support param

According to dpdk commit 62451c94a, remove flow-mark-support param when it launches testpmd.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 test_plans/cvl_fdir_test_plan.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test_plans/cvl_fdir_test_plan.rst b/test_plans/cvl_fdir_test_plan.rst
index 7c2357e4..0e1521fe 100644
--- a/test_plans/cvl_fdir_test_plan.rst
+++ b/test_plans/cvl_fdir_test_plan.rst
@@ -137,7 +137,7 @@ Prerequisites
 
 5. Launch the app ``testpmd`` with the following arguments::
 
-    ./testpmd -c 0xff -n 6 -w 86:00.0,,flow-mark-support=1 --log-level="ice,7" -- -i --portmask=0xff --rxq=64 --txq=64 --port-topology=loop
+    ./testpmd -c 0xff -n 6 -w 86:00.0 --log-level="ice,7" -- -i 
+ --portmask=0xff --rxq=64 --txq=64 --port-topology=loop
     testpmd> set fwd rxonly
     testpmd> set verbose 1
 
@@ -148,7 +148,7 @@ Prerequisites
 
    Notes: if need two ports environment, launch ``testpmd`` with the following arguments::
 
-    ./testpmd -c 0xff -n 6 -w 86:00.0,flow-mark-support=1 -w 86:00.1,flow-mark-support=1 --log-level="ice,7" -- -i --portmask=0xff --rxq=64 --txq=64 --port-topology=loop
+    ./testpmd -c 0xff -n 6 -w 86:00.0 -w 86:00.1 --log-level="ice,7" -- 
+ -i --portmask=0xff --rxq=64 --txq=64 --port-topology=loop
 
 
 Default parameters
--
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 1/2] tests/TestSuite_cvl_fdir:remove flow-mark-support param
  2020-09-29  6:17 [dts] [PATCH V1 1/2] tests/TestSuite_cvl_fdir:remove flow-mark-support param Xie wei
  2020-09-29  6:17 ` [dts] [PATCH V1 2/2] test_plans/cvl_fdir_test_plan:remove " Xie wei
  2020-09-29  6:53 ` [dts] [PATCH V1 1/2] tests/TestSuite_cvl_fdir:remove " Peng, Yuan
@ 2020-10-12  8:10 ` Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2020-10-12  8:10 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

> According to dpdk commit 62451c94a, remove flow-mark-support param when
> it starts testpmd.
> 
> Signed-off-by: Xie wei <weix.xie@intel.com>

Applied the series

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-29  6:17 [dts] [PATCH V1 1/2] tests/TestSuite_cvl_fdir:remove flow-mark-support param Xie wei
2020-09-29  6:17 ` [dts] [PATCH V1 2/2] test_plans/cvl_fdir_test_plan:remove " Xie wei
2020-09-29  6:54   ` Peng, Yuan
2020-09-29  6:53 ` [dts] [PATCH V1 1/2] tests/TestSuite_cvl_fdir:remove " Peng, Yuan
2020-10-12  8:10 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox