test suite reviews and discussions
 help / color / mirror / Atom feed
* [DTS][PATCH V1] tests/vf_offload: fix wrong value assigned for VxLAN packet under DCF.
@ 2023-03-15  9:28 Ke Xu
  2023-03-28  0:56 ` lijuan.tu
  0 siblings, 1 reply; 2+ messages in thread
From: Ke Xu @ 2023-03-15  9:28 UTC (permalink / raw)
  To: dts; +Cc: songx.jiale, Ke Xu

There are several mis-placed parameters in vf_offload updating and not covered
 due to an known issue blocking dcf enabling of this case. These mistakes may cause
 unexpected verifying result. This patch fixes these errors.

Signed-off-by: Ke Xu <ke1.xu@intel.com>
---
 tests/TestSuite_vf_offload.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py
index 9475ef22..9d7ed9c2 100644
--- a/tests/TestSuite_vf_offload.py
+++ b/tests/TestSuite_vf_offload.py
@@ -545,7 +545,7 @@ class TestVfOffload(TestCase):
         if self.dcf_mode == "enable":
             pkts_outer.update(
                 {
-                    "IP/UDP/VXLAN/ETH": f'IP(src = "{sndIP}") / UDP(sport = 4789, dport = 4789, chksum = 0xff) / VXLAN() / Ether()',
+                    "IP/UDP/VXLAN/ETH": f'IP(src = "{sndIP}", chksum = 0xff) / UDP(sport = 4789, dport = 4789, chksum = 0xff) / VXLAN() / Ether()',
                     "IPv6/UDP/VXLAN/ETH": f'IPv6(src = "{sndIPv6}") / UDP(sport = 4789, dport = 4789, chksum = 0xff) / VXLAN() / Ether()',
                 }
             )
@@ -584,9 +584,9 @@ class TestVfOffload(TestCase):
         }
 
         if self.dcf_mode == "enable":
-            pkts_outer.update(
+            pkts_outer_ref.update(
                 {
-                    "IP/UDP/VXLAN/ETH": f'IP(src = "{sndIP}", chksum = 0xff) / UDP(sport = 4789, dport = 4789) / VXLAN() / Ether()',
+                    "IP/UDP/VXLAN/ETH": f'IP(src = "{sndIP}") / UDP(sport = 4789, dport = 4789) / VXLAN() / Ether()',
                     "IPv6/UDP/VXLAN/ETH": f'IPv6(src = "{sndIPv6}") / UDP(sport = 4789, dport = 4789) / VXLAN() / Ether()',
                 }
             )
@@ -735,9 +735,9 @@ class TestVfOffload(TestCase):
         }
 
         if self.dcf_mode == "enable":
-            pkts_outer.update(
+            pkts_outer_ref.update(
                 {
-                    "VLAN/IP/UDP/VXLAN/ETH": f'Dot1Q(vlan=100) / IP(src = "{sndIP}", chksum = 0xff) / UDP(sport = 4789, dport = 4789) / VXLAN() / Ether()',
+                    "VLAN/IP/UDP/VXLAN/ETH": f'Dot1Q(vlan=100) / IP(src = "{sndIP}") / UDP(sport = 4789, dport = 4789) / VXLAN() / Ether()',
                     "VLAN/IPv6/UDP/VXLAN/ETH": f'Dot1Q(vlan=100) / IPv6(src = "{sndIPv6}") / UDP(sport = 4789, dport = 4789) / VXLAN() / Ether()',
                 }
             )
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [DTS][PATCH V1] tests/vf_offload: fix wrong value assigned for VxLAN packet under DCF.
  2023-03-15  9:28 [DTS][PATCH V1] tests/vf_offload: fix wrong value assigned for VxLAN packet under DCF Ke Xu
@ 2023-03-28  0:56 ` lijuan.tu
  0 siblings, 0 replies; 2+ messages in thread
From: lijuan.tu @ 2023-03-28  0:56 UTC (permalink / raw)
  To: dts, Ke Xu; +Cc: songx.jiale, Ke Xu

On Wed, 15 Mar 2023 17:28:43 +0800, Ke Xu <ke1.xu@intel.com> wrote:
> There are several mis-placed parameters in vf_offload updating and not covered
>  due to an known issue blocking dcf enabling of this case. These mistakes may cause
>  unexpected verifying result. This patch fixes these errors.
> 
> Signed-off-by: Ke Xu <ke1.xu@intel.com>


Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-28  0:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-15  9:28 [DTS][PATCH V1] tests/vf_offload: fix wrong value assigned for VxLAN packet under DCF Ke Xu
2023-03-28  0:56 ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).