test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, LijuanX A" <lijuanx.a.tu@intel.com>
To: "Zhu, ShuaiX" <shuaix.zhu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhu, ShuaiX" <shuaix.zhu@intel.com>
Subject: Re: [dts] [PATCH V1] tests/TestSuite_short_live.py:Delay repair on	start_up_time.
Date: Wed, 14 Mar 2018 09:34:50 +0000	[thread overview]
Message-ID: <38D041F150D4184C8114E499040E62343DCE09FD@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1521010972-82091-1-git-send-email-shuaix.zhu@intel.com>

As DPDK will capture signals, " SIGTERM" and "SIGINT", it needs some time to prepare to exit.

Hi shuai,
Could you make your code more succinctly?


Code may be simple
-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
Sent: Wednesday, March 14, 2018 3:03 PM
To: dts@dpdk.org
Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
Subject: [dts] [PATCH V1] tests/TestSuite_short_live.py:Delay repair on start_up_time.

I think it is because case has delayed after killing testpmd, resulting in no release resources.

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_short_live.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/TestSuite_short_live.py b/tests/TestSuite_short_live.py index 62c43a5..8d1d847 100644
--- a/tests/TestSuite_short_live.py
+++ b/tests/TestSuite_short_live.py
@@ -160,8 +160,10 @@ class TestShortLiveApp(TestCase):
             # kill with differen Signal
             if i%2 == 0:
                 self.dut.send_expect("pkill -2 testpmd", "#", 60, True)
+                time.sleep(2)
             else:
                 self.dut.send_expect("pkill -15 testpmd", "#", 60, True)
+                time.sleep(2)
 
     def test_clean_up_with_signal_l2fwd(self):
         repeat_time = 5
--
1.9.3

  reply	other threads:[~2018-03-14  9:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14  7:02 zhu,shuai
2018-03-14  9:34 ` Tu, LijuanX A [this message]
2018-03-15  2:25 zhu,shuai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38D041F150D4184C8114E499040E62343DCE09FD@SHSMSX103.ccr.corp.intel.com \
    --to=lijuanx.a.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=shuaix.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).