Re: [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env

["Wang, Yinan" <yinan.wang@intel.com>]

Hi Lijuan,


Since 2M page smaller than 1G, so need more hug pages ,single-file-segments can help to create fewer files in hugetlbfs.
It only used in virtio-user side is ok.

BR,
Yinan

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Tu, Lijuan
> Sent: 2020年2月28日 10:51
> To: Xiao, QimaiX <qimaix.xiao@intel.com>; Zhao, HaiyangX
> <haiyangx.zhao@intel.com>; dts@dpdk.org
> Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Subject: Re: [dts] [PATCH
> V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant
> parameter single-file-segments if not 2M env
> 
> As you said, it was required on 2M env, so it's not reasonable to remove it
> without any judgement.
> 
> > -----Original Message-----
> > From: Xiao, QimaiX
> > Sent: Friday, February 28, 2020 10:37 AM
> > To: Tu, Lijuan <lijuan.tu@intel.com>; Zhao, HaiyangX
> > <haiyangx.zhao@intel.com>; dts@dpdk.org
> > Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> > Subject: RE: [dts] [PATCH
> > V1]tests/TestSuite_virtio_user_for_container_networking: remove
> > redundant parameter single-file-segments if not 2M env
> >
> > Hi, Lijuan
> >
> > I consulted lihong that single-file-segments parameter only required
> > on virtio side in 2M env, vhost side doesn't need, so it's ok to remove it.
> >
> > Regards,
> > Xiao Qimai
> >
> >
> > > -----Original Message-----
> > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan
> > > Sent: Tuesday, February 25, 2020 5:01 PM
> > > To: Zhao, HaiyangX <haiyangx.zhao@intel.com>; dts@dpdk.org
> > > Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> > > Subject: Re: [dts] [PATCH
> > > V1]tests/TestSuite_virtio_user_for_container_networking: remove
> > > redundant parameter single-file-segments if not 2M env
> > >
> > > Remove single-file-segments, so what will happen, if 2M env ?
> > >
> > > > -----Original Message-----
> > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao
> > > > Sent: Tuesday, February 25, 2020 4:35 PM
> > > > To: dts@dpdk.org
> > > > Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> > > > Subject: [dts] [PATCH
> > > > V1]tests/TestSuite_virtio_user_for_container_networking: remove
> > > > redundant parameter single-file-segments if not 2M env
> > > >
> > > > remove redundant parameter
> > > >
> > > > Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> > > > ---
> > > >  tests/TestSuite_virtio_user_for_container_networking.py | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git
> > > > a/tests/TestSuite_virtio_user_for_container_networking.py
> > > > b/tests/TestSuite_virtio_user_for_container_networking.py
> > > > index ba303b7..1f9a666 100644
> > > > --- a/tests/TestSuite_virtio_user_for_container_networking.py
> > > > +++ b/tests/TestSuite_virtio_user_for_container_networking.py
> > > > @@ -164,7 +164,7 @@ class TestVirtioUserForContainer(TestCase):
> > > >              command_line_user = 'docker run -i -t --privileged -v
> > > > %s/vhost- net:/tmp/vhost-net ' + \
> > > >                              '-v /mnt/huge:/dev/hugepages ' + \
> > > >                              '-v %s:%s %s .%s/%s/app/testpmd
> -c %s -n %d ' + \
> > > > -                            '-m 1024 --no-pci --file-prefix=container
> --single-file-
> > > > segments ' + \
> > > > +                            '-m 1024 --no-pci
> > > > + --file-prefix=container ' + \
> > > >                              '--
> > > > vdev=virtio_user0,mac=00:11:22:33:44:10,path=/tmp/vhost-
> > > net,queues=%d '
> > > > + \
> > > >                              '-- -i --rxq=%d --txq=%d
> --nb-cores=%d'
> > > >          command_line_user = command_line_user %
> > > > (self.container_base_dir,
> > > > --
> > > > 1.8.3.1