From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id DAC182904 for ; Thu, 1 Nov 2018 09:58:08 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Nov 2018 01:58:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,451,1534834800"; d="scan'208";a="104371971" Received: from dts-maintain.sh.intel.com (HELO [10.67.119.110]) ([10.67.119.110]) by fmsmga001.fm.intel.com with ESMTP; 01 Nov 2018 01:58:07 -0700 To: Peng Yuan , dts@dpdk.org References: <1540284458-7068-1-git-send-email-yuan.peng@intel.com> From: Lijuan Tu Message-ID: <3c00c7fa-0871-59bf-6331-3c89ac50b9d3@intel.com> Date: Fri, 2 Nov 2018 01:26:02 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1540284458-7068-1-git-send-email-yuan.peng@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dts] [PATCH]: test_plans: changed rss_to_rte_flow_test_plan.rst X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 08:58:09 -0000 On 2018年10月23日 16:47, Peng Yuan wrote: > Added 'none' and 'all' to rss types in action list. > Added 'key' and 'key_len' to rss items in action list. > > Signed-off-by: Peng Yuan > > diff --git a/test_plans/rss_to_rte_flow_test_plan.rst b/test_plans/rss_to_rte_flow_test_plan.rst > index 6919541..d4910d4 100644 > --- a/test_plans/rss_to_rte_flow_test_plan.rst > +++ b/test_plans/rss_to_rte_flow_test_plan.rst > @@ -36,11 +36,13 @@ Move RSS to rte_flow > Description > =========== > > -rte_flow has been actually defined to include RSS, but till now, > -RSS is out of rte_flow. It was suggested to move existing RSS to rte_flow. > -This can be better for users, and may save effort for CPK development. > -RSS enabling: now, rte_flow API enabling RSS is support on igb/ixgbe/i40e. > -RSS input set changing: now, rte flow API RSS input set is support on i40e > + rte_flow has been actually defined to include RSS, but till now, > + RSS is out of rte_flow. It was suggested to move existing RSS to rte_flow. > + This can be better for users, and may save effort for CPK development. > + RSS enabling: now, rte_flow API enabling RSS is support on igb/ixgbe/i40e. > + RSS input set changing: now, rte flow API RSS input set is support on i40e > + > + Notes:non-default RSS hash functions are not supported -- Operation not supported Could you remove these space? and found multiple tailing whitespace in the patch. > > Prerequisites > ============= > @@ -62,34 +64,98 @@ Prerequisites > pkt2 = Ether(dst="00:00:00:00:01:00")/IP(src="10.0.0.1",dst="192.168.0.2")/UDP(dport=50, sport=50)/("X"*48) > pkt3 = Ether(dst="00:00:00:00:01:00")/IP(src="10.0.0.1",dst="192.168.0.3")/TCP(dport=50, sport=50)/("X"*48) > pkt4 = Ether(dst="00:00:00:00:01:00")/IP(src="10.0.0.1",dst="192.168.0.2")/("X"*48) > - pkt5 = Ether(dst="00:00:00:00:01:00")/IPv6(src="2001::1",dst="2001::2")/SCTP(dport=80, sport=80)/("X"*48) > + pkt5 = Ether(dst="00:00:00:00:01:00")/IPv6(src="2001::1",dst="2001::2",nh=132)/SCTP(dport=80, sport=80)/("X"*48) > pkt6 = Ether(dst="00:00:00:00:01:00")/IPv6(src="2001::1",dst="2001::2")/UDP(dport=50, sport=50)/("X"*48) > pkt7 = Ether(dst="00:00:00:00:01:00")/IPv6(src="2001::1",dst="2001::2")/TCP(dport=50, sport=50)/("X"*48) > pkt8 = Ether(dst="00:00:00:00:01:00")/IPv6(src="2001::1",dst="2001::2")/("X"*48) > > -Test case: enable RSS by rte_flow > +Test case: disable and enable rss > ================================= > > 1. Start the testpmd:: > > - ./testpmd -c 0x3 -n 4 -- -i --rxq=4 --txq=4 --port-topology=chained > + ./testpmd -c 1ffff -n 4 -- -i --nb-cores=8 --rxq=4 --txq=4 --port-topology=chained > testpmd> set fwd rxonly > testpmd> set verbose 1 > testpmd> start > > -2. Enable ipv4-udp, and set all the queues into RSS queue rule:: > +2. Show port default RSS fuctions:: > + > + testpmd> show port 0 rss-hash > + RSS functions: > + ipv4-frag ipv4-other ipv6-frag ipv6-other ip > + > + Send the ipv4-other packets with different src/dst ip address. > + All the packets are distributed to all the four queues. > + > +3. disable all RSS fuctions:: > + > + testpmd> flow create 0 ingress pattern end actions rss types none end / end > + Flow rule #0 created > + testpmd> show port 0 rss-hash > + RSS disabled > + > + Send the ipv4-udp packets with different src/dst ip address. > + All the packets are distributed to queue 0. > + Notes: only i40e support the command, > + others don't support the command created. > + > +4. enable RSS fuction with all RSS hash type:: > + > + testpmd> flow create 0 ingress pattern end actions rss types all end / end > + Flow rule #1 created > + testpmd> show port 0 rss-hash > + RSS functions: > + all ipv4-frag ipv4-tcp ipv4-udp ipv4-sctp ipv4-other ipv6-frag ipv6-tcp ipv6-udp ipv6-sctp ipv6-other l2-payload ip udp tcp sctp > + > + Send the ipv4-udp packets with different src/dst ip address. > + All the packets are distributed to all the four queues. > + > +Notes: the default RSS functions are different among several NICs. > +here shows the printing of NIC with i40e driver. > + > +Test case: enable ipv4-udp rss > +============================== > + > +1. Start the testpmd:: > + > + ./testpmd -c 1ffff -n 4 -- -i --nb-cores=8 --rxq=4 --txq=4 --port-topology=chained > + testpmd> set fwd rxonly > + testpmd> set verbose 1 > + testpmd> start > + > +2. Show port default RSS fuctions:: > + > + testpmd> show port 0 rss-hash > + RSS functions: > + ipv4-frag ipv4-other ipv6-frag ipv6-other ip > + > + Send the ipv4-other packets with different src/dst ip address. > + All the packets are distributed to all the four queues. > + Send the ipv4-udp packets with different src/dst ip and sport/dport. > + All the packets are distributed to queue 0. > + Notes: different NICs has different default RSS type function. > + the result is for i40e. > + > +3. Enable ipv4-udp, and set all the queues into RSS queue rule:: > > testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end / end > + Flow rule #0 created > + testpmd> show port 0 rss-hash > + RSS functions: > + ipv4-udp udp > > -3. Send the ipv4-udp packets with different 5-tuple parameters. > + Send the ipv4-other packets with different src/dst ip address. > + All the packets are distributed to queue 0. > + Send the ipv4-udp packets with different src/dst ip and sport/dport. > All the packets are distributed to all the four queues. > > -Test case: set valid and invalid parameter with all types > -========================================================= > +Test case: set valid and invalid queue > +====================================== > > 1. Start the testpmd:: > > - ./testpmd -c 0x3 -n 4 -- -i --rxq=16 --txq=16 --port-topology=chained > + ./testpmd -c 1ffff -n 4 -- -i --nb-cores=8 --rxq=16 --txq=16 --port-topology=chained > testpmd> set fwd rxonly > testpmd> set verbose 1 > testpmd> start > @@ -98,45 +164,52 @@ Test case: set valid and invalid parameter with all types > > testpmd> flow create 0 ingress pattern end actions rss queues 0 8 15 end / end > > -3. Send the eight packets to port 0. > + Send the ipv4-other packets with different src/dst ip address. > All the packets are distributed to queue 0/8/15. > + Send the ipv4-udp packets with different src/dst ip and sport/dport. > + All the packets are distributed to queue 0. > > -4. Set a second RSS queue rule:: > +3. Set a second RSS queue rule:: > > testpmd> flow create 0 ingress pattern end actions rss queues 3 end / end > - Caught error type 2 (flow rule (handle)): Failed to create flow. > + testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end queues 3 end / end > > + The two rules failed to be created. > There can't be more than one RSS queue rule. > > -5. Reset the RSS queue rule:: > +4. Reset the RSS queue rule:: > > testpmd> flow flush 0 > - testpmd> flow create 0 ingress pattern end actions rss queues 3 end / end > + testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end queues 3 end / end > > The rule is set successfully. > - Send the eight packets to port 0, all of them are distributed to queue 3. > + Send the ipv4-other packets with different src/dst ip address. > + All the packets are distributed to queue 0. > + Send the ipv4-udp packets with different src/dst ip and sport/dport. > + All the packets are distributed to queue 0/8/15. > > -6. Set a wrong parameter: queue ID is 16 :: > +5. Set a wrong parameter: queue ID is 16 :: > > testpmd> flow create 0 ingress pattern end actions rss queues 16 end / end > - Caught error type 11 (specific action): cause: 0x7ffdb2bbe6e8, queue id > max number of queues > > -7. Set all the queues to the rule:: > + The rule failed to be created. > + > +6. Set all the queues to the rule:: > > testpmd> flow create 0 ingress pattern end actions rss queues 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 end / end > > - Send the eight packets to port 0, the packets may be distributed to any > - of the queue 0-15. > + Send the ipv4-other packets with different src/dst ip address. > + The packets may be distributed to any of the queue 0-15. > > Notes: The max queue number may be different in different NIC types. > We can set different queue number in command line with different NIC types. > > -Test case: RSS with different packet types > -========================================== > +Test case: Different packet types > +================================= > > 1. Start the testpmd:: > > - ./testpmd -c 0x3 -n 4 -- -i --rxq=16 --txq=16 --port-topology=chained > + ./testpmd -c 1ffff -n 4 -- -i --nb-cores=8 --rxq=16 --txq=16 --port-topology=chained > testpmd> set fwd rxonly > testpmd> set verbose 1 > testpmd> start > @@ -152,16 +225,16 @@ Test case: RSS with different packet types > 4. Set a different packet type RSS queue rule:: > > testpmd> flow create 0 ingress pattern end actions rss types ipv6-other end queues 3 end / end > - Caught error type 2 (flow rule (handle)): Failed to create flow. > > + The rule failed to be created. > There can't be more than one RSS queue rule. > > -Test case: disable RSS in command-line > +Test case: disable rss in command-line > ====================================== > > 1. Start the testpmd:: > > - ./testpmd -c 0x3 -n 4 -- -i --rxq=16 --txq=16 --disable-rss --port-topology=chained > + ./testpmd -c 0x3 -n 4 -- -i --rxq=8 --txq=8 --disable-rss --port-topology=chained > testpmd> set fwd rxonly > testpmd> set verbose 1 > testpmd> start > @@ -169,12 +242,19 @@ Test case: disable RSS in command-line > 2. Send the eight packets to port 0. > All the packets are distributed to queue 0. > > -3. Set the RSS queue rule:: > +3. enable all RSS function type:: > + > + testpmd> flow create 0 ingress pattern end actions rss types all end / end > + > + Send the eight packets to port 0. > + All the packets are distributed to any of queue 0-7 > + > + or set the RSS queue rule:: > > - testpmd> flow create 0 ingress pattern end actions rss types ipv6-tcp ipv4-udp sctp ipv6-other end queues 6 7 8 end / end > + testpmd> flow create 0 ingress pattern end actions rss types ipv6-tcp ipv4-udp sctp ipv6-other end queues 5 6 7 end / end > > Send the eight packets to port 0. > - pkt1/pkt2/pkt5/pkt7/pkt8 are distributed to queue 6/7/8. > + pkt1/pkt2/pkt5/pkt7/pkt8 are distributed to queue 5/6/7. > Other packets are distributed to queue 0. > > 4. Clean the rule:: > @@ -184,51 +264,133 @@ Test case: disable RSS in command-line > Send the eight packets to port 0. > All the packets are distributed to queue 0. > > -Test case: Flow director rule and RSS rule combination > +Test case: set key and key_len > +============================== > + > +Only i40e support key and key_len setting. > +1. Start the testpmd:: > + > + ./testpmd -c 1ffff -n 4 -- -i --nb-cores=8 --rxq=4 --txq=4 --port-topology=chained > + testpmd> set fwd rxonly > + testpmd> set verbose 1 > + testpmd> start > + > +2. Set ipv4-udp RSS and show the RSS key:: > + > + testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end / end > + testpmd> show port 0 rss-hash key > + RSS functions: > + ipv4-udp udp > + RSS key: > + 74657374706D6427732064656661756C74205253532068617368206B65792C206F7665727269646520697420666F722062657474 > + > + Send the five packets to port 0:: > + > + pkt1 = Ether(dst='00:00:00:00:01:00')/IP(src='0.0.0.0',dst='4.0.0.0')/UDP(sport=100,dport=200)/('X'*48) > + pkt2 = Ether(dst='00:00:00:00:01:00')/IP(src='0.0.0.0',dst='4.0.0.0')/UDP(sport=100,dport=201)/('X'*48) > + pkt3 = Ether(dst='00:00:00:00:01:00')/IP(src='0.0.0.0',dst='4.0.0.0')/UDP(sport=101,dport=201)/('X'*48) > + pkt4 = Ether(dst='00:00:00:00:01:00')/IP(src='0.0.0.0',dst='4.0.0.1')/UDP(sport=101,dport=201)/('X'*48) > + pkt5 = Ether(dst='00:00:00:00:01:00')/IP(src='0.0.0.1',dst='4.0.0.1')/UDP(sport=101,dport=201)/('X'*48) > + > + pkt1 is distributed to queue 1. > + pkt2 is distributed to queue 3. > + pkt3 is distributed to queue 3. > + pkt4 is distributed to queue 1. > + pkt5 is distributed to queue 2. > + > +3. Set ipv4-udp key:: > + > + testpmd> flow flush 0 > + testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end key 67108863 / end > + testpmd> show port 0 rss-hash key > + RSS functions: > + ipv4-udp udp > + RSS key: > + 4439796BB54C5023B675EA5B124F9F30B8A2C03DDFDC4D02A08C9B334AF64A4C05C6FA343958D8557D99583AE138C92E81150366 > + > + Send the same five packets to port 0, > + pkt1 is distributed to queue 3. > + pkt2 is distributed to queue 3. > + pkt3 is distributed to queue 0. > + pkt4 is distributed to queue 1. > + pkt5 is distributed to queue 0. > + > +4. Set ipv4-udp key_len:: > + > + testpmd> flow flush 0 > + testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end key_len 3 / end > + testpmd> show port 0 rss-hash key > + RSS functions: > + ipv4-udp udp > + RSS key: > + 4439796BB54C5023B675EA5B124F9F30B8A2C03DDFDC4D02A08C9B334AF64A4C05C6FA343958D8557D99583AE138C92E81150366 > + > + Send the same five packets to port 0, > + pkt1 is distributed to queue 3. > + pkt2 is distributed to queue 3. > + pkt3 is distributed to queue 0. > + pkt4 is distributed to queue 1. > + pkt5 is distributed to queue 0. > + > +5. Set ipv4-udp key and key_len:: > + > + testpmd> flow flush 0 > + testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end key 67108863 key_len 3 / end > + testpmd> show port 0 rss-hash key > + RSS functions: > + ipv4-udp udp > + RSS key: > + 4439796BB54C5023B675EA5B124F9F30B8A2C03DDFDC4D02A08C9B334AF64A4C05C6FA343958D8557D99583AE138C92E81150366 > + > + Send the same five packets to port 0, > + pkt1 is distributed to queue 3. > + pkt2 is distributed to queue 3. > + pkt3 is distributed to queue 0. > + pkt4 is distributed to queue 1. > + pkt5 is distributed to queue 0. > + > +Test case: Flow directory rule and RSS rule combination > ====================================================== > > 1. Start the testpmd:: > > - ./testpmd -c 0x3 -n 4 -- -i --rxq=16 --txq=16 --pkt-filter-mode=perfect > + ./testpmd -c 1ffff -n 4 -- -i --nb-cores=8 --rxq=16 --txq=16 --pkt-filter-mode=perfect > testpmd> set fwd rxonly > testpmd> set verbose 1 > testpmd> start > > 2. Set a RSS queue rule:: > > - testpmd> flow create 0 ingress pattern end actions rss queues 6 7 8 end / end > + testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end queues 6 7 8 end / end > > - Send pkt2 to port 0, pkt2 is distributed to queue 6. > + Send pkt2 to port 0, pkt2 is distributed to queue 8. > > -3. Set a flow director rule:: > +3. Set a flow directory rule:: > > - testpmd> flow create 0 ingress pattern eth / ipv4 src is 192.168.0.1 dst is 192.168.0.2 / udp src is 50 dst is 50 / end actions queue index 1 / end > + testpmd> flow create 0 ingress pattern eth / ipv4 src is 10.0.0.1 dst is 192.168.0.2 / udp src is 50 dst is 50 / end actions queue index 1 / end > > Send pkt2 to port 0, pkt2 is distributed to queue 1. > > -4. Destroy the flow director rule:: > +4. Destroy the flow directory rule:: > > testpmd> flow destroy 0 rule 1 > > - Send pkt2 to port 0, pkt2 is distributed to queue 6 again. > - So flow director rule is priority to RSS queue rule. > - > -Test case: Set queue region with RSS rule API > -============================================= > + Send pkt2 to port 0, pkt2 is distributed to queue 8 again. > + So flow directory filter is priority to RSS hash filter. > > -Notes: Queue region is only supported by fortville, so this case only can > -be implemented with fortville. > +Test case: Set queue-region generic flow api > +============================================== > > 1. Start the testpmd:: > > - ./testpmd -c 0x3 -n 4 -- -i --rxq=16 --txq=16 --port-topology=chained > + ./testpmd -c 1ffff -n 4 -- -i --nb-cores=16 --rxq=16 --txq=16 --port-topology=chained > testpmd> set fwd rxonly > testpmd> set verbose 1 > testpmd> start > > 2. Set a RSS queue rule:: > > - testpmd> flow create 0 ingress pattern end actions rss queues 7 8 10 11 12 14 15 end / end > + testpmd> flow create 0 ingress pattern end actions rss types ipv4-tcp end queues 7 8 10 11 12 14 15 end / end > > 3. Send pkt to port 0:: > > @@ -248,11 +410,9 @@ be implemented with fortville. > testpmd> flow create 0 ingress pattern vlan tci is 0x6000 / end actions rss queues 15 end / end > > Send the 3 packets to port 0. They are distributed to queue 7/11/15. > + So the flow directory filter is priority to RSS hash filter. > > -Notes: only rss rule API only support setting UP queue region, > -not support setting pctype queue region. > - > -5. Flush the queue region:: > +5. Flush the L2-payload rule:: > > testpmd> flow list 0 > ID Group Prio Attr Rule > @@ -269,15 +429,15 @@ not support setting pctype queue region. > 1 0 0 i- VLAN => RSS > 3 0 0 i- VLAN => RSS > > - Send the 3 packets to port 0. They are distributed to queue 0. > - Destroy one queue region rule, all the rules become invalid. > + Send the 3 packets to port 0. They are all distributed to queue 8. > + Queue region only can be deleted all or none. > > Test case: Set queue region with invalid parameter > ================================================== > > 1. Start the testpmd:: > > - ./testpmd -c 0x3 -n 4 -- -i --rxq=16 --txq=16 --port-topology=chained > + ./testpmd -c 1ffff -n 4 -- -i --nb-cores=16 --rxq=16 --txq=16 --port-topology=chained > testpmd> set fwd rxonly > testpmd> set verbose 1 > testpmd> start > @@ -291,6 +451,8 @@ Test case: Set queue region with invalid parameter > testpmd> flow create 0 ingress pattern vlan tci is 0x2000 / end actions rss queues 8 9 end / end > Caught error type 11 (specific action): cause: 0x7ffda008efe8, no valid queues > > + Queue of queue region must be included in rss function appointed queue. > + > 4. Set discontinuous queue ID to queue region:: > > testpmd> flow create 0 ingress pattern vlan tci is 0x2000 / end actions rss queues 8 10 end / end > @@ -302,7 +464,7 @@ Test case: Set queue region with invalid parameter > i40e_flow_parse_rss_action(): The region sizes should be any of the following values: 1, 2, 4, 8, 16, 32, 64 as long as the total number of queues do not exceed the VSI allocation > Caught error type 2 (flow rule (handle)): Failed to create flow. > > -Test case: Queue region(old API) and RSS rule combination > +Test case: Queue region and RSS rule combination > ========================================================= > > Notes: Queue region is only supported by fortville, so this case only can > @@ -310,7 +472,7 @@ be implemented with fortville. > > 1. Start the testpmd:: > > - ./testpmd -c 0x3 -n 4 -- -i --rxq=16 --txq=16 --port-topology=chained > + ./testpmd -c 1ffff -n 4 -- -i --nb-cores=8 --rxq=16 --txq=16 --port-topology=chained > testpmd> port config all rss all > testpmd> set fwd rxonly > testpmd> set verbose 1 > @@ -326,7 +488,7 @@ be implemented with fortville. > > 3. Set a RSS queue rule:: > > - testpmd> flow create 0 ingress pattern end actions rss queues 6 7 end / end > + testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp end queues 6 7 end / end > > Send pkt2 to port 0. It is still distributed to queue 1. >