[dts][PATCH V1 1/2] test_plans/ice_iavf_fdir: add new cases according to testplan

[dts][PATCH V1 1/2] test_plans/ice_iavf_fdir: add new cases according to testplan

[Hongbo Li]

add subcase 8 to test Kill VF process and create a new rule

Signed-off-by: Peng Yuan <yuan.peng@intel.com>
Signed-off-by: Hongbo Li <hongbox.li@intel.com>
---
 test_plans/ice_iavf_fdir_test_plan.rst | 33 ++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/test_plans/ice_iavf_fdir_test_plan.rst b/test_plans/ice_iavf_fdir_test_plan.rst
index 5f22d48e..81fc2f60 100644
--- a/test_plans/ice_iavf_fdir_test_plan.rst
+++ b/test_plans/ice_iavf_fdir_test_plan.rst
@@ -5078,6 +5078,39 @@ Subcase 7: check profile delete
 6. send the two packets again,
    check the two packets are distributed by RSS without FDIR matched ID.
 
+Subcase 8: Kill VF process and create a new rule
+------------------------------------------------
+
+1. create a rule on vf00 and vf01::
+
+    flow create 0 ingress pattern eth / ipv4 src is 192.168.0.0 dst is 192.1.0.0 tos is 4 / tcp src is 22 dst is 23 / end actions queue index 5 / mark / end
+    flow create 1 ingress pattern eth / ipv4 src is 192.168.0.0 dst is 192.1.0.0 tos is 4 / tcp src is 22 dst is 23 / end actions queue index 5 / mark / end
+
+2. send matched packet::
+
+    sendp([Ether(dst="00:11:22:33:44:55")/IP(src="192.168.0.0",dst="192.1.0.0", tos=4)/TCP(sport=22,dport=23)/Raw('x' * 80)],iface="enp134s0f1")
+    sendp([Ether(dst="00:11:22:33:44:66")/IP(src="192.168.0.0",dst="192.1.0.0", tos=4)/TCP(sport=22,dport=23)/Raw('x' * 80)],iface="enp134s0f1")
+
+   check the packet is redirected to queue 5 with FDIR matched ID=0x0.
+
+3. kill VF process in another shell::
+
+    ps -ef |grep testpmd #Check the process id
+    kill -9 <pid>
+
+4. testpmd shows::
+
+    testpmd> Killed
+
+   then relaunch testpmd.
+   the port can start normally without error message.
+
+5. check there is not rule listed on vf0 and vf1.
+
+6. repeat step 1-2.
+   check the rule can be created successfully,
+   and the packets can be redirected to queue 5 with FDIR matched ID=0x0.
+
 Test case: PFCP coverage test
 =============================
 Subcase 1: PFCP FDIR vlan strip on HW checksum offload check
-- 
2.17.1

[dts][PATCH V1 2/2] tests/ice_iavf_fdir: add new cases according to testplan

[Hongbo Li]

add subcase 8 to test Kill VF process and create a new rule

Signed-off-by: Hongbo Li <hongbox.li@intel.com>
---
 tests/TestSuite_ice_iavf_fdir.py | 67 +++++++++++++++++++++++++++++++-
 1 file changed, 66 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_ice_iavf_fdir.py b/tests/TestSuite_ice_iavf_fdir.py
index 43cac8ea..b0186c0c 100644
--- a/tests/TestSuite_ice_iavf_fdir.py
+++ b/tests/TestSuite_ice_iavf_fdir.py
@@ -8736,7 +8736,7 @@ class TestICEIAVFFdir(TestCase):
         self.pmd_output.execute_cmd("start")
 
     def launch_testpmd(self):
-        self.pmd_output.start_testpmd(
+        out = self.pmd_output.start_testpmd(
             cores="1S/4C/1T",
             param="--rxq={} --txq={}".format(self.q_num, self.q_num),
             eal_param="-a %s -a %s"
@@ -8744,6 +8744,7 @@ class TestICEIAVFFdir(TestCase):
             socket=self.ports_socket,
         )
         self.config_testpmd()
+        return out
 
     def send_packets(self, packets, pf_id=0, count=1):
         self.pkt.update_pkt(packets)
@@ -10797,6 +10798,70 @@ class TestICEIAVFFdir(TestCase):
             stats=True,
         )
 
+    def test_stress_kill_vf_process_create_new_rule(self):
+        """
+        create a fdir rule, then kill the process, relaunch testpmd, create the same fdir rule successfully and take work.
+        """
+        rules = [
+            "flow create 0 ingress pattern eth / ipv4 src is 192.168.0.0 dst is 192.1.0.0 tos is 4 / tcp src is 22 dst is 23 / end actions queue index 5 / mark / end",
+            "flow create 1 ingress pattern eth / ipv4 src is 192.168.0.0 dst is 192.1.0.0 tos is 4 / tcp src is 22 dst is 23 / end actions queue index 5 / mark / end",
+        ]
+        pkts = [
+            'Ether(dst="00:11:22:33:44:55")/IP(src="192.168.0.0",dst="192.1.0.0", tos=4)/TCP(sport=22,dport=23)/Raw("x" * 80)',
+            'Ether(dst="00:11:22:33:44:66")/IP(src="192.168.0.0",dst="192.1.0.0", tos=4)/TCP(sport=22,dport=23)/Raw("x" * 80)',
+        ]
+
+        self.create_fdir_rule(rules, check_stats=True)
+        out0 = self.send_pkts_getouput(pkts=pkts[0])
+        rfc.check_iavf_fdir_mark(
+            out0,
+            pkt_num=1,
+            check_param={"port_id": 0, "mark_id": 0, "queue": 5},
+            stats=True,
+        )
+        out1 = self.send_pkts_getouput(pkts=pkts[1])
+        rfc.check_iavf_fdir_mark(
+            out1,
+            pkt_num=1,
+            check_param={"port_id": 1, "mark_id": 0, "queue": 5},
+            stats=True,
+        )
+        # kill the process
+        self.session_secondary = self.dut.new_session()
+        out_pid = self.session_secondary.send_expect(
+            "ps -ef |grep testpmd |grep -v grep |awk '{print $2}'", "#"
+        )
+
+        kill_comd = "kill -9 %s" % (str(out_pid))
+        self.session_secondary.send_expect(kill_comd, "#")
+        self.dut.close_session(self.session_secondary)
+        # create rule again
+        out = self.launch_testpmd()
+        self.verify(
+            "fail" not in out and "Fail" not in out and "error" not in out,
+            "failed to restart testpmd normally",
+        )
+        out_flow0 = self.dut.send_expect("flow list 0", "testpmd> ")
+        out_flow1 = self.dut.send_expect("flow list 1", "testpmd> ")
+        out_flow = out_flow0 + out_flow1
+        rule_pattern = re.compile("ID.*")
+        flow = rule_pattern.findall(out_flow)
+        self.verify(len(flow) == 0, "failed to clean rule")
+        self.create_fdir_rule(rules, check_stats=True)
+        rfc.check_iavf_fdir_mark(
+            out0,
+            pkt_num=1,
+            check_param={"port_id": 0, "mark_id": 0, "queue": 5},
+            stats=True,
+        )
+        out1 = self.send_pkts_getouput(pkts=pkts[1])
+        rfc.check_iavf_fdir_mark(
+            out1,
+            pkt_num=1,
+            check_param={"port_id": 1, "mark_id": 0, "queue": 5},
+            stats=True,
+        )
+
     def test_stress_vf_port_reset_delete_rule(self):
         """
         vf reset, the origin rule can't take effect,
-- 
2.17.1

[dts][PATCH V1 2/2] tests/ice_iavf_fdir: add new cases according to testplan

[lijuan.tu]

On Sat, 31 Dec 2022 01:42:27 +0800, Hongbo Li <hongbox.li@intel.com> wrote:
> add subcase 8 to test Kill VF process and create a new rule
> 
> Signed-off-by: Hongbo Li <hongbox.li@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Series applied, thanks