From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dts-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1FA77A00BE;
	Mon, 14 Mar 2022 11:10:19 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DB02340DF4;
	Mon, 14 Mar 2022 11:10:18 +0100 (CET)
Received: from mailgw01.pantheon.sk (mailgw01.pantheon.sk [46.229.239.26])
 by mails.dpdk.org (Postfix) with ESMTP id 1878B40DDD
 for <dts@dpdk.org>; Mon, 14 Mar 2022 11:10:18 +0100 (CET)
Received: from mailgw01.pantheon.sk (localhost.localdomain [127.0.0.1])
 by mailgw01.pantheon.sk (Proxmox) with ESMTP id B79002025BE;
 Mon, 14 Mar 2022 11:10:17 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech;
 h=cc:cc:content-transfer-encoding:content-type:content-type
 :date:from:from:in-reply-to:message-id:mime-version:references
 :reply-to:subject:subject:to:to; s=dkim; bh=pdqcB2n4Wh4HowHlxiOa
 20LyFkGjFbJM16w4u7W5VCQ=; b=ycQ7pr+tpi3XhPdQ3MWgCZih6/l2X+kQMgQw
 KGXRvL+iRAhcmru6Fk0C9wlnnPBb8mZpiyKNUvWdnmawuJoESSOlf48KAGuYTavT
 0T8ZFllT+rTtW4dGv+LyqFYxpaBaveCJHtleey0dzbnCYjiVNIaJEn9/7rsV7pww
 RpFNtuC3H0vXnQrgAQO2KArGxWqfGp3GZ59VEzQHpCnrhkUIrKMuOOgIaFRZbojU
 Bm8YBZWpkrjKyGBIccuJ8GEYmUC/LdLbcIrzc3ZNOkf84q2FgNkuJZa5tSvVo3xn
 eQtfihRYz0OU3a46gl0WfPuBdvt5bSxHBXRO5vXXQM8vVjNZaA==
From: =?iso-8859-2?Q?Juraj_Linke=B9?= <juraj.linkes@pantheon.tech>
To: Jun Dong <junx.dong@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
CC: "lijuan.tu@intel.com" <lijuan.tu@intel.com>, "qingx.sun@intel.com"
 <qingx.sun@intel.com>
Subject: RE: [dts] [V4] framework/*: Modified create_eal_parameters API to
 support flexibility
Thread-Topic: [dts] [V4] framework/*: Modified create_eal_parameters API to
 support flexibility
Thread-Index: AQHYLqIJpfDULjfL+Ue5QC5dthRre6y+uWTg
Date: Mon, 14 Mar 2022 10:10:16 +0000
Message-ID: <3dc1249a1e5e4368a3950ed954f54259@pantheon.tech>
References: <20220303015715.4668-1-junx.dong@intel.com>
In-Reply-To: <20220303015715.4668-1-junx.dong@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.101.4.10]
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
Errors-To: dts-bounces@dpdk.org

> Subject: [dts] [V4] framework/*: Modified create_eal_parameters API to
> support flexibility
>=20
> Signed-off-by: Jun Dong <junx.dong@intel.com>


>  class ParameterInvalidException(Exception):
> -    pass
> +    def __init__(self, param_name: str, param_value: Any):
> +        self.param_name =3D param_name
> +        self.param_value =3D param_value
> +
> +    def __str__(self) -> str:
> +        return f'Invalid parameter of {self.param_name} about value of
> {self.param_value}, Please reference API doc.'
> +
>=20

Hi Jun, the above section of the patch introduced these errors:
framework/tester.py:277: [E] E1120 No value for argument 'param_value' in c=
onstructor call [pylint]
framework/tester.py:286: [E] E1120 No value for argument 'param_value' in c=
onstructor call [pylint]
framework/tester.py:298: [E] E1120 No value for argument 'param_value' in c=
onstructor call [pylint]

Would you please fix the usage of the newly implemented exception?

Thanks,
Juraj