From: "Zhu, ShuaiX" <shuaix.zhu@intel.com>
To: Rami Rosen <ramirose@gmail.com>
Cc: "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] tests/ipfrag:Modify the way to get the core.
Date: Thu, 24 Jan 2019 02:32:35 +0000 [thread overview]
Message-ID: <4DC48DF9BDA3E54A836D2D3C057DEC6F0B12BF08@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <CAHLOa7QG-S3hhxP3HwN-Ye35fv49L0iE95w36cpp8+8YgdpxNA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1501 bytes --]
I think that using the all parameter should be possible in the current code. Some platforms have fewer core values than fixed values. For example, using 2S/4C/2T, the following error occurs: Cannot get requested core configuration requested 2S/4C/2T have.
From: Rami Rosen [mailto:ramirose@gmail.com]
Sent: Thursday, January 24, 2019 9:54 AM
To: Zhu, ShuaiX <shuaix.zhu@intel.com>
Cc: dts@dpdk.org
Subject: Re: [dts] [PATCH V1] tests/ipfrag:Modify the way to get the core.
Hi, Zhu,
> Some platforms have a core number less than a fixed value.
Thanks for this patch. You are right, obviously there are platforms with other combinations than
"2S/2C/2T", and actually I myself run DTS on diifferent platforms than this and had some issues related to it with various DTS test modules.
I have a question, though,if I may:
On which platform ( i mean which combination of socket/core/thread in that platform) did the solution of using cores = self.dut.get_core_listst("all") instead of the hard coded "2S/2C/2T" worked for you for this ipfrag Test Module?
And a general question to DTS developers/maintainer: all the DTS test suites use hard coded values for the S/C/T combination. And obviously this will fail on certain platforms. Wouldn't it be reasonable to replace all these occurrences with self.dut.get_core_listst("all") ? Will self.dut.get_core_listst("all") always work, for any combination of socket/core/thread ? Will this work for 2S/4C/2T ?
Regards,
Rami Rosen
[-- Attachment #2: Type: text/html, Size: 5892 bytes --]
next prev parent reply other threads:[~2019-01-24 2:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 1:30 zhu,shuai
2019-01-24 1:54 ` Rami Rosen
2019-01-24 2:32 ` Zhu, ShuaiX [this message]
2019-01-24 2:49 ` Tu, Lijuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC48DF9BDA3E54A836D2D3C057DEC6F0B12BF08@SHSMSX101.ccr.corp.intel.com \
--to=shuaix.zhu@intel.com \
--cc=dts@dpdk.org \
--cc=ramirose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).